Olaf Hering
2013-Feb-01 17:15 UTC
[PATCH] tools/xc: fix logic error in stdiostream_progress
# HG changeset patch # User Olaf Hering <olaf@aepfle.de> # Date 1359738883 -3600 # Node ID 6d1d516ecaade56f796e3216e9931fdcc12282cd # Parent 6727070b4129cf852199b66b6a81042ee6966a98 tools/xc: fix logic error in stdiostream_progress Setting XTL_STDIOSTREAM_HIDE_PROGRESS should disable progress reporting, instead of not setting it. Signed-off-by: Olaf Hering <olaf@aepfle.de> diff -r 6727070b4129 -r 6d1d516ecaad tools/libxc/xtl_logger_stdio.c --- a/tools/libxc/xtl_logger_stdio.c +++ b/tools/libxc/xtl_logger_stdio.c @@ -89,7 +89,7 @@ static void stdiostream_progress(struct int newpel, extra_erase; xentoollog_level this_level; - if (!(lg->flags & XTL_STDIOSTREAM_HIDE_PROGRESS)) + if (lg->flags & XTL_STDIOSTREAM_HIDE_PROGRESS) return; if (percent < lg->progress_last_percent) {
Ian Campbell
2013-Feb-04 11:04 UTC
Re: [PATCH] tools/xc: fix logic error in stdiostream_progress
On Fri, 2013-02-01 at 17:15 +0000, Olaf Hering wrote:> # HG changeset patch > # User Olaf Hering <olaf@aepfle.de> > # Date 1359738883 -3600 > # Node ID 6d1d516ecaade56f796e3216e9931fdcc12282cd > # Parent 6727070b4129cf852199b66b6a81042ee6966a98 > tools/xc: fix logic error in stdiostream_progress > > Setting XTL_STDIOSTREAM_HIDE_PROGRESS should disable progress reporting, > instead of not setting it.Oops!> Signed-off-by: Olaf Hering <olaf@aepfle.de>Acked-by: Ian Campbell <ian.campbell@citrix.com> > diff -r 6727070b4129 -r 6d1d516ecaad tools/libxc/xtl_logger_stdio.c > --- a/tools/libxc/xtl_logger_stdio.c > +++ b/tools/libxc/xtl_logger_stdio.c > @@ -89,7 +89,7 @@ static void stdiostream_progress(struct > int newpel, extra_erase; > xentoollog_level this_level; > > - if (!(lg->flags & XTL_STDIOSTREAM_HIDE_PROGRESS)) > + if (lg->flags & XTL_STDIOSTREAM_HIDE_PROGRESS) > return; > > if (percent < lg->progress_last_percent) { > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel