xen.org
2013-Jan-16 04:29 UTC
[xen-unstable bisection] complete test-amd64-amd64-xl-qemuu-winxpsp3
branch xen-unstable
xen branch xen-unstable
job test-amd64-amd64-xl-qemuu-winxpsp3
test guest-saverestore
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Bug introduced: ba386fd2bf17
Bug not present: bf1e34d66558
changeset: 26350:ba386fd2bf17
user: Daniel De Graaf <dgdegra@tycho.nsa.gov>
date: Fri Jan 11 10:07:19 2013 +0000
xen: avoid calling rcu_lock_*target_domain when an XSM hook exists
The rcu_lock_{,remote_}target_domain_by_id functions are wrappers
around an IS_PRIV_FOR check for the current domain. This is now
redundant with XSM hooks, so replace these calls with
rcu_lock_domain_by_any_id or rcu_lock_remote_domain_by_id to remove
the duplicate permission checks.
When XSM_ENABLE is not defined or when the dummy XSM module is used,
this patch should not change any functionality. Because the locations
of privilege checks have sometimes moved below argument validation,
error returns of some functions may change from EPERM to EINVAL when
called with invalid arguments and from a domain without permission to
perform the operation.
Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Acked-by: Jan Beulich <jbeulich@suse.com>
Committed-by: Keir Fraser <keir@xen.org>
For bisection revision-tuple graph see:
http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.test-amd64-amd64-xl-qemuu-winxpsp3.guest-saverestore.html
Revision IDs in each graph node refer, respectively, to the Trees above.
----------------------------------------
Searching for failure / basis pass:
15065 fail [host=bush-cricket] / 14856 ok.
Failure / basis pass flights: 15065 / 14856
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Latest a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 78ed15cfd96a
Basis pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 35a0556a7f76
Generating revisions with ./adhoc-revtuple-generator
git://xenbits.xen.org/linux-pvops.git#a938a246d34912423c560f475ccf1ce0c71d9d00-a938a246d34912423c560f475ccf1ce0c71d9d00
git://xenbits.xen.org/staging/qemu-xen-unstable.git#6a0cf3786f1964fdf5a17f88f26cb499f4e89c81-6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
git://xenbits.xen.org/staging/qemu-upstream-unstable.git#3752993df8af5cffa1b8219fe175d235597b4474-3752993df8af5cffa1b8219fe175d235597b4474
http://xenbits.xen.org/hg/staging/xen-unstable.hg#35a0556a7f76-78ed15cfd96a
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
Loaded 129 nodes in revision graph
Searching for test results:
14855 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 35a0556a7f76
14856 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 35a0556a7f76
14857 []
14869 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 32758c974bf8
14884 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14877 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14898 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14891 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14909 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14916 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14932 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 5db9c4e12fbf
14946 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 5db9c4e12fbf
14939 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 5db9c4e12fbf
15037 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 f6a81b41ad71
15046 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 21a2ecc73183
15082 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 ba386fd2bf17
15056 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 21a2ecc73183
15070 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 35a0556a7f76
15071 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 21a2ecc73183
15072 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 0bc879ecb8b3
15065 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 78ed15cfd96a
15073 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 f59daf171886
15075 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 78ed15cfd96a
15076 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 fd939d1a9b30
15077 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 bf1e34d66558
15078 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 ba386fd2bf17
15079 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 bf1e34d66558
15080 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 ba386fd2bf17
15081 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 bf1e34d66558
Searching for interesting versions
Result found: flight 14855 (pass), for basis pass
Result found: flight 15065 (fail), for basis failure
Repro found: flight 15070 (pass), for basis pass
Repro found: flight 15075 (fail), for basis failure
0 revisions at a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 bf1e34d66558
No revisions left to test, checking graph state.
Result found: flight 15077 (pass), for last pass
Result found: flight 15078 (fail), for first failure
Repro found: flight 15079 (pass), for last pass
Repro found: flight 15080 (fail), for first failure
Repro found: flight 15081 (pass), for last pass
Repro found: flight 15082 (fail), for first failure
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Bug introduced: ba386fd2bf17
Bug not present: bf1e34d66558
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
changeset: 26350:ba386fd2bf17
user: Daniel De Graaf <dgdegra@tycho.nsa.gov>
date: Fri Jan 11 10:07:19 2013 +0000
xen: avoid calling rcu_lock_*target_domain when an XSM hook exists
The rcu_lock_{,remote_}target_domain_by_id functions are wrappers
around an IS_PRIV_FOR check for the current domain. This is now
redundant with XSM hooks, so replace these calls with
rcu_lock_domain_by_any_id or rcu_lock_remote_domain_by_id to remove
the duplicate permission checks.
When XSM_ENABLE is not defined or when the dummy XSM module is used,
this patch should not change any functionality. Because the locations
of privilege checks have sometimes moved below argument validation,
error returns of some functions may change from EPERM to EINVAL when
called with invalid arguments and from a domain without permission to
perform the operation.
Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Acked-by: Jan Beulich <jbeulich@suse.com>
Committed-by: Keir Fraser <keir@xen.org>
Revision graph left in
/home/xc_osstest/results/bisect.xen-unstable.test-amd64-amd64-xl-qemuu-winxpsp3.guest-saverestore.{dot,ps,png,html}.
----------------------------------------
15082: tolerable ALL FAIL
flight 15082 xen-unstable real-bisect [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/15082/
Failures :-/ but no regressions.
Tests which did not succeed,
including tests which could not be run:
test-amd64-amd64-xl-qemuu-winxpsp3 8 guest-saverestore fail baseline untested
jobs:
test-amd64-amd64-xl-qemuu-winxpsp3 fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary