xen.org
2013-Jan-15 04:44 UTC
[xen-unstable bisection] complete test-amd64-i386-xl-win-vcpus1
branch xen-unstable
xen branch xen-unstable
job test-amd64-i386-xl-win-vcpus1
test guest-saverestore
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Bug introduced: ba386fd2bf17
Bug not present: bf1e34d66558
changeset: 26350:ba386fd2bf17
user: Daniel De Graaf <dgdegra@tycho.nsa.gov>
date: Fri Jan 11 10:07:19 2013 +0000
xen: avoid calling rcu_lock_*target_domain when an XSM hook exists
The rcu_lock_{,remote_}target_domain_by_id functions are wrappers
around an IS_PRIV_FOR check for the current domain. This is now
redundant with XSM hooks, so replace these calls with
rcu_lock_domain_by_any_id or rcu_lock_remote_domain_by_id to remove
the duplicate permission checks.
When XSM_ENABLE is not defined or when the dummy XSM module is used,
this patch should not change any functionality. Because the locations
of privilege checks have sometimes moved below argument validation,
error returns of some functions may change from EPERM to EINVAL when
called with invalid arguments and from a domain without permission to
perform the operation.
Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Acked-by: Jan Beulich <jbeulich@suse.com>
Committed-by: Keir Fraser <keir@xen.org>
For bisection revision-tuple graph see:
http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.test-amd64-i386-xl-win-vcpus1.guest-saverestore.html
Revision IDs in each graph node refer, respectively, to the Trees above.
----------------------------------------
Searching for failure / basis pass:
15037 fail [host=earwig] / 14856 ok.
Failure / basis pass flights: 15037 / 14856
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Latest a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 f6a81b41ad71
Basis pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 35a0556a7f76
Generating revisions with ./adhoc-revtuple-generator
git://xenbits.xen.org/linux-pvops.git#a938a246d34912423c560f475ccf1ce0c71d9d00-a938a246d34912423c560f475ccf1ce0c71d9d00
git://xenbits.xen.org/staging/qemu-xen-unstable.git#6a0cf3786f1964fdf5a17f88f26cb499f4e89c81-6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
git://xenbits.xen.org/staging/qemu-upstream-unstable.git#3752993df8af5cffa1b8219fe175d235597b4474-3752993df8af5cffa1b8219fe175d235597b4474
http://xenbits.xen.org/hg/staging/xen-unstable.hg#35a0556a7f76-f6a81b41ad71
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
Loaded 118 nodes in revision graph
Searching for test results:
14855 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 35a0556a7f76
14856 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 35a0556a7f76
14857 []
14869 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 32758c974bf8
14884 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14877 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14898 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14891 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14909 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14916 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14932 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 5db9c4e12fbf
14946 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 5db9c4e12fbf
14939 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 5db9c4e12fbf
15041 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 5db9c4e12fbf
15040 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 35a0556a7f76
15042 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 0bc879ecb8b3
15043 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 f59daf171886
15048 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 bf1e34d66558
15037 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 f6a81b41ad71
15045 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 fd939d1a9b30
15047 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 f6a81b41ad71
15049 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 ba386fd2bf17
15050 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 bf1e34d66558
15051 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 ba386fd2bf17
15053 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 bf1e34d66558
15054 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 ba386fd2bf17
Searching for interesting versions
Result found: flight 14855 (pass), for basis pass
Result found: flight 15037 (fail), for basis failure
Repro found: flight 15040 (pass), for basis pass
Repro found: flight 15047 (fail), for basis failure
0 revisions at a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 bf1e34d66558
No revisions left to test, checking graph state.
Result found: flight 15048 (pass), for last pass
Result found: flight 15049 (fail), for first failure
Repro found: flight 15050 (pass), for last pass
Repro found: flight 15051 (fail), for first failure
Repro found: flight 15053 (pass), for last pass
Repro found: flight 15054 (fail), for first failure
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Bug introduced: ba386fd2bf17
Bug not present: bf1e34d66558
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
changeset: 26350:ba386fd2bf17
user: Daniel De Graaf <dgdegra@tycho.nsa.gov>
date: Fri Jan 11 10:07:19 2013 +0000
xen: avoid calling rcu_lock_*target_domain when an XSM hook exists
The rcu_lock_{,remote_}target_domain_by_id functions are wrappers
around an IS_PRIV_FOR check for the current domain. This is now
redundant with XSM hooks, so replace these calls with
rcu_lock_domain_by_any_id or rcu_lock_remote_domain_by_id to remove
the duplicate permission checks.
When XSM_ENABLE is not defined or when the dummy XSM module is used,
this patch should not change any functionality. Because the locations
of privilege checks have sometimes moved below argument validation,
error returns of some functions may change from EPERM to EINVAL when
called with invalid arguments and from a domain without permission to
perform the operation.
Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Acked-by: Jan Beulich <jbeulich@suse.com>
Committed-by: Keir Fraser <keir@xen.org>
Revision graph left in
/home/xc_osstest/results/bisect.xen-unstable.test-amd64-i386-xl-win-vcpus1.guest-saverestore.{dot,ps,png,html}.
----------------------------------------
15054: tolerable ALL FAIL
flight 15054 xen-unstable real-bisect [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/15054/
Failures :-/ but no regressions.
Tests which did not succeed,
including tests which could not be run:
test-amd64-i386-xl-win-vcpus1 8 guest-saverestore fail baseline untested
jobs:
test-amd64-i386-xl-win-vcpus1 fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
Ian Campbell
2013-Jan-15 09:55 UTC
Re: [xen-unstable bisection] complete test-amd64-i386-xl-win-vcpus1
Adding Daniel & Jan.
Looking at the most recently failed flight
http://www.chiark.greenend.org.uk/~xensrcts/logs/15046/test-amd64-i386-xl-win-vcpus1/info.html
we have
http://www.chiark.greenend.org.uk/~xensrcts/logs/15046/test-amd64-i386-xl-win-vcpus1/8.ts-guest-saverestore.log
which contains:
Loading new save file image (new xl fmt info 0x0/0x0/620)
Savefile contains xl domain config
WARNING: ignoring "kernel" directive for HVM guest. Use
"firmware_override" instead if you really want a non-default firmware
xc: error: panic: xc_dom_boot.c:410: xc_dom_gnttab_hvm_seed: failed to
remove gnttab from physmap [errno=2]
: Internal error
xc: error: error seeding grant table: Internal error
libxl: error: libxl_create.c:787:libxl__xc_domain_restore_done:
restoring domain: Resource temporarily unavailable
libxl: error: libxl_create.c:869:domcreate_rebuild_done: cannot
(re-)build domain: -3
libxl: error: libxl.c:1377:libxl__destroy_domid: non-existant domain 5
libxl: error: libxl.c:1341:domain_destroy_callback: unable to destroy
guest with domid 5
libxl: error: libxl_create.c:1175:domcreate_destruction_cb: unable to
destroy domain 5 following failed creation
Parsing config from /etc/xen/win.guest.osstest.cfg
Which is the same as the bisection result here
http://www.chiark.greenend.org.uk/~xensrcts/logs/15054/test-amd64-i386-xl-win-vcpus1/8.ts-guest-saverestore.log
I''ve eye balled 26350:ba386fd2bf17, especially the bits about the
phsymap hypercalls and I can''t see anything obvious.
Ian.
On Tue, 2013-01-15 at 04:44 +0000, xen.org wrote:> branch xen-unstable
> xen branch xen-unstable
> job test-amd64-i386-xl-win-vcpus1
> test guest-saverestore
>
> Tree: linux git://xenbits.xen.org/linux-pvops.git
> Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
> Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
> Tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
>
> *** Found and reproduced problem changeset ***
>
> Bug is in tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
> Bug introduced: ba386fd2bf17
> Bug not present: bf1e34d66558
>
>
> changeset: 26350:ba386fd2bf17
> user: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> date: Fri Jan 11 10:07:19 2013 +0000
>
> xen: avoid calling rcu_lock_*target_domain when an XSM hook exists
>
> The rcu_lock_{,remote_}target_domain_by_id functions are wrappers
> around an IS_PRIV_FOR check for the current domain. This is now
> redundant with XSM hooks, so replace these calls with
> rcu_lock_domain_by_any_id or rcu_lock_remote_domain_by_id to remove
> the duplicate permission checks.
>
> When XSM_ENABLE is not defined or when the dummy XSM module is used,
> this patch should not change any functionality. Because the locations
> of privilege checks have sometimes moved below argument validation,
> error returns of some functions may change from EPERM to EINVAL when
> called with invalid arguments and from a domain without permission to
> perform the operation.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com> Jan Beulich
<jbeulich@suse.com> Jan Beulich <jbeulich@suse.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> Committed-by: Keir Fraser <keir@xen.org>
>
>
>
>
> For bisection revision-tuple graph see:
>
http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.test-amd64-i386-xl-win-vcpus1.guest-saverestore.html
> Revision IDs in each graph node refer, respectively, to the Trees above.
>
> ----------------------------------------
> Searching for failure / basis pass:
> 15037 fail [host=earwig] / 14856 ok.
> Failure / basis pass flights: 15037 / 14856
> Tree: linux git://xenbits.xen.org/linux-pvops.git
> Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
> Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
> Tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
> Latest a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 f6a81b41ad71
> Basis pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 35a0556a7f76
> Generating revisions with ./adhoc-revtuple-generator
git://xenbits.xen.org/linux-pvops.git#a938a246d34912423c560f475ccf1ce0c71d9d00-a938a246d34912423c560f475ccf1ce0c71d9d00
git://xenbits.xen.org/staging/qemu-xen-unstable.git#6a0cf3786f1964fdf5a17f88f26cb499f4e89c81-6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
git://xenbits.xen.org/staging/qemu-upstream-unstable.git#3752993df8af5cffa1b8219fe175d235597b4474-3752993df8af5cffa1b8219fe175d235597b4474
http://xenbits.xen.org/hg/staging/xen-unstable.hg#35a0556a7f76-f6a81b41ad71
> pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
> searching for changes
> no changes found
> pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
> searching for changes
> no changes found
> Loaded 118 nodes in revision graph
> Searching for test results:
> 14855 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 35a0556a7f76
> 14856 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 35a0556a7f76
> 14857 []
> 14869 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 32758c974bf8
> 14884 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
> 14877 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
> 14898 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
> 14891 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
> 14909 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
> 14916 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
> 14932 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 5db9c4e12fbf
> 14946 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 5db9c4e12fbf
> 14939 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 5db9c4e12fbf
> 15041 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 5db9c4e12fbf
> 15040 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 35a0556a7f76
> 15042 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 0bc879ecb8b3
> 15043 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 f59daf171886
> 15048 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 bf1e34d66558
> 15037 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 f6a81b41ad71
> 15045 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 fd939d1a9b30
> 15047 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 f6a81b41ad71
> 15049 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 ba386fd2bf17
> 15050 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 bf1e34d66558
> 15051 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 ba386fd2bf17
> 15053 pass a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 bf1e34d66558
> 15054 fail a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 ba386fd2bf17
> Searching for interesting versions
> Result found: flight 14855 (pass), for basis pass
> Result found: flight 15037 (fail), for basis failure
> Repro found: flight 15040 (pass), for basis pass
> Repro found: flight 15047 (fail), for basis failure
> 0 revisions at a938a246d34912423c560f475ccf1ce0c71d9d00
6a0cf3786f1964fdf5a17f88f26cb499f4e89c81
3752993df8af5cffa1b8219fe175d235597b4474 bf1e34d66558
> No revisions left to test, checking graph state.
> Result found: flight 15048 (pass), for last pass
> Result found: flight 15049 (fail), for first failure
> Repro found: flight 15050 (pass), for last pass
> Repro found: flight 15051 (fail), for first failure
> Repro found: flight 15053 (pass), for last pass
> Repro found: flight 15054 (fail), for first failure
>
> *** Found and reproduced problem changeset ***
>
> Bug is in tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
> Bug introduced: ba386fd2bf17
> Bug not present: bf1e34d66558
>
> pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
> searching for changes
> no changes found
>
> changeset: 26350:ba386fd2bf17
> user: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> date: Fri Jan 11 10:07:19 2013 +0000
>
> xen: avoid calling rcu_lock_*target_domain when an XSM hook exists
>
> The rcu_lock_{,remote_}target_domain_by_id functions are wrappers
> around an IS_PRIV_FOR check for the current domain. This is now
> redundant with XSM hooks, so replace these calls with
> rcu_lock_domain_by_any_id or rcu_lock_remote_domain_by_id to remove
> the duplicate permission checks.
>
> When XSM_ENABLE is not defined or when the dummy XSM module is used,
> this patch should not change any functionality. Because the locations
> of privilege checks have sometimes moved below argument validation,
> error returns of some functions may change from EPERM to EINVAL when
> called with invalid arguments and from a domain without permission to
> perform the operation.
>
> Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> Committed-by: Keir Fraser <keir@xen.org>
>
>
>
> Revision graph left in
/home/xc_osstest/results/bisect.xen-unstable.test-amd64-i386-xl-win-vcpus1.guest-saverestore.{dot,ps,png,html}.
> ----------------------------------------
> 15054: tolerable ALL FAIL
>
> flight 15054 xen-unstable real-bisect [real]
> http://www.chiark.greenend.org.uk/~xensrcts/logs/15054/
>
> Failures :-/ but no regressions.
>
> Tests which did not succeed,
> including tests which could not be run:
> test-amd64-i386-xl-win-vcpus1 8 guest-saverestore fail baseline
untested
>
>
> jobs:
> test-amd64-i386-xl-win-vcpus1 fail
>
>
> ------------------------------------------------------------
> sg-report-flight on woking.cam.xci-test.com
> logs: /home/xc_osstest/logs
> images: /home/xc_osstest/images
>
> Logs, config files, etc. are available at
> http://www.chiark.greenend.org.uk/~xensrcts/logs
>
> Test harness code can be found at
> http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
Jan Beulich
2013-Jan-15 13:49 UTC
Re: [xen-unstable bisection] complete test-amd64-i386-xl-win-vcpus1
>>> On 15.01.13 at 10:55, Ian Campbell <Ian.Campbell@citrix.com> wrote: > Adding Daniel & Jan. > > Looking at the most recently failed flight > http://www.chiark.greenend.org.uk/~xensrcts/logs/15046/test-amd64-i386-xl-wi > n-vcpus1/info.html > we have > http://www.chiark.greenend.org.uk/~xensrcts/logs/15046/test-amd64-i386-xl-wi > n-vcpus1/8.ts-guest-saverestore.log which contains: > Loading new save file image (new xl fmt info 0x0/0x0/620) > Savefile contains xl domain config > WARNING: ignoring "kernel" directive for HVM guest. Use > "firmware_override" instead if you really want a non-default firmware > xc: error: panic: xc_dom_boot.c:410: xc_dom_gnttab_hvm_seed: failed > to remove gnttab from physmap [errno=2] > : Internal error > xc: error: error seeding grant table: Internal error > libxl: error: libxl_create.c:787:libxl__xc_domain_restore_done: > restoring domain: Resource temporarily unavailable > libxl: error: libxl_create.c:869:domcreate_rebuild_done: cannot > (re-)build domain: -3 > libxl: error: libxl.c:1377:libxl__destroy_domid: non-existant domain > 5 > libxl: error: libxl.c:1341:domain_destroy_callback: unable to > destroy guest with domid 5 > libxl: error: libxl_create.c:1175:domcreate_destruction_cb: unable > to destroy domain 5 following failed creation > Parsing config from /etc/xen/win.guest.osstest.cfg > > Which is the same as the bisection result here > http://www.chiark.greenend.org.uk/~xensrcts/logs/15054/test-amd64-i386-xl-wi > n-vcpus1/8.ts-guest-saverestore.log > > I''ve eye balled 26350:ba386fd2bf17, especially the bits about the > phsymap hypercalls and I can''t see anything obvious.Case XENMEM_remove_from_physmap in do_memory_op() no longer initializes "rc". I''m surprised there''s no compiler warning because of that (which would have failed the build). I''ll send a patch in a minute. Jan
Ian Campbell
2013-Jan-15 13:55 UTC
Re: [xen-unstable bisection] complete test-amd64-i386-xl-win-vcpus1
On Tue, 2013-01-15 at 13:49 +0000, Jan Beulich wrote:> Case XENMEM_remove_from_physmap in do_memory_op() no > longer initializes "rc".Well spotted. It''s the same in the compat case from the looks of things.> I''m surprised there''s no compiler warning > because of that (which would have failed the build).It''s quite a large function with a switch in it, perhaps there are too many paths to follow, especially in the compat case where the whole thing has a while loop round it too.> I''ll send a patch in a minute.Thanks! Ian.
Jan Beulich
2013-Jan-15 14:04 UTC
Re: [xen-unstable bisection] complete test-amd64-i386-xl-win-vcpus1
>>> On 15.01.13 at 14:55, Ian Campbell <Ian.Campbell@citrix.com> wrote: > On Tue, 2013-01-15 at 13:49 +0000, Jan Beulich wrote: >> Case XENMEM_remove_from_physmap in do_memory_op() no >> longer initializes "rc". > > Well spotted. It''s the same in the compat case from the looks of things.You mean in xen/common/compat/memory.c? If so - no, there the return value from the forwarded call to do_memory_op() get used. Jan
Ian Campbell
2013-Jan-15 14:30 UTC
Re: [xen-unstable bisection] complete test-amd64-i386-xl-win-vcpus1
On Tue, 2013-01-15 at 14:04 +0000, Jan Beulich wrote:> >>> On 15.01.13 at 14:55, Ian Campbell <Ian.Campbell@citrix.com> wrote: > > On Tue, 2013-01-15 at 13:49 +0000, Jan Beulich wrote: > >> Case XENMEM_remove_from_physmap in do_memory_op() no > >> longer initializes "rc". > > > > Well spotted. It''s the same in the compat case from the looks of things. > > You mean in xen/common/compat/memory.c? If so - no, there > the return value from the forwarded call to do_memory_op() > get used.I was confused and thought the block which translates the argument on entry included the actual functionality, which it clearly doesn''t. Sorry for the noise. Ian.