Hi,
The local variable block used through the Xen source using the wrong
variable to set the C style so it does not work.
The correct variable to use is c-file-style, as documented in
CODING_STYLE and
http://www.gnu.org/software/emacs/manual/html_node/ccmode/File-Styles.html
The following script run from the top level of a clean Xen source tree
will fix the incorrect variables (and commit the result).
The diffstat is large (see below) so I''m not including the patch.
David
---8<-----
#! /bin/sh
find . -name "*.[ch]" -print0 | xargs -0 sed -i \
"s/\\* c-set-style:/\\* c-file-style:/g"
git commit -a --author "David Vrabel <david.vrabel@citrix.com>"
-m \
"Fix emacs local variable block to use correct C style variable.
The emacs variable to set the C style from a local variable block is
c-file-style, not c-set-style.
Signed-off-by: David Vrabel <david.vrabel@citrix.com"
---8<-----
extras/mini-os/events.c | 2 +-
extras/mini-os/include/wait.h | 2 +-
extras/mini-os/include/waittypes.h | 2 +-
extras/mini-os/lib/xmalloc.c | 2 +-
extras/mini-os/sched.c | 2 +-
tools/firmware/hvmloader/32bitbios_support.c | 2 +-
tools/firmware/hvmloader/acpi/acpi2_0.h | 2 +-
tools/firmware/hvmloader/acpi/build.c | 2 +-
tools/firmware/hvmloader/acpi/mk_dsdt.c | 2 +-
tools/firmware/hvmloader/acpi/static_tables.c | 2 +-
tools/firmware/hvmloader/apic_regs.h | 2 +-
tools/firmware/hvmloader/cacheattr.c | 2 +-
tools/firmware/hvmloader/config-seabios.h | 2 +-
tools/firmware/hvmloader/config.h | 2 +-
tools/firmware/hvmloader/e820.c | 2 +-
tools/firmware/hvmloader/e820.h | 2 +-
tools/firmware/hvmloader/hvmloader.c | 2 +-
tools/firmware/hvmloader/hypercall.h | 2 +-
tools/firmware/hvmloader/mp_tables.c | 2 +-
tools/firmware/hvmloader/option_rom.h | 2 +-
tools/firmware/hvmloader/ovmf.c | 2 +-
tools/firmware/hvmloader/pci.c | 2 +-
tools/firmware/hvmloader/pci_regs.h | 2 +-
tools/firmware/hvmloader/pir.c | 2 +-
tools/firmware/hvmloader/pir_types.h | 2 +-
tools/firmware/hvmloader/rombios.c | 2 +-
tools/firmware/hvmloader/seabios.c | 2 +-
tools/firmware/hvmloader/smbios.c | 2 +-
tools/firmware/hvmloader/smbios_types.h | 2 +-
tools/firmware/hvmloader/smp.c | 2 +-
tools/firmware/hvmloader/tests.c | 2 +-
tools/firmware/hvmloader/util.c | 2 +-
tools/firmware/hvmloader/util.h | 2 +-
tools/firmware/hvmloader/xenbus.c | 2 +-
tools/libxc/xc_compression.c | 2 +-
tools/libxc/xc_core.c | 2 +-
tools/libxc/xc_core.h | 2 +-
tools/libxc/xc_core_arm.c | 2 +-
tools/libxc/xc_core_arm.h | 2 +-
tools/libxc/xc_core_x86.c | 2 +-
tools/libxc/xc_core_x86.h | 2 +-
tools/libxc/xc_dom.h | 2 +-
tools/libxc/xc_dom_arm.c | 2 +-
tools/libxc/xc_dom_armzimageloader.c | 2 +-
tools/libxc/xc_dom_binloader.c | 2 +-
tools/libxc/xc_dom_boot.c | 2 +-
tools/libxc/xc_dom_bzimageloader.c | 2 +-
tools/libxc/xc_dom_compat_linux.c | 2 +-
tools/libxc/xc_dom_core.c | 2 +-
tools/libxc/xc_dom_elfloader.c | 2 +-
tools/libxc/xc_dom_x86.c | 2 +-
tools/libxc/xc_domain.c | 2 +-
tools/libxc/xc_domain_restore.c | 2 +-
tools/libxc/xc_domain_save.c | 2 +-
tools/libxc/xc_evtchn.c | 2 +-
tools/libxc/xc_flask.c | 2 +-
tools/libxc/xc_foreign_memory.c | 2 +-
tools/libxc/xc_gnttab.c | 2 +-
tools/libxc/xc_hcall_buf.c | 2 +-
tools/libxc/xc_hvm_build_arm.c | 2 +-
tools/libxc/xc_hvm_build_x86.c | 2 +-
tools/libxc/xc_linux.c | 2 +-
tools/libxc/xc_linux_osdep.c | 2 +-
tools/libxc/xc_mem_access.c | 2 +-
tools/libxc/xc_mem_paging.c | 2 +-
tools/libxc/xc_minios.c | 2 +-
tools/libxc/xc_misc.c | 2 +-
tools/libxc/xc_netbsd.c | 2 +-
tools/libxc/xc_nomigrate.c | 2 +-
tools/libxc/xc_pagetab.c | 2 +-
tools/libxc/xc_private.c | 2 +-
tools/libxc/xc_solaris.c | 2 +-
tools/libxc/xc_tmem.c | 2 +-
tools/libxc/xenctrl_osdep_ENOSYS.c | 2 +-
tools/libxc/xenctrlosdep.h | 2 +-
tools/libxc/xg_private.c | 2 +-
tools/tests/xen-access/xen-access.c | 2 +-
tools/xenpaging/file_ops.c | 2 +-
tools/xenpaging/file_ops.h | 2 +-
tools/xenpaging/pagein.c | 2 +-
tools/xenpaging/policy.h | 2 +-
tools/xenpaging/policy_default.c | 2 +-
tools/xenpaging/xenpaging.c | 2 +-
tools/xenpaging/xenpaging.h | 2 +-
tools/xentrace/xenctx.c | 2 +-
tools/xentrace/xentrace.c | 2 +-
xen/arch/arm/arm32/asm-offsets.c | 2 +-
xen/arch/arm/domain.c | 2 +-
xen/arch/arm/domain_build.c | 2 +-
xen/arch/arm/domctl.c | 2 +-
xen/arch/arm/gic.c | 2 +-
xen/arch/arm/guestcopy.c | 2 +-
xen/arch/arm/io.c | 2 +-
xen/arch/arm/io.h | 2 +-
xen/arch/arm/irq.c | 2 +-
xen/arch/arm/kernel.c | 2 +-
xen/arch/arm/mm.c | 2 +-
xen/arch/arm/p2m.c | 2 +-
xen/arch/arm/physdev.c | 2 +-
xen/arch/arm/setup.c | 2 +-
xen/arch/arm/shutdown.c | 2 +-
xen/arch/arm/smp.c | 2 +-
xen/arch/arm/smpboot.c | 2 +-
xen/arch/arm/sysctl.c | 2 +-
xen/arch/arm/time.c | 2 +-
xen/arch/arm/traps.c | 2 +-
xen/arch/arm/vgic.c | 2 +-
xen/arch/arm/vpl011.c | 2 +-
xen/arch/arm/vpl011.h | 2 +-
xen/arch/arm/vtimer.c | 2 +-
xen/arch/arm/vtimer.h | 2 +-
xen/arch/x86/boot/mkelf32.c | 2 +-
xen/arch/x86/bzimage.c | 2 +-
xen/arch/x86/crash.c | 2 +-
xen/arch/x86/domain.c | 2 +-
xen/arch/x86/domain_build.c | 2 +-
xen/arch/x86/domctl.c | 2 +-
xen/arch/x86/gdbstub.c | 2 +-
xen/arch/x86/hvm/asid.c | 2 +-
xen/arch/x86/hvm/hvm.c | 2 +-
xen/arch/x86/hvm/intercept.c | 2 +-
xen/arch/x86/hvm/io.c | 2 +-
xen/arch/x86/hvm/save.c | 2 +-
xen/arch/x86/hvm/svm/asid.c | 2 +-
xen/arch/x86/hvm/svm/emulate.c | 2 +-
xen/arch/x86/hvm/svm/intr.c | 2 +-
xen/arch/x86/hvm/svm/svm.c | 2 +-
xen/arch/x86/hvm/svm/svmdebug.c | 2 +-
xen/arch/x86/hvm/svm/vmcb.c | 2 +-
xen/arch/x86/hvm/vmx/intr.c | 2 +-
xen/arch/x86/hvm/vmx/vmcs.c | 2 +-
xen/arch/x86/hvm/vmx/vmx.c | 2 +-
xen/arch/x86/i387.c | 2 +-
xen/arch/x86/ioport_emulate.c | 2 +-
xen/arch/x86/machine_kexec.c | 2 +-
xen/arch/x86/mm.c | 2 +-
xen/arch/x86/mm/hap/guest_walk.c | 2 +-
xen/arch/x86/mm/hap/hap.c | 2 +-
xen/arch/x86/mm/hap/nested_hap.c | 2 +-
xen/arch/x86/mm/mem_access.c | 2 +-
xen/arch/x86/mm/mem_event.c | 2 +-
xen/arch/x86/mm/mem_paging.c | 2 +-
xen/arch/x86/mm/p2m-ept.c | 2 +-
xen/arch/x86/mm/p2m.c | 2 +-
xen/arch/x86/mm/paging.c | 2 +-
xen/arch/x86/mm/shadow/common.c | 2 +-
xen/arch/x86/mm/shadow/multi.c | 2 +-
xen/arch/x86/mm/shadow/private.h | 2 +-
xen/arch/x86/mm/shadow/types.h | 2 +-
xen/arch/x86/oprofile/xenoprof.c | 2 +-
xen/arch/x86/physdev.c | 2 +-
xen/arch/x86/platform_hypercall.c | 2 +-
xen/arch/x86/setup.c | 2 +-
xen/arch/x86/shutdown.c | 2 +-
xen/arch/x86/string.c | 2 +-
xen/arch/x86/sysctl.c | 2 +-
xen/arch/x86/tboot.c | 2 +-
xen/arch/x86/time.c | 2 +-
xen/arch/x86/traps.c | 2 +-
xen/arch/x86/usercopy.c | 2 +-
xen/arch/x86/x86_64/compat.c | 2 +-
xen/arch/x86/x86_64/compat/mm.c | 2 +-
xen/arch/x86/x86_64/compat/traps.c | 2 +-
xen/arch/x86/x86_64/domain.c | 2 +-
xen/arch/x86/x86_64/gdbstub.c | 2 +-
xen/arch/x86/x86_64/machine_kexec.c | 2 +-
xen/arch/x86/x86_64/mm.c | 2 +-
xen/arch/x86/x86_64/physdev.c | 2 +-
xen/arch/x86/x86_64/platform_hypercall.c | 2 +-
xen/arch/x86/x86_64/traps.c | 2 +-
xen/arch/x86/xstate.c | 2 +-
xen/common/compat/domain.c | 2 +-
xen/common/compat/grant_table.c | 2 +-
xen/common/compat/kernel.c | 2 +-
xen/common/compat/multicall.c | 2 +-
xen/common/compat/schedule.c | 2 +-
xen/common/compat/tmem_xen.c | 2 +-
xen/common/compat/xenoprof.c | 2 +-
xen/common/compat/xlat.c | 2 +-
xen/common/cpupool.c | 2 +-
xen/common/device_tree.c | 2 +-
xen/common/domain.c | 2 +-
xen/common/domctl.c | 2 +-
xen/common/event_channel.c | 2 +-
xen/common/gdbstub.c | 2 +-
xen/common/grant_table.c | 2 +-
xen/common/hvm/save.c | 2 +-
xen/common/kernel.c | 2 +-
xen/common/kexec.c | 2 +-
xen/common/keyhandler.c | 2 +-
xen/common/lib.c | 2 +-
xen/common/libelf/libelf-dominfo.c | 2 +-
xen/common/libelf/libelf-loader.c | 2 +-
xen/common/libelf/libelf-private.h | 2 +-
xen/common/libelf/libelf-relocate.c | 2 +-
xen/common/libelf/libelf-tools.c | 2 +-
xen/common/memory.c | 2 +-
xen/common/multicall.c | 2 +-
xen/common/page_alloc.c | 2 +-
xen/common/perfc.c | 2 +-
xen/common/sched_sedf.c | 2 +-
xen/common/schedule.c | 2 +-
xen/common/softirq.c | 2 +-
xen/common/string.c | 2 +-
xen/common/sysctl.c | 2 +-
xen/common/tasklet.c | 2 +-
xen/common/timer.c | 2 +-
xen/common/tmem.c | 2 +-
xen/common/trace.c | 2 +-
xen/common/vsprintf.c | 2 +-
xen/common/xencomm.c | 2 +-
xen/common/xenoprof.c | 2 +-
xen/drivers/char/console.c | 2 +-
xen/drivers/char/ns16550.c | 2 +-
xen/drivers/char/pl011.c | 2 +-
xen/drivers/char/serial.c | 2 +-
xen/drivers/passthrough/iommu.c | 2 +-
xen/drivers/passthrough/pci.c | 2 +-
xen/drivers/passthrough/vtd/iommu.c | 2 +-
xen/drivers/passthrough/vtd/utils.c | 2 +-
xen/include/asm-arm/asm_defns.h | 2 +-
xen/include/asm-arm/atomic.h | 2 +-
xen/include/asm-arm/bitops.h | 2 +-
xen/include/asm-arm/bug.h | 2 +-
xen/include/asm-arm/byteorder.h | 2 +-
xen/include/asm-arm/cache.h | 2 +-
xen/include/asm-arm/config.h | 2 +-
xen/include/asm-arm/cpregs.h | 2 +-
xen/include/asm-arm/current.h | 2 +-
xen/include/asm-arm/debugger.h | 2 +-
xen/include/asm-arm/delay.h | 2 +-
xen/include/asm-arm/desc.h | 2 +-
xen/include/asm-arm/div64.h | 2 +-
xen/include/asm-arm/domain.h | 2 +-
xen/include/asm-arm/elf.h | 2 +-
xen/include/asm-arm/event.h | 2 +-
xen/include/asm-arm/flushtlb.h | 2 +-
xen/include/asm-arm/gic.h | 2 +-
xen/include/asm-arm/grant_table.h | 2 +-
xen/include/asm-arm/guest_access.h | 2 +-
xen/include/asm-arm/hardirq.h | 2 +-
xen/include/asm-arm/hypercall.h | 2 +-
xen/include/asm-arm/init.h | 2 +-
xen/include/asm-arm/io.h | 2 +-
xen/include/asm-arm/iocap.h | 2 +-
xen/include/asm-arm/irq.h | 2 +-
xen/include/asm-arm/mm.h | 2 +-
xen/include/asm-arm/multicall.h | 2 +-
xen/include/asm-arm/nmi.h | 2 +-
xen/include/asm-arm/numa.h | 2 +-
xen/include/asm-arm/p2m.h | 2 +-
xen/include/asm-arm/page.h | 2 +-
xen/include/asm-arm/paging.h | 2 +-
xen/include/asm-arm/percpu.h | 2 +-
xen/include/asm-arm/platform_vexpress.h | 2 +-
xen/include/asm-arm/processor-ca15.h | 2 +-
xen/include/asm-arm/processor.h | 2 +-
xen/include/asm-arm/regs.h | 2 +-
xen/include/asm-arm/setup.h | 2 +-
xen/include/asm-arm/smp.h | 2 +-
xen/include/asm-arm/softirq.h | 2 +-
xen/include/asm-arm/spinlock.h | 2 +-
xen/include/asm-arm/string.h | 2 +-
xen/include/asm-arm/system.h | 2 +-
xen/include/asm-arm/time.h | 2 +-
xen/include/asm-arm/trace.h | 2 +-
xen/include/asm-arm/types.h | 2 +-
xen/include/asm-arm/vfp.h | 2 +-
xen/include/asm-arm/xenoprof.h | 2 +-
xen/include/asm-x86/domain.h | 2 +-
xen/include/asm-x86/elf.h | 2 +-
xen/include/asm-x86/hap.h | 2 +-
xen/include/asm-x86/hvm/asid.h | 2 +-
xen/include/asm-x86/hvm/svm/asid.h | 2 +-
xen/include/asm-x86/hvm/svm/emulate.h | 2 +-
xen/include/asm-x86/hvm/svm/nestedsvm.h | 2 +-
xen/include/asm-x86/hvm/svm/vmcb.h | 2 +-
xen/include/asm-x86/hvm/trace.h | 2 +-
xen/include/asm-x86/hvm/vmx/vmcs.h | 2 +-
xen/include/asm-x86/ldt.h | 2 +-
xen/include/asm-x86/mem_access.h | 2 +-
xen/include/asm-x86/mem_event.h | 2 +-
xen/include/asm-x86/mem_paging.h | 2 +-
xen/include/asm-x86/p2m.h | 2 +-
xen/include/asm-x86/page.h | 2 +-
xen/include/asm-x86/paging.h | 2 +-
xen/include/asm-x86/processor.h | 2 +-
xen/include/asm-x86/shadow.h | 2 +-
xen/include/asm-x86/tboot.h | 2 +-
xen/include/asm-x86/x86_64/elf.h | 2 +-
xen/include/asm-x86/x86_64/page.h | 2 +-
xen/include/asm-x86/xenoprof.h | 2 +-
xen/include/public/arch-arm.h | 2 +-
xen/include/public/arch-arm/hvm/save.h | 2 +-
xen/include/public/arch-x86/xen-x86_32.h | 2 +-
xen/include/public/arch-x86/xen-x86_64.h | 2 +-
xen/include/public/arch-x86/xen.h | 2 +-
xen/include/public/callback.h | 2 +-
xen/include/public/dom0_ops.h | 2 +-
xen/include/public/domctl.h | 2 +-
xen/include/public/elfnote.h | 2 +-
xen/include/public/event_channel.h | 2 +-
xen/include/public/features.h | 2 +-
xen/include/public/grant_table.h | 2 +-
xen/include/public/hvm/ioreq.h | 2 +-
xen/include/public/io/blkif.h | 2 +-
xen/include/public/io/console.h | 2 +-
xen/include/public/io/fbif.h | 2 +-
xen/include/public/io/kbdif.h | 2 +-
xen/include/public/io/netif.h | 2 +-
xen/include/public/io/pciif.h | 2 +-
xen/include/public/io/ring.h | 2 +-
xen/include/public/io/tpmif.h | 2 +-
xen/include/public/io/vscsiif.h | 2 +-
xen/include/public/io/xenbus.h | 2 +-
xen/include/public/io/xs_wire.h | 2 +-
xen/include/public/kexec.h | 2 +-
xen/include/public/mem_event.h | 2 +-
xen/include/public/memory.h | 2 +-
xen/include/public/nmi.h | 2 +-
xen/include/public/physdev.h | 2 +-
xen/include/public/platform.h | 2 +-
xen/include/public/sched.h | 2 +-
xen/include/public/sysctl.h | 2 +-
xen/include/public/tmem.h | 2 +-
xen/include/public/trace.h | 2 +-
xen/include/public/vcpu.h | 2 +-
xen/include/public/version.h | 2 +-
xen/include/public/xen.h | 2 +-
xen/include/public/xenoprof.h | 2 +-
xen/include/xen/elfcore.h | 2 +-
xen/include/xen/gdbstub.h | 2 +-
xen/include/xen/kexec.h | 2 +-
xen/include/xen/sched.h | 2 +-
xen/include/xen/serial.h | 2 +-
xen/include/xen/time.h | 2 +-
xen/include/xen/timer.h | 2 +-
337 files changed, 337 insertions(+), 337 deletions(-)
Ian Campbell
2013-Jan-18 12:07 UTC
Re: [PATCH sort of] Fix emacs local variable for c-style
On Fri, 2013-01-11 at 12:05 +0000, David Vrabel wrote:> Hi, > > The local variable block used through the Xen source using the wrong > variable to set the C style so it does not work.Seems we''ve managed to get this wrong in the ARM port despite my being aware of this and thinking I was using the corrected version. Doh! [...]> ---8<----- > #! /bin/sh > > find . -name "*.[ch]" -print0 | xargs -0 sed -i \ > "s/\\* c-set-style:/\\* c-file-style:/g" > git commit -a --author "David Vrabel <david.vrabel@citrix.com>" -m \ > "Fix emacs local variable block to use correct C style variable. > > The emacs variable to set the C style from a local variable block is > c-file-style, not c-set-style. > > Signed-off-by: David Vrabel <david.vrabel@citrix.com"Acked-by: Ian Campbell <ian.campbell@citrix.com> Ian.
David Vrabel
2013-Jan-22 14:00 UTC
Re: [PATCH sort of] Fix emacs local variable for c-style
Keir, On 11/01/13 12:05, David Vrabel wrote:> Hi, > > The local variable block used through the Xen source using the wrong > variable to set the C style so it does not work. > > The correct variable to use is c-file-style, as documented in > CODING_STYLE and > > http://www.gnu.org/software/emacs/manual/html_node/ccmode/File-Styles.html > > The following script run from the top level of a clean Xen source tree > will fix the incorrect variables (and commit the result).What do you want to do with this? Are you happy to run the script and commit the result? Or would you prefer a patch? David> > The diffstat is large (see below) so I''m not including the patch. > > David > > ---8<----- > #! /bin/sh > > find . -name "*.[ch]" -print0 | xargs -0 sed -i \ > "s/\\* c-set-style:/\\* c-file-style:/g" > git commit -a --author "David Vrabel <david.vrabel@citrix.com>" -m \ > "Fix emacs local variable block to use correct C style variable. > > The emacs variable to set the C style from a local variable block is > c-file-style, not c-set-style. > > Signed-off-by: David Vrabel <david.vrabel@citrix.com" > ---8<-----[...]> 337 files changed, 337 insertions(+), 337 deletions(-)