Jan Beulich
2013-Jan-07 12:00 UTC
Ping: [PATCH] x86: compat_show_guest_stack() should not truncate MFN
>>> On 20.12.12 at 17:54, Jan Beulich wrote: > Re-using "addr" here was a mistake, as it is a 32-bit quantity. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> > > --- a/xen/arch/x86/x86_64/compat/traps.c > +++ b/xen/arch/x86/x86_64/compat/traps.c > @@ -20,11 +20,12 @@ void compat_show_guest_stack(struct vcpu > if ( v != current ) > { > struct vcpu *vcpu; > + unsigned long mfn; > > ASSERT(guest_kernel_mode(v, regs)); > - addr = read_cr3() >> PAGE_SHIFT; > + mfn = read_cr3() >> PAGE_SHIFT; > for_each_vcpu( v->domain, vcpu ) > - if ( pagetable_get_pfn(vcpu->arch.guest_table) == addr ) > + if ( pagetable_get_pfn(vcpu->arch.guest_table) == mfn ) > break; > if ( !vcpu ) > { > > >
Ian Campbell
2013-Jan-07 12:07 UTC
Re: Ping: [PATCH] x86: compat_show_guest_stack() should not truncate MFN
On Mon, 2013-01-07 at 12:00 +0000, Jan Beulich wrote:> >>> On 20.12.12 at 17:54, Jan Beulich wrote: > > Re-using "addr" here was a mistake, as it is a 32-bit quantity. > > > > Signed-off-by: Jan Beulich <jbeulich@suse.com>Looks right to me Acked-by: Ian Campbell <ian.campbell@citrix.com>> > > > --- a/xen/arch/x86/x86_64/compat/traps.c > > +++ b/xen/arch/x86/x86_64/compat/traps.c > > @@ -20,11 +20,12 @@ void compat_show_guest_stack(struct vcpu > > if ( v != current ) > > { > > struct vcpu *vcpu; > > + unsigned long mfn; > > > > ASSERT(guest_kernel_mode(v, regs)); > > - addr = read_cr3() >> PAGE_SHIFT; > > + mfn = read_cr3() >> PAGE_SHIFT; > > for_each_vcpu( v->domain, vcpu ) > > - if ( pagetable_get_pfn(vcpu->arch.guest_table) == addr ) > > + if ( pagetable_get_pfn(vcpu->arch.guest_table) == mfn ) > > break; > > if ( !vcpu ) > > { > > > > > > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
Keir Fraser
2013-Jan-07 12:22 UTC
Re: Ping: [PATCH] x86: compat_show_guest_stack() should not truncate MFN
On 07/01/2013 12:07, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:> On Mon, 2013-01-07 at 12:00 +0000, Jan Beulich wrote: >>>>> On 20.12.12 at 17:54, Jan Beulich wrote: >>> Re-using "addr" here was a mistake, as it is a 32-bit quantity. >>> >>> Signed-off-by: Jan Beulich <jbeulich@suse.com> > > Looks right to me > > Acked-by: Ian Campbell <ian.campbell@citrix.com>Yes, I must have missed this patch first time round. Acked-by: Keir Fraser <keir@xen.org>>>> >>> --- a/xen/arch/x86/x86_64/compat/traps.c >>> +++ b/xen/arch/x86/x86_64/compat/traps.c >>> @@ -20,11 +20,12 @@ void compat_show_guest_stack(struct vcpu >>> if ( v != current ) >>> { >>> struct vcpu *vcpu; >>> + unsigned long mfn; >>> >>> ASSERT(guest_kernel_mode(v, regs)); >>> - addr = read_cr3() >> PAGE_SHIFT; >>> + mfn = read_cr3() >> PAGE_SHIFT; >>> for_each_vcpu( v->domain, vcpu ) >>> - if ( pagetable_get_pfn(vcpu->arch.guest_table) == addr ) >>> + if ( pagetable_get_pfn(vcpu->arch.guest_table) == mfn ) >>> break; >>> if ( !vcpu ) >>> { >>> >>> >>> >> >> >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> http://lists.xen.org/xen-devel > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel