Matthew Fioravante
2013-Jan-02 22:01 UTC
[PATCH] Fix gmp stubdom build when DESTDIR is used
The default make targets in the top level makefile set DESTDIR which gets applied when the stubdom makefile tries to do a make install within gmp to install libgmp.a to the cross root. Ian, do you want to apply this to your tree and commit the whole thing or would you prefer I roll out a fresh new patch set with all updates applied? Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu> --- stubdom/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stubdom/Makefile b/stubdom/Makefile index 7519683..3006ad6 100644 --- a/stubdom/Makefile +++ b/stubdom/Makefile @@ -173,7 +173,7 @@ cross-gmp: $(GMP_STAMPFILE) $(GMP_STAMPFILE): gmp-$(XEN_TARGET_ARCH) ( cd $< && \ $(MAKE) && \ - $(MAKE) install ) + $(MAKE) DESTDIR= install ) ############# # cross-polarssl -- 1.7.10.4
On Wed, 2013-01-02 at 22:01 +0000, Matthew Fioravante wrote:> The default make targets in the top level makefile set DESTDIR > which gets applied when the stubdom makefile > tries to do a make install within gmp to install libgmp.a > to the cross root. > > Ian, do you want to apply this to your tree and commit the whole thing > or would you prefer I roll out a fresh new patch set with all updates > applied?As I said in <1355830264.14620.196.camel@zakaz.uk.xensource.com> I think it would be best to have a fresh set to avoid confusion etc.> Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>Although a bit counter intuitive this is what is done for all the stubdom libraries since they need to be installed into the cross dir and not actually installed, so: Acked-by: Ian Campbell <ian.campbell@citrix.com> Ian.> --- > stubdom/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/stubdom/Makefile b/stubdom/Makefile > index 7519683..3006ad6 100644 > --- a/stubdom/Makefile > +++ b/stubdom/Makefile > @@ -173,7 +173,7 @@ cross-gmp: $(GMP_STAMPFILE) > $(GMP_STAMPFILE): gmp-$(XEN_TARGET_ARCH) > ( cd $< && \ > $(MAKE) && \ > - $(MAKE) install ) > + $(MAKE) DESTDIR= install ) > > ############# > # cross-polarssl