Stefano Stabellini
2012-Dec-07 17:45 UTC
[PATCH v4 2/2] xen/arm: use strcmp in device_tree_type_matches
We want to match the exact string rather than the first subset.
Changes in v4:
- get rid of len.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
xen/common/device_tree.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index 7a072cb..8b4ef2f 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -44,14 +44,13 @@ bool_t device_tree_node_matches(const void *fdt, int node,
const char *match)
bool_t device_tree_type_matches(const void *fdt, int node, const char *match)
{
- int len;
const void *prop;
- prop = fdt_getprop(fdt, node, "device_type", &len);
+ prop = fdt_getprop(fdt, node, "device_type", NULL);
if ( prop == NULL )
return 0;
- return !strncmp(prop, match, len);
+ return !strcmp(prop, match);
}
bool_t device_tree_node_compatible(const void *fdt, int node, const char
*match)
--
1.7.2.5
Ian Campbell
2012-Dec-13 11:47 UTC
Re: [PATCH v4 2/2] xen/arm: use strcmp in device_tree_type_matches
On Fri, 2012-12-07 at 17:45 +0000, Stefano Stabellini wrote:> We want to match the exact string rather than the first subset. > > Changes in v4: > - get rid of len. > > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>Acked + applied , thanks.