Jan Beulich
2012-Dec-06 12:56 UTC
[PATCH] x86/HVM: add missing assert to stdvga''s mmio_move()
... to match the IOREQ_READ path.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/hvm/stdvga.c
+++ b/xen/arch/x86/hvm/stdvga.c
@@ -519,6 +519,7 @@ static int mmio_move(struct hvm_hw_stdvg
put_page(dp);
return 0;
}
+ ASSERT(!dp);
tmp = stdvga_mem_read(data, p->size);
}
stdvga_mem_write(addr, tmp, p->size);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Keir Fraser
2012-Dec-06 15:55 UTC
Re: [PATCH] x86/HVM: add missing assert to stdvga''s mmio_move()
On 06/12/2012 12:56, "Jan Beulich" <JBeulich@suse.com> wrote:> ... to match the IOREQ_READ path. > > Signed-off-by: Jan Beulich <jbeulich@suse.com>Acked-by: Keir Fraser <keir@xen.org>> --- a/xen/arch/x86/hvm/stdvga.c > +++ b/xen/arch/x86/hvm/stdvga.c > @@ -519,6 +519,7 @@ static int mmio_move(struct hvm_hw_stdvg > put_page(dp); > return 0; > } > + ASSERT(!dp); > tmp = stdvga_mem_read(data, p->size); > } > stdvga_mem_write(addr, tmp, p->size); > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel