Xen devel - Nov 2012 - [PATCH v2 2/3] libxl: fix wrong comment

The comment in function libxl__try_phy_backend is wrong, 1 is returned
if the backend should be handled as "phy", while 0 is returned if not.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 tools/libxl/libxl_internal.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index cba3616..0b38e3e 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -1041,7 +1041,7 @@ static inline void libxl__domaindeathcheck_stop(libxl__gc
*gc,
  * type of file using the PHY backend
  * st_mode: mode_t of the file, as returned by stat function
  *
- * Returns 0 on success, and < 0 on error.
+ * Returns 1 on success, and 0 if not suitable for phy backend.
  */
 _hidden int libxl__try_phy_backend(mode_t st_mode);
 
-- 
1.7.7.5 (Apple Git-26)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

On Thu, 2012-11-29 at 17:31 +0000, Roger Pau Monne
wrote:
> The comment in function libxl__try_phy_backend is wrong, 1 is returned
> if the backend should be handled as "phy", while 0 is returned if
not.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked + applied, thanks.
> ---
>  tools/libxl/libxl_internal.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index cba3616..0b38e3e 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -1041,7 +1041,7 @@ static inline void
libxl__domaindeathcheck_stop(libxl__gc *gc,
>   * type of file using the PHY backend
>   * st_mode: mode_t of the file, as returned by stat function
>   *
> - * Returns 0 on success, and < 0 on error.
> + * Returns 1 on success, and 0 if not suitable for phy backend.
>   */
>  _hidden int libxl__try_phy_backend(mode_t st_mode);
>  


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel