Xen devel - Nov 2012 - [PATCH] AMD IOMMU: fix type of "bdf" parameter of update_intremap_entry_from_msi_msg()

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/amd/iommu_intr.c
+++ b/xen/drivers/passthrough/amd/iommu_intr.c
@@ -263,7 +263,7 @@ void amd_iommu_ioapic_update_ire(
 }
 
 static void update_intremap_entry_from_msi_msg(
-    struct amd_iommu *iommu, u8 bdf,
+    struct amd_iommu *iommu, u16 bdf,
     struct msi_desc *msi_desc, struct msi_msg *msg)
 {
     unsigned long flags;

On 19/11/12 14:14, Jan Beulich wrote:
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Looks good to me.
>
> --- a/xen/drivers/passthrough/amd/iommu_intr.c
> +++ b/xen/drivers/passthrough/amd/iommu_intr.c
> @@ -263,7 +263,7 @@ void amd_iommu_ioapic_update_ire(
>  }
>  
>  static void update_intremap_entry_from_msi_msg(
> -    struct amd_iommu *iommu, u8 bdf,
> +    struct amd_iommu *iommu, u16 bdf,
>      struct msi_desc *msi_desc, struct msi_msg *msg)
>  {
>      unsigned long flags;
>
>
>
-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com

Acked-by: Wei Huang <wei.huang2@amd.com>

-Wei

-----Original Message-----
From: Jan Beulich [mailto:JBeulich@suse.com] 
Sent: Monday, November 19, 2012 8:14 AM
To: xen-devel
Cc: Huang2, Wei; Andrew Cooper; Wei Wang
Subject: [PATCH] AMD IOMMU: fix type of "bdf" parameter of
update_intremap_entry_from_msi_msg()

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/amd/iommu_intr.c
+++ b/xen/drivers/passthrough/amd/iommu_intr.c
@@ -263,7 +263,7 @@ void amd_iommu_ioapic_update_ire(  }
 
 static void update_intremap_entry_from_msi_msg(
-    struct amd_iommu *iommu, u8 bdf,
+    struct amd_iommu *iommu, u16 bdf,
     struct msi_desc *msi_desc, struct msi_msg *msg)  {
     unsigned long flags;