branch xen-unstable
xen branch xen-unstable
job test-amd64-i386-pair
test xen-boot/dst_host
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Bug introduced: 4fc87c2f31a0
Bug not present: c1c549c4fe9e
changeset: 26060:4fc87c2f31a0
user: Huang Ying <ying.huang@intel.com>
date: Tue Oct 16 17:26:36 2012 +0200
ACPI: fix APEI related table size checking
On Huang Ying''s machine:
erst_tab->header_length == sizeof(struct acpi_table_einj)
but Yinghai reported that on his machine,
erst_tab->header_length == sizeof(struct acpi_table_einj) -
sizeof(struct acpi_table_header)
To make erst table size checking code works on all systems, both
testing are treated as PASS.
Same situation applies to einj_tab->header_length, so corresponding
table size checking is changed in similar way too.
Originally-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Huang Ying <ying.huang@intel.com>
- use switch() for better readability
- add comment explaining why a formally invalid size it also being
accepted
- check erst_tab->header.length before even looking at
erst_tab->header_length
- prefer sizeof(*erst_tab) over sizeof(struct acpi_table_erst)
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
Committed-by: Jan Beulich <jbeulich@suse.com>
For bisection revision-tuple graph see:
http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.test-amd64-i386-pair.xen-boot--dst_host.html
Revision IDs in each graph node refer, respectively, to the Trees above.
----------------------------------------
Searching for failure / basis pass:
14038 fail [dst_host=leaf-beetle,src_host=potato-beetle] / 13967
[dst_host=bush-cricket,src_host=field-cricket] 13963
[dst_host=potato-beetle,src_host=leaf-beetle] 13962
[dst_host=itch-mite,src_host=gall-mite] 13960
[dst_host=lace-bug,src_host=moss-bug] 13958
[dst_host=bush-cricket,src_host=field-cricket] 13956
[dst_host=gall-mite,src_host=itch-mite] 13953
[dst_host=potato-beetle,src_host=leaf-beetle] 13952 ok.
Failure / basis pass flights: 14038 / 13952
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Latest a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 3fa2ab30bb05
Basis pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 b91f57f54f47
Generating revisions with ./adhoc-revtuple-generator
git://xenbits.xen.org/linux-pvops.git#a938a246d34912423c560f475ccf1ce0c71d9d00-a938a246d34912423c560f475ccf1ce0c71d9d00
git://xenbits.xen.org/staging/qemu-xen-unstable.git#bacc0d302445c75f18f4c826750fb5853b60e7ca-bacc0d302445c75f18f4c826750fb5853b60e7ca
git://xenbits.xen.org/staging/qemu-upstream-unstable.git#cdf4d2bb4006805f209712fbb8ed1f83127e9984-cdf4d2bb4006805f209712fbb8ed1f83127e9984
http://xenbits.xen.org/hg/staging/xen-unstable.hg#b91f57f54f47-3fa2ab30bb05
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
Loaded 270 nodes in revision graph
Searching for test results:
13958 [dst_host=bush-cricket,src_host=field-cricket]
13960 [dst_host=lace-bug,src_host=moss-bug]
13967 [dst_host=bush-cricket,src_host=field-cricket]
13962 [dst_host=itch-mite,src_host=gall-mite]
13972 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
13952 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 b91f57f54f47
13963 [dst_host=potato-beetle,src_host=leaf-beetle]
13953 [dst_host=potato-beetle,src_host=leaf-beetle]
13956 [dst_host=gall-mite,src_host=itch-mite]
13964 []
13973 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
13979 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
13995 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4b4c0c7a6031
14001 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 1f4be6ee4619
14007 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 5c402b905e00
14039 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 b91f57f54f47
14040 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 3fa2ab30bb05
14041 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 137dfbd3190e
14011 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 5c402b905e00
14042 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 177fdda0be56
14043 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 37bb894121c7
14017 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 5c402b905e00
14038 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 3fa2ab30bb05
14044 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 c1c549c4fe9e
14046 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
14047 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 c1c549c4fe9e
14048 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
14049 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 c1c549c4fe9e
14050 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
14032 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 3fa2ab30bb05
Searching for interesting versions
Result found: flight 13952 (pass), for basis pass
Result found: flight 14032 (fail), for basis failure
Repro found: flight 14039 (pass), for basis pass
Repro found: flight 14040 (fail), for basis failure
0 revisions at a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 c1c549c4fe9e
No revisions left to test, checking graph state.
Result found: flight 14044 (pass), for last pass
Result found: flight 14046 (fail), for first failure
Repro found: flight 14047 (pass), for last pass
Repro found: flight 14048 (fail), for first failure
Repro found: flight 14049 (pass), for last pass
Repro found: flight 14050 (fail), for first failure
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Bug introduced: 4fc87c2f31a0
Bug not present: c1c549c4fe9e
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
changeset: 26060:4fc87c2f31a0
user: Huang Ying <ying.huang@intel.com>
date: Tue Oct 16 17:26:36 2012 +0200
ACPI: fix APEI related table size checking
On Huang Ying''s machine:
erst_tab->header_length == sizeof(struct acpi_table_einj)
but Yinghai reported that on his machine,
erst_tab->header_length == sizeof(struct acpi_table_einj) -
sizeof(struct acpi_table_header)
To make erst table size checking code works on all systems, both
testing are treated as PASS.
Same situation applies to einj_tab->header_length, so corresponding
table size checking is changed in similar way too.
Originally-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Huang Ying <ying.huang@intel.com>
- use switch() for better readability
- add comment explaining why a formally invalid size it also being
accepted
- check erst_tab->header.length before even looking at
erst_tab->header_length
- prefer sizeof(*erst_tab) over sizeof(struct acpi_table_erst)
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
Committed-by: Jan Beulich <jbeulich@suse.com>
Revision graph left in
/home/xc_osstest/results/bisect.xen-unstable.test-amd64-i386-pair.xen-boot--dst_host.{dot,ps,png,html}.
----------------------------------------
14050: tolerable ALL FAIL
flight 14050 xen-unstable real-bisect [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/14050/
Failures :-/ but no regressions.
Tests which did not succeed,
including tests which could not be run:
test-amd64-i386-pair 8 xen-boot/dst_host fail baseline untested
test-amd64-i386-pair 7 xen-boot/src_host fail baseline untested
jobs:
test-amd64-i386-pair fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
branch xen-unstable
xen branch xen-unstable
job test-amd64-i386-pair
test xen-boot/src_host
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Bug introduced: 4fc87c2f31a0
Bug not present: c1c549c4fe9e
changeset: 26060:4fc87c2f31a0
user: Huang Ying <ying.huang@intel.com>
date: Tue Oct 16 17:26:36 2012 +0200
ACPI: fix APEI related table size checking
On Huang Ying''s machine:
erst_tab->header_length == sizeof(struct acpi_table_einj)
but Yinghai reported that on his machine,
erst_tab->header_length == sizeof(struct acpi_table_einj) -
sizeof(struct acpi_table_header)
To make erst table size checking code works on all systems, both
testing are treated as PASS.
Same situation applies to einj_tab->header_length, so corresponding
table size checking is changed in similar way too.
Originally-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Huang Ying <ying.huang@intel.com>
- use switch() for better readability
- add comment explaining why a formally invalid size it also being
accepted
- check erst_tab->header.length before even looking at
erst_tab->header_length
- prefer sizeof(*erst_tab) over sizeof(struct acpi_table_erst)
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
Committed-by: Jan Beulich <jbeulich@suse.com>
For bisection revision-tuple graph see:
http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.test-amd64-i386-pair.xen-boot--src_host.html
Revision IDs in each graph node refer, respectively, to the Trees above.
----------------------------------------
Searching for failure / basis pass:
14038 fail [dst_host=leaf-beetle,src_host=potato-beetle] / 13967
[dst_host=bush-cricket,src_host=field-cricket] 13963
[dst_host=potato-beetle,src_host=leaf-beetle] 13962
[dst_host=itch-mite,src_host=gall-mite] 13960
[dst_host=lace-bug,src_host=moss-bug] 13958
[dst_host=bush-cricket,src_host=field-cricket] 13956
[dst_host=gall-mite,src_host=itch-mite] 13953
[dst_host=potato-beetle,src_host=leaf-beetle] 13952 ok.
Failure / basis pass flights: 14038 / 13952
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Latest a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 3fa2ab30bb05
Basis pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 b91f57f54f47
Generating revisions with ./adhoc-revtuple-generator
git://xenbits.xen.org/linux-pvops.git#a938a246d34912423c560f475ccf1ce0c71d9d00-a938a246d34912423c560f475ccf1ce0c71d9d00
git://xenbits.xen.org/staging/qemu-xen-unstable.git#bacc0d302445c75f18f4c826750fb5853b60e7ca-bacc0d302445c75f18f4c826750fb5853b60e7ca
git://xenbits.xen.org/staging/qemu-upstream-unstable.git#cdf4d2bb4006805f209712fbb8ed1f83127e9984-cdf4d2bb4006805f209712fbb8ed1f83127e9984
http://xenbits.xen.org/hg/staging/xen-unstable.hg#b91f57f54f47-3fa2ab30bb05
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
Loaded 270 nodes in revision graph
Searching for test results:
13958 [dst_host=bush-cricket,src_host=field-cricket]
13960 [dst_host=lace-bug,src_host=moss-bug]
13967 [dst_host=bush-cricket,src_host=field-cricket]
13962 [dst_host=itch-mite,src_host=gall-mite]
13972 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
13952 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 b91f57f54f47
13963 [dst_host=potato-beetle,src_host=leaf-beetle]
13953 [dst_host=potato-beetle,src_host=leaf-beetle]
13956 [dst_host=gall-mite,src_host=itch-mite]
13964 []
13973 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
13979 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
13995 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4b4c0c7a6031
14001 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 1f4be6ee4619
14007 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 5c402b905e00
14039 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 b91f57f54f47
14040 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 3fa2ab30bb05
14041 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 137dfbd3190e
14011 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 5c402b905e00
14042 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 177fdda0be56
14043 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 37bb894121c7
14017 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 5c402b905e00
14038 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 3fa2ab30bb05
14044 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 c1c549c4fe9e
14046 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
14047 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 c1c549c4fe9e
14048 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
14049 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 c1c549c4fe9e
14050 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
14032 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 3fa2ab30bb05
Searching for interesting versions
Result found: flight 13952 (pass), for basis pass
Result found: flight 14032 (fail), for basis failure
Repro found: flight 14039 (pass), for basis pass
Repro found: flight 14040 (fail), for basis failure
0 revisions at a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 c1c549c4fe9e
No revisions left to test, checking graph state.
Result found: flight 14044 (pass), for last pass
Result found: flight 14046 (fail), for first failure
Repro found: flight 14047 (pass), for last pass
Repro found: flight 14048 (fail), for first failure
Repro found: flight 14049 (pass), for last pass
Repro found: flight 14050 (fail), for first failure
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Bug introduced: 4fc87c2f31a0
Bug not present: c1c549c4fe9e
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
changeset: 26060:4fc87c2f31a0
user: Huang Ying <ying.huang@intel.com>
date: Tue Oct 16 17:26:36 2012 +0200
ACPI: fix APEI related table size checking
On Huang Ying''s machine:
erst_tab->header_length == sizeof(struct acpi_table_einj)
but Yinghai reported that on his machine,
erst_tab->header_length == sizeof(struct acpi_table_einj) -
sizeof(struct acpi_table_header)
To make erst table size checking code works on all systems, both
testing are treated as PASS.
Same situation applies to einj_tab->header_length, so corresponding
table size checking is changed in similar way too.
Originally-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Huang Ying <ying.huang@intel.com>
- use switch() for better readability
- add comment explaining why a formally invalid size it also being
accepted
- check erst_tab->header.length before even looking at
erst_tab->header_length
- prefer sizeof(*erst_tab) over sizeof(struct acpi_table_erst)
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
Committed-by: Jan Beulich <jbeulich@suse.com>
Revision graph left in
/home/xc_osstest/results/bisect.xen-unstable.test-amd64-i386-pair.xen-boot--src_host.{dot,ps,png,html}.
No revision to test.