branch xen-unstable
xen branch xen-unstable
job test-amd64-amd64-pv
test xen-boot
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Bug introduced: 4fc87c2f31a0
Bug not present: c1c549c4fe9e
changeset: 26060:4fc87c2f31a0
user: Huang Ying <ying.huang@intel.com>
date: Tue Oct 16 17:26:36 2012 +0200
ACPI: fix APEI related table size checking
On Huang Ying''s machine:
erst_tab->header_length == sizeof(struct acpi_table_einj)
but Yinghai reported that on his machine,
erst_tab->header_length == sizeof(struct acpi_table_einj) -
sizeof(struct acpi_table_header)
To make erst table size checking code works on all systems, both
testing are treated as PASS.
Same situation applies to einj_tab->header_length, so corresponding
table size checking is changed in similar way too.
Originally-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Huang Ying <ying.huang@intel.com>
- use switch() for better readability
- add comment explaining why a formally invalid size it also being
accepted
- check erst_tab->header.length before even looking at
erst_tab->header_length
- prefer sizeof(*erst_tab) over sizeof(struct acpi_table_erst)
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
Committed-by: Jan Beulich <jbeulich@suse.com>
For bisection revision-tuple graph see:
http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.test-amd64-amd64-pv.xen-boot.html
Revision IDs in each graph node refer, respectively, to the Trees above.
----------------------------------------
Searching for failure / basis pass:
13979 fail [host=lake-frog] / 13967 [host=potato-beetle] 13964
[host=field-cricket] 13963 [host=fire-frog] 13962 [host=leaf-beetle] 13960 ok.
Failure / basis pass flights: 13979 / 13960
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Latest a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
Basis pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 e0e1350dfe9b
Generating revisions with ./adhoc-revtuple-generator
git://xenbits.xen.org/linux-pvops.git#a938a246d34912423c560f475ccf1ce0c71d9d00-a938a246d34912423c560f475ccf1ce0c71d9d00
git://xenbits.xen.org/staging/qemu-xen-unstable.git#bacc0d302445c75f18f4c826750fb5853b60e7ca-bacc0d302445c75f18f4c826750fb5853b60e7ca
git://xenbits.xen.org/staging/qemu-upstream-unstable.git#cdf4d2bb4006805f209712fbb8ed1f83127e9984-cdf4d2bb4006805f209712fbb8ed1f83127e9984
http://xenbits.xen.org/hg/staging/xen-unstable.hg#e0e1350dfe9b-4fc87c2f31a0
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
Loaded 239 nodes in revision graph
Searching for test results:
13958 [host=lace-bug]
13989 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 c1c549c4fe9e
13960 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 e0e1350dfe9b
13967 [host=potato-beetle]
13962 [host=leaf-beetle]
13972 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
13963 [host=fire-frog]
13985 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 e0e1350dfe9b
13956 [host=bush-cricket]
13964 [host=field-cricket]
13994 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
13986 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
13973 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
13990 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
13979 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
13987 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 177fdda0be56
13993 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 c1c549c4fe9e
13988 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 37bb894121c7
13991 pass a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 c1c549c4fe9e
13992 fail a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 4fc87c2f31a0
Searching for interesting versions
Result found: flight 13960 (pass), for basis pass
Result found: flight 13972 (fail), for basis failure
Repro found: flight 13985 (pass), for basis pass
Repro found: flight 13986 (fail), for basis failure
0 revisions at a938a246d34912423c560f475ccf1ce0c71d9d00
bacc0d302445c75f18f4c826750fb5853b60e7ca
cdf4d2bb4006805f209712fbb8ed1f83127e9984 c1c549c4fe9e
No revisions left to test, checking graph state.
Result found: flight 13989 (pass), for last pass
Result found: flight 13990 (fail), for first failure
Repro found: flight 13991 (pass), for last pass
Repro found: flight 13992 (fail), for first failure
Repro found: flight 13993 (pass), for last pass
Repro found: flight 13994 (fail), for first failure
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Bug introduced: 4fc87c2f31a0
Bug not present: c1c549c4fe9e
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
changeset: 26060:4fc87c2f31a0
user: Huang Ying <ying.huang@intel.com>
date: Tue Oct 16 17:26:36 2012 +0200
ACPI: fix APEI related table size checking
On Huang Ying''s machine:
erst_tab->header_length == sizeof(struct acpi_table_einj)
but Yinghai reported that on his machine,
erst_tab->header_length == sizeof(struct acpi_table_einj) -
sizeof(struct acpi_table_header)
To make erst table size checking code works on all systems, both
testing are treated as PASS.
Same situation applies to einj_tab->header_length, so corresponding
table size checking is changed in similar way too.
Originally-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Huang Ying <ying.huang@intel.com>
- use switch() for better readability
- add comment explaining why a formally invalid size it also being
accepted
- check erst_tab->header.length before even looking at
erst_tab->header_length
- prefer sizeof(*erst_tab) over sizeof(struct acpi_table_erst)
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
Committed-by: Jan Beulich <jbeulich@suse.com>
Revision graph left in
/home/xc_osstest/results/bisect.xen-unstable.test-amd64-amd64-pv.xen-boot.{dot,ps,png,html}.
----------------------------------------
13994: tolerable ALL FAIL
flight 13994 xen-unstable real-bisect [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/13994/
Failures :-/ but no regressions.
Tests which did not succeed,
including tests which could not be run:
test-amd64-amd64-pv 5 xen-boot fail baseline untested
jobs:
test-amd64-amd64-pv fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary