Ian Campbell
2012-Oct-17 08:39 UTC
[PATCH 04/10] xen: dbgp: Fix warning when CONFIG_PCI is not enabled.
I saw this on ARM:
linux/drivers/xen/dbgp.c:11:23: warning: unused variable
''ctrlr'' [-Wunused-variable]
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Jan Beulich <JBeulich@suse.com>
---
drivers/xen/dbgp.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/xen/dbgp.c b/drivers/xen/dbgp.c
index 42569c7..f3ccc80 100644
--- a/drivers/xen/dbgp.c
+++ b/drivers/xen/dbgp.c
@@ -8,7 +8,9 @@
static int xen_dbgp_op(struct usb_hcd *hcd, int op)
{
+#ifdef CONFIG_PCI
const struct device *ctrlr = hcd_to_bus(hcd)->controller;
+#endif
struct physdev_dbgp_op dbgp;
if (!xen_initial_domain())
--
1.7.2.5
Jan Beulich
2012-Oct-17 09:10 UTC
Re: [PATCH 04/10] xen: dbgp: Fix warning when CONFIG_PCI is not enabled.
>>> On 17.10.12 at 10:39, Ian Campbell <ian.campbell@citrix.com> wrote: > I saw this on ARM: > linux/drivers/xen/dbgp.c:11:23: warning: unused variable ''ctrlr'' > [-Wunused-variable] > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > Cc: Jan Beulich <JBeulich@suse.com>Acked-by: Jan Beulich <jbeulich@suse.com>> --- > drivers/xen/dbgp.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/xen/dbgp.c b/drivers/xen/dbgp.c > index 42569c7..f3ccc80 100644 > --- a/drivers/xen/dbgp.c > +++ b/drivers/xen/dbgp.c > @@ -8,7 +8,9 @@ > > static int xen_dbgp_op(struct usb_hcd *hcd, int op) > { > +#ifdef CONFIG_PCI > const struct device *ctrlr = hcd_to_bus(hcd)->controller; > +#endif > struct physdev_dbgp_op dbgp; > > if (!xen_initial_domain()) > -- > 1.7.2.5
Stefano Stabellini
2012-Oct-17 17:08 UTC
Re: [PATCH 04/10] xen: dbgp: Fix warning when CONFIG_PCI is not enabled.
On Wed, 17 Oct 2012, Ian Campbell wrote:> I saw this on ARM: > linux/drivers/xen/dbgp.c:11:23: warning: unused variable ''ctrlr'' [-Wunused-variable] > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > Cc: Jan Beulich <JBeulich@suse.com>Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>> drivers/xen/dbgp.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/xen/dbgp.c b/drivers/xen/dbgp.c > index 42569c7..f3ccc80 100644 > --- a/drivers/xen/dbgp.c > +++ b/drivers/xen/dbgp.c > @@ -8,7 +8,9 @@ > > static int xen_dbgp_op(struct usb_hcd *hcd, int op) > { > +#ifdef CONFIG_PCI > const struct device *ctrlr = hcd_to_bus(hcd)->controller; > +#endif > struct physdev_dbgp_op dbgp; > > if (!xen_initial_domain()) > -- > 1.7.2.5 >