Olaf Hering
2012-Oct-09 13:04 UTC
[PATCH] stubdom: fix error assignment in grub:load_module
# HG changeset patch # User Olaf Hering <olaf@aepfle.de> # Date 1349787855 -7200 # Node ID 384714804b9b2a9742cc45dffaa43b749b85513b # Parent 142e4577f5a9b95832b82f7b6d31fde1697cbe76 stubdom: fix error assignment in grub:load_module [ 1333s] mini-os.c: In function ''load_module'': [ 1333s] mini-os.c:244: warning: statement with no effect Signed-off-by: Olaf Hering <olaf@aepfle.de> diff -r 142e4577f5a9 -r 384714804b9b stubdom/grub/mini-os.c --- a/stubdom/grub/mini-os.c +++ b/stubdom/grub/mini-os.c @@ -241,7 +241,7 @@ load_module (char *module, char *arg) if ((void*) (multiboot_next_module_header+1) - module_image > PAGE_SIZE) { /* Too many modules */ - ERR_WONT_FIT; + errnum = ERR_WONT_FIT; return 0; }
Samuel Thibault
2012-Oct-09 13:46 UTC
Re: [PATCH] stubdom: fix error assignment in grub:load_module
Olaf Hering, le Tue 09 Oct 2012 15:04:29 +0200, a écrit :> # HG changeset patch > # User Olaf Hering <olaf@aepfle.de> > # Date 1349787855 -7200 > # Node ID 384714804b9b2a9742cc45dffaa43b749b85513b > # Parent 142e4577f5a9b95832b82f7b6d31fde1697cbe76 > stubdom: fix error assignment in grub:load_module > > [ 1333s] mini-os.c: In function ''load_module'': > [ 1333s] mini-os.c:244: warning: statement with no effect > > Signed-off-by: Olaf Hering <olaf@aepfle.de>Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>> diff -r 142e4577f5a9 -r 384714804b9b stubdom/grub/mini-os.c > --- a/stubdom/grub/mini-os.c > +++ b/stubdom/grub/mini-os.c > @@ -241,7 +241,7 @@ load_module (char *module, char *arg) > > if ((void*) (multiboot_next_module_header+1) - module_image > PAGE_SIZE) { > /* Too many modules */ > - ERR_WONT_FIT; > + errnum = ERR_WONT_FIT; > return 0; > } > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel >-- Samuel /* Halley */ (Halley''s comment.)
Ian Campbell
2012-Oct-11 09:21 UTC
Re: [PATCH] stubdom: fix error assignment in grub:load_module
On Tue, 2012-10-09 at 14:46 +0100, Samuel Thibault wrote:> Olaf Hering, le Tue 09 Oct 2012 15:04:29 +0200, a écrit : > > # HG changeset patch > > # User Olaf Hering <olaf@aepfle.de> > > # Date 1349787855 -7200 > > # Node ID 384714804b9b2a9742cc45dffaa43b749b85513b > > # Parent 142e4577f5a9b95832b82f7b6d31fde1697cbe76 > > stubdom: fix error assignment in grub:load_module > > > > [ 1333s] mini-os.c: In function 'load_module': > > [ 1333s] mini-os.c:244: warning: statement with no effect > > > > Signed-off-by: Olaf Hering <olaf@aepfle.de> > > Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>APplied, thanks, _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel