Hi all,
I''ve noticed I have had to apply the following patch to get tools to
compile properly under an EL6 environment:
--- xen-4.2.0.orig/tools/Makefile 2012-09-17 20:21:18.000000000 +1000
+++ xen-4.2.0/tools/Makefile 2012-09-18 18:55:09.989148544 +1000
@@ -187,6 +187,7 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-fi
source=.; \
fi; \
cd qemu-xen-dir; \
+ env -u CFLAGS \
$$source/configure --enable-xen --target-list=i386-softmmu \
--source-path=$$source \
--extra-cflags="-I$(XEN_ROOT)/tools/include \
Without this, the build fails due to incompatible CFLAGS.
--
Steven Haigh
Email: netwiz@crc.id.au
Web: http://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897
Fax: (03) 8338 0299
On Wed, Sep 19, Steven Haigh wrote:> Without this, the build fails due to incompatible CFLAGS.CFLAGS must not be in environment, otherwise make will append its own CFLAGS to that environment variable and pass it on to qemu. qemu itself is not ready for things like -std=gnu99. Olaf
On Tue, 18 Sep 2012, Olaf Hering wrote:> On Wed, Sep 19, Steven Haigh wrote: > >> Without this, the build fails due to incompatible CFLAGS. > > CFLAGS must not be in environment, otherwise make will append its own > CFLAGS to that environment variable and pass it on to qemu. qemu itself > is not ready for things like -std=gnu99.The problem is that packaging guidelines often want you to set CFLAGS to supply distribution standard compile options. On the other hand with something like qemu it means that someone has probably already solved the problem. The attached patch worked for me in testing, which I derived by comparing Fedora''s qemu with xen''s. Michael Young _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
On Tue, Sep 18, M A Young wrote:> On Tue, 18 Sep 2012, Olaf Hering wrote: > > >On Wed, Sep 19, Steven Haigh wrote: > > > >>Without this, the build fails due to incompatible CFLAGS. > > > >CFLAGS must not be in environment, otherwise make will append its own > >CFLAGS to that environment variable and pass it on to qemu. qemu itself > >is not ready for things like -std=gnu99. > > The problem is that packaging guidelines often want you to set CFLAGS to > supply distribution standard compile options. On the other hand with > something like qemu it means that someone has probably already solved the > problem. The attached patch worked for me in testing, which I derived by > comparing Fedora''s qemu with xen''s.qemu does not build with rPM_OPT_FLAGS, at least in SuSE. For Xen, see changeset: 25464:75a2bb5db228 user: Olaf Hering <olaf@aepfle.de> date: Thu Jun 07 18:51:42 2012 +0100 files: tools/Makefile tools/Rules.mk tools/firmware/Rules.mk description: tools: pass EXTRA_CFLAGS via environment Olaf
On Tue, 18 Sep 2012, Olaf Hering wrote:> qemu does not build with rPM_OPT_FLAGS, at least in SuSE. > For Xen, see changeset: 25464:75a2bb5db228 > user: Olaf Hering <olaf@aepfle.de> > date: Thu Jun 07 18:51:42 2012 +0100 > files: tools/Makefile tools/Rules.mk tools/firmware/Rules.mk > description: > tools: pass EXTRA_CFLAGS via environmentFedora 17 seems happy to build the xen qemu with that patch and the RPM_OPT_FLAGS, though I haven''t tried it on the full build system. Michael Young