From: David Vrabel <david.vrabel@citrix.com>
migrate_timers_from_cpu() has a stray local_irq_enable() that does
nothing (it''s immediately after a spin_unlock_irq()) and has no
matching local_irq_disable().
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
xen/common/timer.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/xen/common/timer.c b/xen/common/timer.c
index 0dd2476..39de52d 100644
--- a/xen/common/timer.c
+++ b/xen/common/timer.c
@@ -587,7 +587,6 @@ static void migrate_timers_from_cpu(unsigned int old_cpu)
spin_unlock(&old_ts->lock);
spin_unlock_irq(&new_ts->lock);
- local_irq_enable();
if ( notify )
cpu_raise_softirq(new_cpu, TIMER_SOFTIRQ);
--
1.7.2.5
>>> On 06.09.12 at 14:05, David Vrabel <david.vrabel@citrix.com> wrote: > From: David Vrabel <david.vrabel@citrix.com> > > migrate_timers_from_cpu() has a stray local_irq_enable() that does > nothing (it''s immediately after a spin_unlock_irq()) and has no > matching local_irq_disable(). > > Signed-off-by: David Vrabel <david.vrabel@citrix.com>Acked-by: Jan Beulich <jbeulich@suse.com>> --- a/xen/common/timer.c > +++ b/xen/common/timer.c > @@ -587,7 +587,6 @@ static void migrate_timers_from_cpu(unsigned int old_cpu) > > spin_unlock(&old_ts->lock); > spin_unlock_irq(&new_ts->lock); > - local_irq_enable(); > > if ( notify ) > cpu_raise_softirq(new_cpu, TIMER_SOFTIRQ);
On 06/09/2012 13:26, "Jan Beulich" <JBeulich@suse.com> wrote:>>>> On 06.09.12 at 14:05, David Vrabel <david.vrabel@citrix.com> wrote: >> From: David Vrabel <david.vrabel@citrix.com> >> >> migrate_timers_from_cpu() has a stray local_irq_enable() that does >> nothing (it''s immediately after a spin_unlock_irq()) and has no >> matching local_irq_disable(). >> >> Signed-off-by: David Vrabel <david.vrabel@citrix.com> > > Acked-by: Jan Beulich <jbeulich@suse.com>Acked-by: Keir Fraser <keir@xen.org> Jan, Please apply it to xen-unstable. -- Keir>> --- a/xen/common/timer.c >> +++ b/xen/common/timer.c >> @@ -587,7 +587,6 @@ static void migrate_timers_from_cpu(unsigned int old_cpu) >> >> spin_unlock(&old_ts->lock); >> spin_unlock_irq(&new_ts->lock); >> - local_irq_enable(); >> >> if ( notify ) >> cpu_raise_softirq(new_cpu, TIMER_SOFTIRQ); > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel