Keir Fraser
2012-Aug-23 13:26 UTC
Re: [XEN][RFC PATCH V2 01/17] hvm: Modify interface to support multiple ioreq server
On 23/08/2012 14:18, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:>> diff --git a/xen/include/public/hvm/ioreq.h b/xen/include/public/hvm/ioreq.h >> index 4022a1d..87aacd3 100644 >> --- a/xen/include/public/hvm/ioreq.h >> +++ b/xen/include/public/hvm/ioreq.h >> @@ -34,6 +34,7 @@ >> >> #define IOREQ_TYPE_PIO 0 /* pio */ >> #define IOREQ_TYPE_COPY 1 /* mmio ops */ >> +#define IOREQ_TYPE_PCI_CONFIG 2 /* pci config space ops */ >> #define IOREQ_TYPE_TIMEOFFSET 7 >> #define IOREQ_TYPE_INVALIDATE 8 /* mapcache */ > > I wonder why we skip 2-6 now -- perhaps they used to be something else > and we are avoiding them to avoid strange errors? In which case adding > the new on as 9 might be a good idea.They were almost certainly used for representing R-M-W ALU operations back in the days of the old IO emulator, very long ago. Still, there''s no harm in leaving them unused. -- Keir
Julien Grall
2012-Aug-24 10:33 UTC
Re: [XEN][RFC PATCH V2 01/17] hvm: Modify interface to support multiple ioreq server
On 08/23/2012 02:26 PM, Keir Fraser wrote:> On 23/08/2012 14:18, "Ian Campbell"<Ian.Campbell@citrix.com> wrote: > > >>> diff --git a/xen/include/public/hvm/ioreq.h b/xen/include/public/hvm/ioreq.h >>> index 4022a1d..87aacd3 100644 >>> --- a/xen/include/public/hvm/ioreq.h >>> +++ b/xen/include/public/hvm/ioreq.h >>> @@ -34,6 +34,7 @@ >>> >>> #define IOREQ_TYPE_PIO 0 /* pio */ >>> #define IOREQ_TYPE_COPY 1 /* mmio ops */ >>> +#define IOREQ_TYPE_PCI_CONFIG 2 /* pci config space ops */ >>> #define IOREQ_TYPE_TIMEOFFSET 7 >>> #define IOREQ_TYPE_INVALIDATE 8 /* mapcache */ >>> >> I wonder why we skip 2-6 now -- perhaps they used to be something else >> and we are avoiding them to avoid strange errors? In which case adding >> the new on as 9 might be a good idea. >> > They were almost certainly used for representing R-M-W ALU operations back > in the days of the old IO emulator, very long ago. Still, there''s no harm in > leaving them unused. >Ok. So I will use number 9 for IOREQ_TYPE_PCI_CONFIG.