I discovered this with repeated calls to "make clean; make dist-tools" An alternative, if you wish to remove the use of $(PYTHON) from the clean path is to just `rm -rf build`, but using setup.py seems neater. -- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44 (0)1223 225 900, http://www.citrix.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Attached version 2, because it seems that despite my testing, "python setup.py clean" still doesn''t actually clean enough. On 14/08/12 15:10, Andrew Cooper wrote:> I discovered this with repeated calls to "make clean; make dist-tools" > > An alternative, if you wish to remove the use of $(PYTHON) from the > clean path is to just `rm -rf build`, but using setup.py seems neater. >-- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44 (0)1223 225 900, http://www.citrix.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Andrew Cooper writes ("Re: [Xen-devel] (V2) tools/python: Clean python
correctly"):> Attached version 2, because it seems that despite my testing, "python
> setup.py clean" still doesn''t actually clean enough.
>
> On 14/08/12 15:10, Andrew Cooper wrote:
> > I discovered this with repeated calls to "make clean; make
dist-tools"
> >
> > An alternative, if you wish to remove the use of $(PYTHON) from the
> > clean path is to just `rm -rf build`, but using setup.py seems neater.
Perhaps removing the build directory would be better and faster and
more reliable ?
Ian.
On 14/08/12 18:34, Ian Jackson wrote:> Andrew Cooper writes ("Re: [Xen-devel] (V2) tools/python: Clean python correctly"): >> Attached version 2, because it seems that despite my testing, "python >> setup.py clean" still doesn''t actually clean enough. >> >> On 14/08/12 15:10, Andrew Cooper wrote: >>> I discovered this with repeated calls to "make clean; make dist-tools" >>> >>> An alternative, if you wish to remove the use of $(PYTHON) from the >>> clean path is to just `rm -rf build`, but using setup.py seems neater. > Perhaps removing the build directory would be better and faster and > more reliable ? > > Ian.That would put the code in line with tools/pygrub. Sec while I make a v3 patch -- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44 (0)1223 225 900, http://www.citrix.com
On 14/08/12 15:10, Andrew Cooper wrote:>>>> I discovered this with repeated calls to "make clean; make dist-tools" >>>> >>>> An alternative, if you wish to remove the use of $(PYTHON) from the >>>> clean path is to just `rm -rf build`, but using setup.py seems neater. >> Perhaps removing the build directory would be better and faster and >> more reliable ? >> >> Ian. >> >>Attached -- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44 (0)1223 225 900, http://www.citrix.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
On Tue, 2012-08-14 at 18:45 +0100, Andrew Cooper wrote:> tools/python: Clean python correctly > > Cleaning the python directory should completely remove the build/ > directory, otherwise subsequent builds may be short-circuited and a > stale build installed. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>Acked-by: Ian Campbell <ian.campbell@citrix.com> And applied, thanks, Ian.