Xen devel - Jul 2012 - [PATCH] Intel VT-d: Dump IOMMU supported page sizes

diff -r e6266fc76d08 -r 6feac926cf80 xen/drivers/passthrough/vtd/iommu.c
--- a/xen/drivers/passthrough/vtd/iommu.c	Fri Jul 27 12:22:13 2012 +0200
+++ b/xen/drivers/passthrough/vtd/iommu.c	Mon Jul 30 15:35:16 2012 -0700
@@ -2137,6 +2137,15 @@ int __init intel_vtd_setup(void)
     {
         iommu = drhd->iommu;
 
+        printk("Intel VT-d supported page sizes: 4kB");
+        if (cap_sps_2mb(iommu->cap))
+            printk(", 2MB");
+
+        if (cap_sps_1gb(iommu->cap))
+            printk(", 1GB");
+
+        printk(".\n");
+
         if ( iommu_snoop && !ecap_snp_ctl(iommu->ecap) )
             iommu_snoop = 0;

On 30/07/12 23:41, Santosh Jodh wrote:
> diff -r e6266fc76d08 -r 6feac926cf80 xen/drivers/passthrough/vtd/iommu.c
> --- a/xen/drivers/passthrough/vtd/iommu.c	Fri Jul 27 12:22:13 2012 +0200
> +++ b/xen/drivers/passthrough/vtd/iommu.c	Mon Jul 30 15:35:16 2012 -0700
> @@ -2137,6 +2137,15 @@ int __init intel_vtd_setup(void)
>      {
>          iommu = drhd->iommu;
>  
> +        printk("Intel VT-d supported page sizes: 4kB");
> +        if (cap_sps_2mb(iommu->cap))
> +            printk(", 2MB");
> +
> +        if (cap_sps_1gb(iommu->cap))
> +            printk(", 1GB");
> +
> +        printk(".\n");
> +
>          if ( iommu_snoop && !ecap_snp_ctl(iommu->ecap) )
>              iommu_snoop = 0;
>  
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
While the contents of this patch looks fine, and in line with c/s
24992:0384f791e538 which does the same for HAP page sizes, patches for
Xen should follow the format described at
http://wiki.xen.org/wiki/Submitting_Xen_Patches (specifically with a
description and a Signed-off-by line)

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com

Signed-off-by: Santosh Jodh <santosh.jodh@citrix.com>

diff -r e6266fc76d08 -r 33dcecf4e454 xen/drivers/passthrough/vtd/iommu.c
--- a/xen/drivers/passthrough/vtd/iommu.c	Fri Jul 27 12:22:13 2012 +0200
+++ b/xen/drivers/passthrough/vtd/iommu.c	Tue Jul 31 08:08:06 2012 -0700
@@ -2137,6 +2137,15 @@ int __init intel_vtd_setup(void)
     {
         iommu = drhd->iommu;
 
+        printk("Intel VT-d supported page sizes: 4kB");
+        if (cap_sps_2mb(iommu->cap))
+            printk(", 2MB");
+
+        if (cap_sps_1gb(iommu->cap))
+            printk(", 1GB");
+
+        printk(".\n");
+
         if ( iommu_snoop && !ecap_snp_ctl(iommu->ecap) )
             iommu_snoop = 0;

Doh! Resending...

Thanks,
Santosh

-----Original Message-----
From: Andrew Cooper [mailto:andrew.cooper3@citrix.com] 
Sent: Tuesday, July 31, 2012 2:28 AM
To: Santosh Jodh
Cc: xen-devel@lists.xensource.com; xiantao.zhang@intel.com
Subject: Re: [Xen-devel] [PATCH] Intel VT-d: Dump IOMMU supported page sizes

On 30/07/12 23:41, Santosh Jodh wrote:
> diff -r e6266fc76d08 -r 6feac926cf80 xen/drivers/passthrough/vtd/iommu.c
> --- a/xen/drivers/passthrough/vtd/iommu.c	Fri Jul 27 12:22:13 2012 +0200
> +++ b/xen/drivers/passthrough/vtd/iommu.c	Mon Jul 30 15:35:16 2012 -0700
> @@ -2137,6 +2137,15 @@ int __init intel_vtd_setup(void)
>      {
>          iommu = drhd->iommu;
>  
> +        printk("Intel VT-d supported page sizes: 4kB");
> +        if (cap_sps_2mb(iommu->cap))
> +            printk(", 2MB");
> +
> +        if (cap_sps_1gb(iommu->cap))
> +            printk(", 1GB");
> +
> +        printk(".\n");
> +
>          if ( iommu_snoop && !ecap_snp_ctl(iommu->ecap) )
>              iommu_snoop = 0;
>  
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
While the contents of this patch looks fine, and in line with c/s
24992:0384f791e538 which does the same for HAP page sizes, patches for Xen
should follow the format described at
http://wiki.xen.org/wiki/Submitting_Xen_Patches (specifically with a description
and a Signed-off-by line)

--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com