How is LIBDIR in xen/Makefile supposed to be set? During ''make xen'' all the fine efi stuff is installed in /efi instead of /usr/lib64/efi. And: is /usr/lib64/efi the correct place anyway? Olaf
On Wed, Jul 11, 2012 at 01:26:07AM -0700, Olaf Hering wrote:> > How is LIBDIR in xen/Makefile supposed to be set? During ''make xen'' all > the fine efi stuff is installed in /efi instead of /usr/lib64/efi. > And: is /usr/lib64/efi the correct place anyway?Are you noticing new broken behavior? Ian C. recently committed a change I made to honor ./configure --libdir=... for tools targets [1], but that shouldn''t have affected the xen subtree. I''ve not been building with a compiler that supports __ms_abi__, so I''ve never noticed this. Matt [1] http://xenbits.xen.org/hg/xen-unstable.hg/rev/ad08cd8e7097
On Wed, Jul 11, Matt Wilson wrote:> On Wed, Jul 11, 2012 at 01:26:07AM -0700, Olaf Hering wrote: > > > > How is LIBDIR in xen/Makefile supposed to be set? During ''make xen'' all > > the fine efi stuff is installed in /efi instead of /usr/lib64/efi. > > And: is /usr/lib64/efi the correct place anyway? > > Are you noticing new broken behavior? Ian C. recently committed a > change I made to honor ./configure --libdir=... for tools targets [1], > but that shouldn''t have affected the xen subtree.Matt, I do indeed notice some build breakage since the last two weeks. But since xen/Makefile did not change I wonder how it worked up to now. I have not yet bisected the issue. On the other hand, building xen is not supposed to rely on configure. Perhaps an easy change is to just define LIBDIR in xen/Makefile. Olaf
On Wed, Jul 11, 2012 at 09:51:13AM -0700, Olaf Hering wrote:> On Wed, Jul 11, Matt Wilson wrote: > > > On Wed, Jul 11, 2012 at 01:26:07AM -0700, Olaf Hering wrote: > > > > > > How is LIBDIR in xen/Makefile supposed to be set? During ''make xen'' all > > > the fine efi stuff is installed in /efi instead of /usr/lib64/efi. > > > And: is /usr/lib64/efi the correct place anyway? > > > > Are you noticing new broken behavior? Ian C. recently committed a > > change I made to honor ./configure --libdir=... for tools targets [1], > > but that shouldn''t have affected the xen subtree. > > Matt, > > I do indeed notice some build breakage since the last two weeks. But > since xen/Makefile did not change I wonder how it worked up to now. I > have not yet bisected the issue. > > On the other hand, building xen is not supposed to rely on configure. > Perhaps an easy change is to just define LIBDIR in xen/Makefile.I think that other efi binaries like elilo.efi usually live in /usr/lib64/efi, so perhaps in the short term there should just be an explicit EFIDIR variable in xen/Makefile. Ultimately I think that LIBDIR should follow the ./configure --libdir setting, which would land the efi binaries in the wrong place. Matt
On 07/11/12 18:36, Matt Wilson wrote:> On Wed, Jul 11, 2012 at 01:26:07AM -0700, Olaf Hering wrote: >> >> How is LIBDIR in xen/Makefile supposed to be set? During ''make xen'' all >> the fine efi stuff is installed in /efi instead of /usr/lib64/efi. >> And: is /usr/lib64/efi the correct place anyway? > > Are you noticing new broken behavior? Ian C. recently committed a > change I made to honor ./configure --libdir=... for tools targets [1], > but that shouldn''t have affected the xen subtree. > > I''ve not been building with a compiler that supports __ms_abi__, so > I''ve never noticed this.Does this patch help: http://lists.xen.org/archives/html/xen-devel/2012-07/msg00511.html Christoph> Matt > > [1] http://xenbits.xen.org/hg/xen-unstable.hg/rev/ad08cd8e7097-- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
On Thu, Jul 12, Christoph Egger wrote:> Does this patch help: > http://lists.xen.org/archives/html/xen-devel/2012-07/msg00511.htmlIt cant help because xen/Makefile does not include config/Tools.mk Olaf
On 11/07/2012 09:26, Olaf Hering wrote:> > How is LIBDIR in xen/Makefile supposed to be set? During ''make xen'' all > the fine efi stuff is installed in /efi instead of /usr/lib64/efi. > And: is /usr/lib64/efi the correct place anyway?Should the efi tools be moved to tools/? David
On Thu, 2012-07-12 at 05:05 -0400, David Vrabel wrote:> On 11/07/2012 09:26, Olaf Hering wrote: > > > > How is LIBDIR in xen/Makefile supposed to be set? During ''make xen'' all > > the fine efi stuff is installed in /efi instead of /usr/lib64/efi. > > And: is /usr/lib64/efi the correct place anyway? > > Should the efi tools be moved to tools/?What are the tools? Or are these the hypervisor efi binaries (in which case wy not install to /boot?) Ian.