thr3ads.net - Xen devel - [PATCH] libxl: fix unitialized variables in libxl__primary_console

If this information is useful, please help other people find it:
Share via:

Olaf Hering

2012-Jul-04 12:17 UTC

[PATCH] libxl: fix unitialized variables in libxl__primary_console_find

# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1341404234 -7200
# Node ID 5668cb98eebb0a27530c8b52f3ae8cce87d3b863
# Parent  42f76d536b116d2ebad1b6705ae51ecd171d2581
libxl: fix unitialized variables in libxl__primary_console_find

gcc 4.5 as shipped with openSuSE 11.4 does not recognize the case of
LIBXL_DOMAIN_TYPE_INVALID properly:

cc1: warnings being treated as errors
libxl.c: In function ''libxl_primary_console_exec'':
libxl.c:1408:14: error: ''domid'' may be used uninitialized in
this function
libxl.c:1409:9: error: ''cons_num'' may be used uninitialized in
this function
libxl.c:1410:24: error: ''type'' may be used uninitialized in
this function
libxl.c: In function ''libxl_primary_console_get_tty'':
libxl.c:1421:14: error: ''domid'' may be used uninitialized in
this function
libxl.c:1422:9: error: ''cons_num'' may be used uninitialized in
this function
libxl.c:1423:24: error: ''type'' may be used uninitialized in
this function
make[3]: *** [libxl.o] Error 1

Fix this by adding a default case.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

diff -r 42f76d536b11 -r 5668cb98eebb tools/libxl/libxl.c
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -1392,6 +1392,7 @@ static int libxl__primary_console_find(l
             *type = LIBXL_CONSOLE_TYPE_PV;
             break;
         case LIBXL_DOMAIN_TYPE_INVALID:
+        default:
             rc = ERROR_INVAL;
             goto out;
         }

Ian Campbell

2012-Jul-23 10:51 UTC

head link

Re: [PATCH] libxl: fix unitialized variables in libxl__primary_console_find

On Wed, 2012-07-04 at 13:17 +0100, Olaf Hering wrote:> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1341404234 -7200
> # Node ID 5668cb98eebb0a27530c8b52f3ae8cce87d3b863
> # Parent  42f76d536b116d2ebad1b6705ae51ecd171d2581
> libxl: fix unitialized variables in libxl__primary_console_find
Olaf,

I have a vague recollection of some discussion of this and a different
fix but I can''t actually find any such discussion and the patch is
still
in my queue. Is this still needed?
> gcc 4.5 as shipped with openSuSE 11.4 does not recognize the case of
> LIBXL_DOMAIN_TYPE_INVALID properly:
That''s kind of lame of gcc...

I wonder if default: abort() might be more appropriate (I''m not sure
what our policy here ended up being).
> cc1: warnings being treated as errors
> libxl.c: In function ''libxl_primary_console_exec'':
> libxl.c:1408:14: error: ''domid'' may be used uninitialized
in this function
> libxl.c:1409:9: error: ''cons_num'' may be used
uninitialized in this function
> libxl.c:1410:24: error: ''type'' may be used uninitialized
in this function
> libxl.c: In function ''libxl_primary_console_get_tty'':
> libxl.c:1421:14: error: ''domid'' may be used uninitialized
in this function
> libxl.c:1422:9: error: ''cons_num'' may be used
uninitialized in this function
> libxl.c:1423:24: error: ''type'' may be used uninitialized
in this function
> make[3]: *** [libxl.o] Error 1
> 
> Fix this by adding a default case.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> diff -r 42f76d536b11 -r 5668cb98eebb tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -1392,6 +1392,7 @@ static int libxl__primary_console_find(l
>              *type = LIBXL_CONSOLE_TYPE_PV;
>              break;
>          case LIBXL_DOMAIN_TYPE_INVALID:
> +        default:
>              rc = ERROR_INVAL;
>              goto out;
>          }
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Olaf Hering

2012-Jul-23 13:43 UTC

head link

Re: [PATCH] libxl: fix unitialized variables in libxl__primary_console_find

On Mon, Jul 23, Ian Campbell wrote:
> On Wed, 2012-07-04 at 13:17 +0100, Olaf Hering wrote:
> > # HG changeset patch
> > # User Olaf Hering <olaf@aepfle.de>
> > # Date 1341404234 -7200
> > # Node ID 5668cb98eebb0a27530c8b52f3ae8cce87d3b863
> > # Parent  42f76d536b116d2ebad1b6705ae51ecd171d2581
> > libxl: fix unitialized variables in libxl__primary_console_find
> 
> Olaf,
> 
> I have a vague recollection of some discussion of this and a different
> fix but I can''t actually find any such discussion and the patch is
still
> in my queue. Is this still needed?
Yes.
> > gcc 4.5 as shipped with openSuSE 11.4 does not recognize the case of
> > LIBXL_DOMAIN_TYPE_INVALID properly:
> 
> That''s kind of lame of gcc...
> 
> I wonder if default: abort() might be more appropriate (I''m not
sure
> what our policy here ended up being).
libxl__domain_type is a simple and internal function. Perhaps a comment
about why a ''default'' case exists is enough.

Olaf

Ian Campbell

2012-Jul-24 08:45 UTC

head link

Re: [PATCH] libxl: fix unitialized variables in libxl__primary_console_find

On Mon, 2012-07-23 at 14:43 +0100, Olaf Hering wrote:> On Mon, Jul 23, Ian Campbell wrote:
> 
> > On Wed, 2012-07-04 at 13:17 +0100, Olaf Hering wrote:
> > > # HG changeset patch
> > > # User Olaf Hering <olaf@aepfle.de>
> > > # Date 1341404234 -7200
> > > # Node ID 5668cb98eebb0a27530c8b52f3ae8cce87d3b863
> > > # Parent  42f76d536b116d2ebad1b6705ae51ecd171d2581
> > > libxl: fix unitialized variables in libxl__primary_console_find
> > 
> > Olaf,
> > 
> > I have a vague recollection of some discussion of this and a different
> > fix but I can''t actually find any such discussion and the
patch is still
> > in my queue. Is this still needed?
> 
> Yes.
> 
> > > gcc 4.5 as shipped with openSuSE 11.4 does not recognize the case
of
> > > LIBXL_DOMAIN_TYPE_INVALID properly:
> > 
> > That''s kind of lame of gcc...
> > 
> > I wonder if default: abort() might be more appropriate (I''m
not sure
> > what our policy here ended up being).
> 
> libxl__domain_type is a simple and internal function. Perhaps a comment
> about why a ''default'' case exists is enough.
I think we''ve mostly been considering that the "abort()" is
in itself
enough documentation that this should never happen.

Ian.

Olaf Hering

2012-Jul-30 16:35 UTC

head link

[PATCH] libxl: fix unitialized variables in libxl__primary_console_find

# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1343662357 -7200
# Node ID db8adce4f09307a90f96103f7fd67efa97fc9ac0
# Parent  cf0e661cb321b1c898c9008dc17ba21db434c976
libxl: fix unitialized variables in libxl__primary_console_find

gcc 4.5 as shipped with openSuSE 11.4 does not recognize the case of
LIBXL_DOMAIN_TYPE_INVALID properly:

cc1: warnings being treated as errors
libxl.c: In function ''libxl_primary_console_exec'':
libxl.c:1408:14: error: ''domid'' may be used uninitialized in
this function
libxl.c:1409:9: error: ''cons_num'' may be used uninitialized in
this function
libxl.c:1410:24: error: ''type'' may be used uninitialized in
this function
libxl.c: In function ''libxl_primary_console_get_tty'':
libxl.c:1421:14: error: ''domid'' may be used uninitialized in
this function
libxl.c:1422:9: error: ''cons_num'' may be used uninitialized in
this function
libxl.c:1423:24: error: ''type'' may be used uninitialized in
this function
make[3]: *** [libxl.o] Error 1

Fix this by adding a default case.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

diff -r cf0e661cb321 -r db8adce4f093 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -1590,6 +1590,7 @@ static int libxl__primary_console_find(l
         case LIBXL_DOMAIN_TYPE_INVALID:
             rc = ERROR_INVAL;
             goto out;
+        default: abort();
         }
     }

Olaf Hering

2012-Jul-30 19:04 UTC

head link

Re: [PATCH] libxl: fix unitialized variables in libxl__primary_console_find

On Tue, Jul 24, Ian Campbell wrote:
> I think we''ve mostly been considering that the "abort()"
is in itself
> enough documentation that this should never happen.
I have posted a patch which does that. Other places in that file have
the same ''default: abort();'' already.

Olaf

Ian Campbell

2012-Aug-01 11:47 UTC

head link

Re: [PATCH] libxl: fix unitialized variables in libxl__primary_console_find

On Mon, 2012-07-30 at 17:35 +0100, Olaf Hering wrote:> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1343662357 -7200
> # Node ID db8adce4f09307a90f96103f7fd67efa97fc9ac0
> # Parent  cf0e661cb321b1c898c9008dc17ba21db434c976
> libxl: fix unitialized variables in libxl__primary_console_find
> 
> gcc 4.5 as shipped with openSuSE 11.4 does not recognize the case of
> LIBXL_DOMAIN_TYPE_INVALID properly:
> 
> cc1: warnings being treated as errors
> libxl.c: In function ''libxl_primary_console_exec'':
> libxl.c:1408:14: error: ''domid'' may be used uninitialized
in this function
> libxl.c:1409:9: error: ''cons_num'' may be used
uninitialized in this function
> libxl.c:1410:24: error: ''type'' may be used uninitialized
in this function
> libxl.c: In function ''libxl_primary_console_get_tty'':
> libxl.c:1421:14: error: ''domid'' may be used uninitialized
in this function
> libxl.c:1422:9: error: ''cons_num'' may be used
uninitialized in this function
> libxl.c:1423:24: error: ''type'' may be used uninitialized
in this function
> make[3]: *** [libxl.o] Error 1
> 
> Fix this by adding a default case.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Ian Campbell <ian.campbell@citrix.com>

Applied, thanks.
> 
> diff -r cf0e661cb321 -r db8adce4f093 tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -1590,6 +1590,7 @@ static int libxl__primary_console_find(l
>          case LIBXL_DOMAIN_TYPE_INVALID:
>              rc = ERROR_INVAL;
>              goto out;
> +        default: abort();
>          }
>      }
>  
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Xen devel - Jul 2012 - [PATCH] libxl: fix unitialized variables in libxl__primary_console_find

[PATCH] libxl: fix unitialized variables in libxl__primary_console_find

Re: [PATCH] libxl: fix unitialized variables in libxl__primary_console_find

Re: [PATCH] libxl: fix unitialized variables in libxl__primary_console_find

Re: [PATCH] libxl: fix unitialized variables in libxl__primary_console_find

[PATCH] libxl: fix unitialized variables in libxl__primary_console_find

Re: [PATCH] libxl: fix unitialized variables in libxl__primary_console_find

Re: [PATCH] libxl: fix unitialized variables in libxl__primary_console_find