flight 13389 xen-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/13389/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 4 xen-build fail REGR. vs. 13379 test-i386-i386-xl-qemuu-winxpsp3 9 guest-localmigrate fail REGR. vs. 13379 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-pcipt-intel 1 xen-build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 xen-build-check(1) blocked n/a test-amd64-i386-rhel6hvm-amd 1 xen-build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 xen-build-check(1) blocked n/a test-amd64-i386-rhel6hvm-intel 1 xen-build-check(1) blocked n/a test-amd64-i386-pv 1 xen-build-check(1) blocked n/a test-amd64-amd64-pv 1 xen-build-check(1) blocked n/a test-amd64-i386-xl 1 xen-build-check(1) blocked n/a test-amd64-i386-xl-credit2 1 xen-build-check(1) blocked n/a test-amd64-amd64-xl-sedf 1 xen-build-check(1) blocked n/a test-amd64-amd64-pair 1 xen-build-check(1) blocked n/a test-amd64-i386-xend-winxpsp3 1 xen-build-check(1) blocked n/a test-amd64-amd64-win 1 xen-build-check(1) blocked n/a test-amd64-i386-xl-multivcpu 1 xen-build-check(1) blocked n/a test-amd64-i386-win-vcpus1 1 xen-build-check(1) blocked n/a test-amd64-amd64-xl-sedf-pin 1 xen-build-check(1) blocked n/a test-amd64-amd64-xl 1 xen-build-check(1) blocked n/a test-amd64-i386-win 1 xen-build-check(1) blocked n/a test-amd64-i386-pair 1 xen-build-check(1) blocked n/a test-i386-i386-win 16 leak-check/check fail never pass test-amd64-amd64-xl-win7-amd64 1 xen-build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-winxpsp3 1 xen-build-check(1) blocked n/a test-amd64-amd64-xl-win 1 xen-build-check(1) blocked n/a test-amd64-i386-xl-win7-amd64 1 xen-build-check(1) blocked n/a test-i386-i386-xl-win 13 guest-stop fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 1 xen-build-check(1) blocked n/a test-amd64-i386-xl-win-vcpus1 1 xen-build-check(1) blocked n/a test-amd64-amd64-xl-winxpsp3 1 xen-build-check(1) blocked n/a test-i386-i386-xl-winxpsp3 13 guest-stop fail never pass test-amd64-i386-xl-winxpsp3-vcpus1 1 xen-build-check(1) blocked n/a version targeted for testing: xen 0455d8317631 baseline version: xen 4f92bdf3370c ------------------------------------------------------------ People who touched revisions under test: Andres Lagar-Cavilla <andres@lagarcavilla.org> Dario Faggioli <dario.faggioli@citrix.com> Dario Faggioli <raistlin@linux.it> George Dunlap <george.dunlap@eu.citrix.com> Ian Campbell <ian.campbell@citrix.com> Ian Jackson <ian.jackson@eu.citrix.com> Jan Beulich <jbeulich@suse.com> Keir Fraser <keir@xen.org> Roger Pau Monne <roger.pau@entel.upc.edu> Stefano Stabellini <stefano.stabellini@eu.citrix.com> Tim Deegan <tim@xen.org> Yang Zhang <yang.z.zhang@Intel.com> ------------------------------------------------------------ jobs: build-amd64 fail build-i386 pass build-amd64-oldkern pass build-i386-oldkern pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-i386-xl blocked test-i386-i386-xl pass test-amd64-i386-rhel6hvm-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-win7-amd64 blocked test-amd64-i386-xl-win7-amd64 blocked test-amd64-i386-xl-credit2 blocked test-amd64-amd64-xl-pcipt-intel blocked test-amd64-i386-rhel6hvm-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-i386-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-i386-i386-pair pass test-amd64-amd64-xl-sedf-pin blocked test-amd64-amd64-pv blocked test-amd64-i386-pv blocked test-i386-i386-pv pass test-amd64-amd64-xl-sedf blocked test-amd64-i386-win-vcpus1 blocked test-amd64-i386-xl-win-vcpus1 blocked test-amd64-i386-xl-winxpsp3-vcpus1 blocked test-amd64-amd64-win blocked test-amd64-i386-win blocked test-i386-i386-win fail test-amd64-amd64-xl-win blocked test-i386-i386-xl-win fail test-amd64-amd64-xl-qemuu-winxpsp3 blocked test-i386-i386-xl-qemuu-winxpsp3 fail test-amd64-i386-xend-winxpsp3 blocked test-amd64-amd64-xl-winxpsp3 blocked test-i386-i386-xl-winxpsp3 fail ------------------------------------------------------------ sg-report-flight on woking.cam.xci-test.com logs: /home/xc_osstest/logs images: /home/xc_osstest/images Logs, config files, etc. are available at http://www.chiark.greenend.org.uk/~xensrcts/logs Test harness code can be found at http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 863 lines long.)
On Fri, 2012-06-29 at 04:39 +0100, xen.org wrote:> test-i386-i386-xl-qemuu-winxpsp3 9 guest-localmigrate fail REGR. vs. 13379migration target: Ready to receive domain. Saving to migration stream new xl format (info 0x0/0x0/661) Loading new save file <incoming migration stream> (new xl fmt info 0x0/0x0/661) Savefile contains xl domain config WARNING: ignoring "kernel" directive for HVM guest. Use "firmware_override" instead if you really want a non-default firmware xl: libxl_xshelp.c:174: libxl__xs_transaction_start: Assertion `!*t'' failed. 8<--------------------------------------------------------- # HG changeset patch # User Ian Campbell <ian.campbell@citrix.com> # Date 1340954225 -3600 # Node ID 75c5ca9f6111226c06fc5da8071b160b6ac7904b # Parent c5b08c577c7fba45724f4a0f84abf576c6299b9c libxl: libxl__xs_transaction_commit should always clear the transaction. This includes the EAGAIN case. Users are of the form: xs_transaction_t t = 0; for (;;) { rc = libxl__xs_transaction_start(gc, &t); rc = stuff if (rc) goto out; ...more... rc = libxl__xs_transaction_commit(gc, &t); if (!rc) break; if (rc<0) goto out; } ... out: So in EAGAIN (commit -> +1) we will go round the loop again and call start which leads to: xl: libxl_xshelp.c:174: libxl__xs_transaction_start: Assertion `!*t'' failed. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> diff -r c5b08c577c7f -r 75c5ca9f6111 tools/libxl/libxl_xshelp.c --- a/tools/libxl/libxl_xshelp.c Fri Jun 29 08:05:09 2012 +0100 +++ b/tools/libxl/libxl_xshelp.c Fri Jun 29 08:17:05 2012 +0100 @@ -185,10 +185,10 @@ int libxl__xs_transaction_commit(libxl__ assert(*t); if (!xs_transaction_end(CTX->xsh, *t, 0)) { + *t = 0; if (errno == EAGAIN) return +1; - *t = 0; LOGE(ERROR, "could not commit xenstore transaction"); return ERROR_FAIL; }
Ian Campbell writes ("Re: [Xen-devel] [xen-unstable test] 13389: regressions - FAIL"):> On Fri, 2012-06-29 at 04:39 +0100, xen.org wrote: > > test-i386-i386-xl-qemuu-winxpsp3 9 guest-localmigrate fail REGR. vs. 13379 > > migration target: Ready to receive domain. > Saving to migration stream new xl format (info 0x0/0x0/661) > Loading new save file <incoming migration stream> (new xl fmt info 0x0/0x0/661) > Savefile contains xl domain config > WARNING: ignoring "kernel" directive for HVM guest. Use "firmware_override" instead if you really want a non-default firmware > xl: libxl_xshelp.c:174: libxl__xs_transaction_start: Assertion `!*t'' failed.Oh dear, sorry.> libxl: libxl__xs_transaction_commit should always clear the transaction.Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> Committed-by: Ian Jackson <ian.jackson@eu.citrix.com> Thanks! Ian.