Stefano Stabellini
2012-Jun-27 13:39 UTC
[PATCH] qemu-traditional: disable msitranslate by default
msitranslate is known to cause problems with some device drivers,
because it sets the real device in MSI mode while making the guest think
is actually in legacy interrupts mode. Some drivers are able to spot this
inconsistency and break (Nvidia drivers for example).
Disable the option by default.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
diff --git a/xenstore.c b/xenstore.c
index ac90366..8af280e 100644
--- a/xenstore.c
+++ b/xenstore.c
@@ -427,7 +427,7 @@ uint32_t xenstore_read_target(void)
return target_domid;
}
-#define PT_PCI_MSITRANSLATE_DEFAULT 1
+#define PT_PCI_MSITRANSLATE_DEFAULT 0
#define PT_PCI_POWER_MANAGEMENT_DEFAULT 0
int direct_pci_msitranslate;
int direct_pci_power_mgmt;
George Dunlap
2012-Jun-27 13:39 UTC
Re: [PATCH] qemu-traditional: disable msitranslate by default
On 27/06/12 14:39, Stefano Stabellini wrote:> msitranslate is known to cause problems with some device drivers, > because it sets the real device in MSI mode while making the guest think > is actually in legacy interrupts mode. Some drivers are able to spot this > inconsistency and break (Nvidia drivers for example). > > Disable the option by default. > > Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>This patch has been in XenServer for two releases now. Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
Ian Jackson
2012-Jun-28 14:50 UTC
Re: [PATCH] qemu-traditional: disable msitranslate by default
George Dunlap writes ("Re: [Xen-devel] [PATCH] qemu-traditional: disable
msitranslate by default"):> On 27/06/12 14:39, Stefano Stabellini wrote:
> > msitranslate is known to cause problems with some device drivers,
> > because it sets the real device in MSI mode while making the guest
think
> > is actually in legacy interrupts mode. Some drivers are able to spot
this
> > inconsistency and break (Nvidia drivers for example).
> >
> > Disable the option by default.
> >
> > Signed-off-by: Stefano
Stabellini<stefano.stabellini@eu.citrix.com>
> This patch has been in XenServer for two releases now.
>
> Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
Thanks.
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>