There''s no apparent reason not to permit this, and since we
don''t
support out-of-source-tree builds, the least overhead way of doing
multiple, differently configured (perhaps different architecture)
builds from a single source tree is to create symlinked build trees.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/docs/xen-headers
+++ b/docs/xen-headers
@@ -368,7 +368,7 @@ foreach $pass (qw(1 2)) {
find({ wanted =>
sub {
return unless m/\.h$/;
- lstat $File::Find::name or die "$File::Find::name
$!";
+ stat $File::Find::name or die "$File::Find::name
$!";
-f _ or die "$File::Find::name";
substr($File::Find::name, 0, 1+length $basedir)
eq "$basedir/"
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Ian Campbell
2012-Jun-26 16:28 UTC
Re: [PATCH] docs/xen-headers: allow headers to be symlinks
On Thu, 2012-06-21 at 13:20 +0100, Jan Beulich wrote:> There''s no apparent reason not to permit this, and since we don''t > support out-of-source-tree builds, the least overhead way of doing > multiple, differently configured (perhaps different architecture) > builds from a single source tree is to create symlinked build trees. > > Signed-off-by: Jan Beulich <jbeulich@suse.com>Seems reasonable and applying the patch resulted in no change in the output on this end: Acked-by: Ian Campbell <ian.campbell@citrix.com>> > --- a/docs/xen-headers > +++ b/docs/xen-headers > @@ -368,7 +368,7 @@ foreach $pass (qw(1 2)) { > find({ wanted => > sub { > return unless m/\.h$/; > - lstat $File::Find::name or die "$File::Find::name $!"; > + stat $File::Find::name or die "$File::Find::name $!"; > -f _ or die "$File::Find::name"; > substr($File::Find::name, 0, 1+length $basedir) > eq "$basedir/" > > >
Ian Jackson
2012-Jun-29 16:35 UTC
Re: [PATCH] docs/xen-headers: allow headers to be symlinks
Ian Campbell writes ("Re: [Xen-devel] [PATCH] docs/xen-headers: allow
headers to be symlinks"):> On Thu, 2012-06-21 at 13:20 +0100, Jan Beulich wrote:
> > There''s no apparent reason not to permit this, and since we
don''t
> > support out-of-source-tree builds, the least overhead way of doing
> > multiple, differently configured (perhaps different architecture)
> > builds from a single source tree is to create symlinked build trees.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Seems reasonable and applying the patch resulted in no change in the
> output on this end:
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Indeed, this is correct. I see it''s been applied.
Ian.