Ian Campbell
2012-May-17 15:39 UTC
[PATCH] libxl: initialise ao when starting pvqemu for stubdomain
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1337269180 -3600
# Node ID 66359ac0c8d9046e0c033d428e0416884c612e33
# Parent b01e20b8ab4d17c209f4e86ab31c363754a387cd
libxl: initialise ao when starting pvqemu for stubdomain.
libxl__spawn_local_dm requires the ao to be initialised.
Without this starting an HVM guest with a stub qemu hits the
assert(ao->magic == LIBXL__AO_MAGIC);
in the STATE_AO_GC call from libxl__spawn_local_dm.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r b01e20b8ab4d -r 66359ac0c8d9 tools/libxl/libxl_dm.c
--- a/tools/libxl/libxl_dm.c Thu May 17 16:39:38 2012 +0100
+++ b/tools/libxl/libxl_dm.c Thu May 17 16:39:40 2012 +0100
@@ -858,6 +858,7 @@ retry_transaction:
goto out_free;
}
+ sdss->pvqemu.spawn.ao = ao;
sdss->pvqemu.guest_domid = dm_domid;
sdss->pvqemu.guest_config = &sdss->dm_config;
sdss->pvqemu.build_state = &sdss->dm_state;
Ian Campbell
2012-May-18 12:43 UTC
Re: [PATCH] libxl: initialise ao when starting pvqemu for stubdomain
On Thu, 2012-05-17 at 16:39 +0100, Ian Campbell wrote:> # HG changeset patch > # User Ian Campbell <ian.campbell@citrix.com> > # Date 1337269180 -3600 > # Node ID 66359ac0c8d9046e0c033d428e0416884c612e33 > # Parent b01e20b8ab4d17c209f4e86ab31c363754a387cd > libxl: initialise ao when starting pvqemu for stubdomain. > > libxl__spawn_local_dm requires the ao to be initialised. > > Without this starting an HVM guest with a stub qemu hits the > assert(ao->magic == LIBXL__AO_MAGIC); > in the STATE_AO_GC call from libxl__spawn_local_dm. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>Ian Jackson acked this out of band and I have therefore applied it.> > diff -r b01e20b8ab4d -r 66359ac0c8d9 tools/libxl/libxl_dm.c > --- a/tools/libxl/libxl_dm.c Thu May 17 16:39:38 2012 +0100 > +++ b/tools/libxl/libxl_dm.c Thu May 17 16:39:40 2012 +0100 > @@ -858,6 +858,7 @@ retry_transaction: > goto out_free; > } > > + sdss->pvqemu.spawn.ao = ao; > sdss->pvqemu.guest_domid = dm_domid; > sdss->pvqemu.guest_config = &sdss->dm_config; > sdss->pvqemu.build_state = &sdss->dm_state; > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel