Xen devel - May 2012 - [PATCH] x86: fix i8259A_resume()

On systems that have an IO-APIC, we generally run the PIC in AEOI
mode, yet i8259A_resume() so far failed to put it back into that mode.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/i8259.c
+++ b/xen/arch/x86/i8259.c
@@ -314,7 +314,7 @@ static void save_ELCR(char *trigger)
 
 int i8259A_resume(void)
 {
-    init_8259A(0);
+    init_8259A(i8259A_irq_type.ack == disable_8259A_irq);
     restore_ELCR(irq_trigger);
     return 0;
 }

On 14/05/2012 12:46, "Jan Beulich" <JBeulich@suse.com> wrote:
> On systems that have an IO-APIC, we generally run the PIC in AEOI
> mode, yet i8259A_resume() so far failed to put it back into that mode.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/arch/x86/i8259.c
> +++ b/xen/arch/x86/i8259.c
> @@ -314,7 +314,7 @@ static void save_ELCR(char *trigger)
>  
>  int i8259A_resume(void)
>  {
> -    init_8259A(0);
> +    init_8259A(i8259A_irq_type.ack == disable_8259A_irq);
>      restore_ELCR(irq_trigger);
>      return 0;
>  }
> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel