Olaf Hering
2012-May-11 14:35 UTC
[PATCH] unmodified_drivers: remove inclusion of asm/system.h
# HG changeset patch # User Olaf Hering <olaf@aepfle.de> # Date 1336743357 -7200 # Node ID f81fa4014d8c66bd1a80e4914c5d777cbdb343d1 # Parent 0f53540494f779a1260d4e5319dcdb268389dd07 unmodified_drivers: remove inclusion of asm/system.h Allow compilation of PVonHVM drivers with forward-ported xenlinux sources in openSuSE 12.2. Since Linux 3.4 asm/system.h is not present anymore. Remove inclusion of this header, its not needed. Signed-off-by: Olaf Hering <olaf@aepfle.de> diff -r 0f53540494f7 -r f81fa4014d8c unmodified_drivers/linux-2.6/platform-pci/platform-pci.c --- a/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c +++ b/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c @@ -30,7 +30,6 @@ #include <linux/interrupt.h> #include <linux/vmalloc.h> #include <linux/mm.h> -#include <asm/system.h> #include <asm/io.h> #include <asm/irq.h> #include <asm/uaccess.h>
Ian Campbell
2012-May-11 15:59 UTC
Re: [PATCH] unmodified_drivers: remove inclusion of asm/system.h
On Fri, 2012-05-11 at 15:35 +0100, Olaf Hering wrote:> # HG changeset patch > # User Olaf Hering <olaf@aepfle.de> > # Date 1336743357 -7200 > # Node ID f81fa4014d8c66bd1a80e4914c5d777cbdb343d1 > # Parent 0f53540494f779a1260d4e5319dcdb268389dd07 > unmodified_drivers: remove inclusion of asm/system.h > > Allow compilation of PVonHVM drivers with forward-ported xenlinux > sources in openSuSE 12.2. Since Linux 3.4 asm/system.h is not present > anymore. Remove inclusion of this header, its not needed.It is not needed for 3.4 or it is not needed for any historical Linux version which these drivers are supposed to be built against? What kernels have you build tested? Ian.> Signed-off-by: Olaf Hering <olaf@aepfle.de> > > diff -r 0f53540494f7 -r f81fa4014d8c unmodified_drivers/linux-2.6/platform-pci/platform-pci.c > --- a/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c > +++ b/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c > @@ -30,7 +30,6 @@ > #include <linux/interrupt.h> > #include <linux/vmalloc.h> > #include <linux/mm.h> > -#include <asm/system.h> > #include <asm/io.h> > #include <asm/irq.h> > #include <asm/uaccess.h> > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
Olaf Hering
2012-May-11 16:21 UTC
Re: [PATCH] unmodified_drivers: remove inclusion of asm/system.h
On Fri, May 11, Ian Campbell wrote:> On Fri, 2012-05-11 at 15:35 +0100, Olaf Hering wrote: > > # HG changeset patch > > # User Olaf Hering <olaf@aepfle.de> > > # Date 1336743357 -7200 > > # Node ID f81fa4014d8c66bd1a80e4914c5d777cbdb343d1 > > # Parent 0f53540494f779a1260d4e5319dcdb268389dd07 > > unmodified_drivers: remove inclusion of asm/system.h > > > > Allow compilation of PVonHVM drivers with forward-ported xenlinux > > sources in openSuSE 12.2. Since Linux 3.4 asm/system.h is not present > > anymore. Remove inclusion of this header, its not needed. > > It is not needed for 3.4 or it is not needed for any historical Linux > version which these drivers are supposed to be built against? What > kernels have you build tested?asm/system.h does not need to be included. I tested it with sles11sp1+2, opensuse 11.2, 11.4, 12.1 and 12.2. I have not tested it with a plain linux-2.6.18-xen.hg, but I suspect it should work there too. Olaf
Jan Beulich
2012-May-14 10:10 UTC
Re: [PATCH] unmodified_drivers: remove inclusion of asm/system.h
>>> On 11.05.12 at 18:21, Olaf Hering <olaf@aepfle.de> wrote: > On Fri, May 11, Ian Campbell wrote: > >> On Fri, 2012-05-11 at 15:35 +0100, Olaf Hering wrote: >> > # HG changeset patch >> > # User Olaf Hering <olaf@aepfle.de> >> > # Date 1336743357 -7200 >> > # Node ID f81fa4014d8c66bd1a80e4914c5d777cbdb343d1 >> > # Parent 0f53540494f779a1260d4e5319dcdb268389dd07 >> > unmodified_drivers: remove inclusion of asm/system.h >> > >> > Allow compilation of PVonHVM drivers with forward-ported xenlinux >> > sources in openSuSE 12.2. Since Linux 3.4 asm/system.h is not present >> > anymore. Remove inclusion of this header, its not needed. >> >> It is not needed for 3.4 or it is not needed for any historical Linux >> version which these drivers are supposed to be built against? What >> kernels have you build tested? > > asm/system.h does not need to be included. > I tested it with sles11sp1+2, opensuse 11.2, 11.4, 12.1 and 12.2. > I have not tested it with a plain linux-2.6.18-xen.hg, but I suspect it > should work there too.I did before pushing it, and it''s okay there too. Jan