Jan Beulich
2012-May-10 09:21 UTC
[PATCH] x86/irq: fix locking for c/s 24707:96987c324a4f debugging code
Without this, dump_irqs() may try to acquire the lock the caller is
currently holding.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -668,6 +668,7 @@ void irq_move_cleanup_interrupt(struct c
{
if ( unlikely(!test_bit(vector, desc->arch.used_vectors)) )
{
+ spin_unlock(&desc->lock);
bitmap_scnlistprintf(keyhandler_scratch,
sizeof(keyhandler_scratch),
desc->arch.used_vectors->_bits,
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Andrew Cooper
2012-May-10 09:26 UTC
Re: [PATCH] x86/irq: fix locking for c/s 24707:96987c324a4f debugging code
On 10/05/12 10:21, Jan Beulich wrote:> Without this, dump_irqs() may try to acquire the lock the caller is > currently holding. > > Signed-off-by: Jan Beulich <jbeulich@suse.com>With the proviso that this is patch will disappear when all (3 so far) of these debugging patches disappear. Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>> > --- a/xen/arch/x86/irq.c > +++ b/xen/arch/x86/irq.c > @@ -668,6 +668,7 @@ void irq_move_cleanup_interrupt(struct c > { > if ( unlikely(!test_bit(vector, desc->arch.used_vectors)) ) > { > + spin_unlock(&desc->lock); > bitmap_scnlistprintf(keyhandler_scratch, > sizeof(keyhandler_scratch), > desc->arch.used_vectors->_bits, > > >-- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44 (0)1223 225 900, http://www.citrix.com
Jan Beulich
2012-May-10 09:33 UTC
Re: [PATCH] x86/irq: fix locking for c/s 24707:96987c324a4f debugging code
>>> On 10.05.12 at 11:26, Andrew Cooper <andrew.cooper3@citrix.com> wrote: > On 10/05/12 10:21, Jan Beulich wrote: >> Without this, dump_irqs() may try to acquire the lock the caller is >> currently holding. >> >> Signed-off-by: Jan Beulich <jbeulich@suse.com> > > With the proviso that this is patch will disappear when all (3 so far) > of these debugging patches disappear.That must be the goal, sure. Jan