Xen devel - Apr 2012 - Re: [Xen-staging] [qemu-upstream-unstable] xen_disk: when using AIO flush after the operation is completed

On Wed, 2012-04-11 at 14:55 +0100, patchbot@xen.org
wrote:
> commit 4db776322827f0930d53b9e162dc1c6600d918d0
> Author: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Date:   Fri Mar 23 11:37:25 2012 +0000
> 
>     xen_disk: when using AIO flush after the operation is completed
>     
>     If ioreq->postsync call bdrv_flush when the AIO operation is
actually
>     completed.
It''d be helpful if the commit message was amended to reference the
original upstream commit when backporting, like we do in the
xen-X.Y-testing trees and like is done in the Linux stable trees etc.

Ian.
>     
>     Signed-off-by: Stefano Stabellini
<stefano.stabellini@eu.citrix.com>
> ---
>  hw/xen_disk.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/xen_disk.c b/hw/xen_disk.c
> index 16c3e66..e9bbbf7 100644
> --- a/hw/xen_disk.c
> +++ b/hw/xen_disk.c
> @@ -398,6 +398,9 @@ static void qemu_aio_complete(void *opaque, int ret)
>      if (ioreq->aio_inflight > 0) {
>          return;
>      }
> +    if (ioreq->postsync) {
> +        bdrv_flush(ioreq->blkdev->bs);
> +    }
>  
>      ioreq->status = ioreq->aio_errors ? BLKIF_RSP_ERROR :
BLKIF_RSP_OKAY;
>      ioreq_unmap(ioreq);
> @@ -444,9 +447,6 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq)
>          goto err;
>      }
>  
> -    if (ioreq->postsync) {
> -        bdrv_flush(blkdev->bs); /* FIXME: aio_flush() ??? */
> -    }
>      qemu_aio_complete(ioreq, 0);
>  
>      return 0;
> --
> generated by git-patchbot for
/home/xen/git/staging/qemu-upstream-unstable.git
> 
> _______________________________________________
> Xen-staging mailing list
> Xen-staging@lists.xen.org
> http://lists.xensource.com/xen-staging

On Wed, 11 Apr 2012, Ian Campbell wrote:
> On Wed, 2012-04-11 at 14:55 +0100, patchbot@xen.org wrote:
> > commit 4db776322827f0930d53b9e162dc1c6600d918d0
> > Author: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Date:   Fri Mar 23 11:37:25 2012 +0000
> > 
> >     xen_disk: when using AIO flush after the operation is completed
> >     
> >     If ioreq->postsync call bdrv_flush when the AIO operation is
actually
> >     completed.
> 
> It''d be helpful if the commit message was amended to reference the
> original upstream commit when backporting, like we do in the
> xen-X.Y-testing trees and like is done in the Linux stable trees etc.
I''ll do.