Xen devel - Apr 2012 - checking d->grant_table against NULL?

gnttab_prepare_for_transfer() is the only place in grant_table.c where
such a check happens. Is this check superfluous (and hence slightly
misleading), or are similar checks missing throughout the file? I suppose
the former, given that domains get inserted to the hash table only after
grant_table_create() ran, and get removed again before calling
grant_table_destroy().

Thanks, Jan

On 11/04/2012 11:21, "Jan Beulich" <JBeulich@suse.com> wrote:
> gnttab_prepare_for_transfer() is the only place in grant_table.c where
> such a check happens. Is this check superfluous (and hence slightly
> misleading), or are similar checks missing throughout the file? I suppose
> the former, given that domains get inserted to the hash table only after
> grant_table_create() ran, and get removed again before calling
> grant_table_destroy().
I agree, I''m pretty sure it''s superfluous.
> Thanks, Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel