Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- net/core/skbuff.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 59a1ecb..d4e139e 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -264,7 +264,7 @@ struct sk_buff *build_skb(void *data) if (!skb) return NULL; - size = ksize(data) - SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); + size = SKB_WITH_OVERHEAD(ksize(data)); memset(skb, 0, offsetof(struct sk_buff, tail)); skb->truesize = SKB_TRUESIZE(size); -- 1.7.2.5
Eric Dumazet
2012-Apr-10 14:58 UTC
Re: [PATCH 02/10] net: Use SKB_WITH_OVERHEAD in build_skb
On Tue, 2012-04-10 at 15:26 +0100, Ian Campbell wrote:> Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > --- > net/core/skbuff.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index 59a1ecb..d4e139e 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -264,7 +264,7 @@ struct sk_buff *build_skb(void *data) > if (!skb) > return NULL; > > - size = ksize(data) - SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); > + size = SKB_WITH_OVERHEAD(ksize(data)); > > memset(skb, 0, offsetof(struct sk_buff, tail)); > skb->truesize = SKB_TRUESIZE(size);Well, why not ;) Acked-by: Eric Dumazet <eric.dumazet@gmail.com>