Xen devel - Apr 2012 - [PATCH v2] Autoconf: add variable for pass arbitrary options to qemu upstream

El 04/04/2012, a las 14:30, Fabio Fantoni escribió:
> Autoconf: add variable for pass arbitrary options to qemu upstream v2
> 
> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
(I''m gonna expand some of the pieces of the patch to comment them)

[...]

--- a/tools/configure	mer apr 04 14:36:16 2012 +0200
+++ b/tools/configure	mer apr 04 15:10:26 2012 +0200
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.67 for Xen Hypervisor 4.2.
+# Generated by GNU Autoconf 2.68 for Xen Hypervisor 4.2.

You should use autoconf 2.67 to update the configure script.

[...]

--- a/tools/configure.ac	mer apr 04 14:36:16 2012 +0200
+++ b/tools/configure.ac	mer apr 04 15:10:26 2012 +0200
@@ -44,6 +44,16 @@
 AX_ARG_DEFAULT_DISABLE([miniterm], [Enable miniterm])
 AX_ARG_DEFAULT_DISABLE([lomount], [Enable lomount])
 AX_ARG_DEFAULT_ENABLE([debug], [Disable debug build of tools])
+AC_ARG_ENABLE([qemuu-spice],
+[  --enable-qemuu-spice	Enable Spice build on qemu upstream],
+[qemuu_add_par+=" --enable-spice"])
+AC_ARG_ENABLE([qemuu-usbredir],
+[  --enable-qemuu-usbredir	Enable usb redirection build on qemu upstream],
+[qemuu_add_par+=" --enable-usb-redir"])
+AC_ARG_ENABLE([qemuu-debug],
+[  --enable-qemuu-debug	Enable debug build on qemu upstream],
+[qemuu_add_par+=" --enable-debug"])
+AC_SUBST(qemuu_add_par)

Why don''t you use AX_ARG_DEFAULT_DISABLE or AX_ARG_DEFAULT_ENABLE?

Take a look at:

http://xenbits.xen.org/hg/staging/xen-unstable.hg/rev/249b2eeeeae5

This is still not on the main repository, but it won''t take long, so I
suggest that you base your patch on top of this change.
> 
> Patch attached.
>
<autoconf_add_arbitrary_options_qemuu_v2.patch><smime.p7s>_______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Roger Pau Monne wrote
> 
> You should use autoconf 2.67 to update the configure script.
> 
> [...]
> 
> Why don''t you use AX_ARG_DEFAULT_DISABLE or AX_ARG_DEFAULT_ENABLE?
> 
On notebook I have Mint 12 and Precise, on testing server Wheezy, all with
autoconf 2.68, I''ll redo on other pc with old s.o.

About AX_ARG_DEFAULT_DISABLE or AX_ARG_DEFAULT_ENABLE do enable/disable and
export it, I not export but use it for bash command, I must need
AC_ARG_ENABLE or my mistake about?


--
View this message in context:
http://xen.1045712.n5.nabble.com/PATCH-v2-Autoconf-add-variable-for-pass-arbitrary-options-to-qemu-upstream-tp5617799p5622369.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

El 06/04/2012, a las 10:01, Fantu escribió:
> Roger Pau Monne wrote
>> 
>> You should use autoconf 2.67 to update the configure script.
>> 
>> [...]
>> 
>> Why don''t you use AX_ARG_DEFAULT_DISABLE or
AX_ARG_DEFAULT_ENABLE?
>> 
> On notebook I have Mint 12 and Precise, on testing server Wheezy, all with
> autoconf 2.68, I''ll redo on other pc with old s.o.
Don''t worry about the autoconf version, just send the patch without the
autoconf output and clearly state in the commit message that the maintainer
should rebuild the configure script to apply the change.
> About AX_ARG_DEFAULT_DISABLE or AX_ARG_DEFAULT_ENABLE do enable/disable and
> export it, I not export but use it for bash command, I must need
> AC_ARG_ENABLE or my mistake about?
You are basically doing the same thing that this macro does, and you are
"exporting" it using AC_SUBST, so you can write the result to the
config Makefile (Tools.mk). Instead of saving the whole parameter line you wish
to pass to Qemu, just save the options chosen by the user (e.g: QEMUDEBUG := y)
and generate the appropriate options to pass to Qemu from the tools Makefile.

Thanks for reply, I probably had already done:
http://xen.1045712.n5.nabble.com/PATCH-v3-Added-optional-build-configs-for-qemu-upstream-td5544305.html
but seem to be not good, or I not understand something?

--
View this message in context:
http://xen.1045712.n5.nabble.com/PATCH-v2-Autoconf-add-variable-for-pass-arbitrary-options-to-qemu-upstream-tp5617799p5629497.html
Sent from the Xen - Dev mailing list archive at Nabble.com.