Fabio Fantoni
2012-Mar-20 15:34 UTC
Autoconf: add variable for pass arbitrary options to qemu upstream
Ian Jackson
2012-Apr-03 14:11 UTC
Re: Autoconf: add variable for pass arbitrary options to qemu upstream
Fabio Fantoni writes ("[Xen-devel] Autoconf: add variable for pass
arbitrary options to qemu upstream"):> Autoconf: add variable for pass arbitrary options to qemu upstream
> diff -r 4e1d091d10d8 -r c86e026b8fa2 tools/configure.ac
> --- a/tools/configure.ac ven mar 16 15:24:25 2012 +0000
> +++ b/tools/configure.ac mar mar 20 13:57:09 2012 +0100
> @@ -66,6 +66,7 @@
> AC_ARG_VAR([XML], [Path to xml2-config tool])
> AC_ARG_VAR([BASH], [Path to bash shell])
> AC_ARG_VAR([XGETTEXT], [Path to xgetttext tool])
> +AC_ARG_VAR([QEMUU_ADD_PAR], [List of qemu upstream additionals build
parameters])
Wouldn''t this be better done with AC_ARG_ENABLE rather than some magic
environment variable ?
Ian.
Fantu
2012-Apr-03 14:22 UTC
Re: Autoconf: add variable for pass arbitrary options to qemu upstream
already done in past but change for your reply: http://xen.1045712.n5.nabble.com/PATCH-v3-Added-optional-build-configs-for-qemu-upstream-td5544305.html -- View this message in context: http://xen.1045712.n5.nabble.com/Autoconf-add-variable-for-pass-arbitrary-options-to-qemu-upstream-tp5580361p5615286.html Sent from the Xen - Dev mailing list archive at Nabble.com.
Ian Jackson
2012-Apr-03 14:37 UTC
Re: Autoconf: add variable for pass arbitrary options to qemu upstream
Fantu writes ("Re: [Xen-devel] Autoconf: add variable for pass arbitrary
options to qemu upstream"):> already done in past but change for your reply:
>
http://xen.1045712.n5.nabble.com/PATCH-v3-Added-optional-build-configs-for-qemu-upstream-td5544305.html
Your quoting of context is really deficient and makes it hard to see
what you''re talking about.
AFAICT this is a response to me saying:
] Wouldn''t this be better done with AC_ARG_ENABLE rather than some
magic
] environment variable ?
The earlier version you refer to introduced one corresponding
AC_ARG_ENABLE for each upstream qemu configure script option.
I think the right thing to do is to have one single AC_ARG_ENABLE
option that contains all the intended extra options for the qemu
configure script.
Ian.
Fantu
2012-Apr-04 14:50 UTC
Re: Autoconf: add variable for pass arbitrary options to qemu upstream
I posted new patch, may be okay now? http://xen.1045712.n5.nabble.com/PATCH-v2-Autoconf-add-variable-for-pass-arbitrary-options-to-qemu-upstream-td5617799.html -- View this message in context: http://xen.1045712.n5.nabble.com/Autoconf-add-variable-for-pass-arbitrary-options-to-qemu-upstream-tp5580361p5617989.html Sent from the Xen - Dev mailing list archive at Nabble.com.