Xen devel - Mar 2012 - [PATCH] libxl: log device model arguments to aid debugging

# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1332167041 0
# Node ID e10c4b937e8fa9159070584113e9378ca175f728
# Parent  5988e9761e13adb6d7baa38e192bdccf467fb94a
libxl: log device model arguments to aid debugging

At the moment the only easy way to get at these is to strace xl.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

diff -r 5988e9761e13 -r e10c4b937e8f tools/libxl/libxl_dm.c
--- a/tools/libxl/libxl_dm.c	Mon Mar 19 12:32:38 2012 +0000
+++ b/tools/libxl/libxl_dm.c	Mon Mar 19 14:24:01 2012 +0000
@@ -895,7 +895,7 @@ int libxl__create_device_model(libxl__gc
     char *path, *logfile;
     int logfile_w, null;
     int rc;
-    char **args;
+    char **args, **arg;
     libxl__spawner_starting buf_starting, *p;
     xs_transaction_t t;
     char *vm_path;
@@ -987,6 +987,10 @@ retry_transaction:
         }
     }
 
+    LIBXL__LOG(CTX, XTL_DEBUG, "Spawning device-model %s with
arguments:", dm);
+    for (arg = args; *arg; arg++)
+        LIBXL__LOG(CTX, XTL_DEBUG, "  %s", *arg);
+
     rc = libxl__spawn_spawn(gc, p->for_spawn, "device model",
                             libxl_spawner_record_pid, p);
     if (rc < 0)

Ian Campbell writes ("[Xen-devel] [PATCH] libxl: log device model arguments
to aid debugging"):
> libxl: log device model arguments to aid debugging
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>