Fabio Fantoni
2012-Mar-07 14:47 UTC
[PATCH v3] Added optional build configs for qemu upstream
Ian Jackson
2012-Mar-13 16:23 UTC
Re: [PATCH v3] Added optional build configs for qemu upstream
Fabio Fantoni writes ("[Xen-devel] [PATCH v3] Added optional build configs for qemu upstream"):> Added optional build configs for qemu upstream: > CONFIG_QEMUU_DEBUG to enable debug, disabled by default > CONFIG_QEMUU_SPICE to enable spice, setting by autoconf > Added to README requirements for spice-enabled qemu upstream build > (optional)I''m kind of uncomfortable with this because ultimately it will end up with us replicating all of the functionality from the qemu upstream configure script in our own. Perhaps it would be better to instead provide a generic option for our configure script which can be used to pass arbitrary options to the qemu one ? Obviously that means that perhaps failures will be deferred because the qemu configure script runs later but I think that''s a reasonable price to pay (in non-default scenarios) for not trying to have our configure script know about every qemu option. Thanks, Ian.