Jan Beulich
2012-Mar-07 09:41 UTC
[PATCH] passthrough: fix domain ref leak after 24888:71159fb049f2
As pointed out by Keir.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -580,6 +580,8 @@ int iommu_do_domctl(
printk(XENLOG_G_ERR
"XEN_DOMCTL_assign_device: get_domain_by_id()
failed\n");
ret = -EINVAL;
+ if ( d )
+ goto assign_device_out;
break;
}
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Keir Fraser
2012-Mar-07 09:44 UTC
Re: [PATCH] passthrough: fix domain ref leak after 24888:71159fb049f2
On 07/03/2012 09:41, "Jan Beulich" <JBeulich@suse.com> wrote:> As pointed out by Keir. > > Signed-off-by: Jan Beulich <jbeulich@suse.com>Acked-by: Keir Fraser <keir@xen.org>> --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -580,6 +580,8 @@ int iommu_do_domctl( > printk(XENLOG_G_ERR > "XEN_DOMCTL_assign_device: get_domain_by_id() failed\n"); > ret = -EINVAL; > + if ( d ) > + goto assign_device_out; > break; > } > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel