flight 12132 xen-unstable real [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/12132/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-i386-i386-xl 9 guest-start fail REGR. vs. 12130
test-amd64-amd64-xl 9 guest-start fail REGR. vs. 12130
test-amd64-amd64-xl-sedf 9 guest-start fail REGR. vs. 12130
test-amd64-i386-xl-credit2 9 guest-start fail REGR. vs. 12130
test-amd64-i386-xl-multivcpu 9 guest-start fail REGR. vs. 12130
test-amd64-i386-xl 9 guest-start fail REGR. vs. 12130
Regressions which are regarded as allowable (not blocking):
test-amd64-amd64-xl-sedf-pin 9 guest-start fail REGR. vs. 12130
test-amd64-i386-qemuu-rhel6hvm-amd 9 guest-start.2 fail like 12130
test-i386-i386-win 14 guest-start.2 fail like 12130
Tests which did not succeed, but are not blocking:
test-amd64-amd64-xl-pcipt-intel 9 guest-start fail never pass
test-amd64-i386-qemuu-rhel6hvm-intel 9 guest-start.2 fail never pass
test-amd64-i386-xend-winxpsp3 16 leak-check/check fail never pass
test-amd64-i386-rhel6hvm-amd 11 leak-check/check fail never pass
test-amd64-i386-rhel6hvm-intel 11 leak-check/check fail never pass
test-amd64-amd64-win 16 leak-check/check fail never pass
test-amd64-i386-win-vcpus1 16 leak-check/check fail never pass
test-amd64-i386-win 16 leak-check/check fail never pass
test-i386-i386-xl-qemuu-winxpsp3 7 windows-install fail never pass
test-amd64-amd64-xl-qemuu-winxpsp3 7 windows-install fail never pass
test-i386-i386-xl-win 13 guest-stop fail never pass
test-amd64-amd64-xl-win 13 guest-stop fail never pass
test-amd64-i386-xl-win7-amd64 13 guest-stop fail never pass
test-amd64-i386-xl-win-vcpus1 13 guest-stop fail never pass
test-amd64-amd64-xl-qemuu-win7-amd64 7 windows-install fail never pass
test-amd64-amd64-xl-winxpsp3 13 guest-stop fail never pass
test-i386-i386-xl-winxpsp3 13 guest-stop fail never pass
test-amd64-i386-xl-winxpsp3-vcpus1 13 guest-stop fail never pass
test-amd64-amd64-xl-win7-amd64 13 guest-stop fail never pass
version targeted for testing:
xen ed898c1d8088
baseline version:
xen d7fe4cd831a0
------------------------------------------------------------
People who touched revisions under test:
Daniel De Graaf <dgdegra@tycho.nsa.gov>
David Vrabel <david.vrabel@citrix.com>
George Dunlap <george.dunlap@eu.citrix.com>
Ian Campbell <ian.campbell@citrix.com>
Ian Jackson <ian.jackson@eu.citrix.com>
Jean Guyader <jean.guyader@eu.citrix.com>
Keir Fraser <keir@xen.org>
Olaf Hering <olaf@aepfle.de>
Roger Pau Monne <roger.pau@entel.upc.edu>
Tim Deegan <tim@xen.org>
------------------------------------------------------------
jobs:
build-amd64 pass
build-i386 pass
build-amd64-oldkern pass
build-i386-oldkern pass
build-amd64-pvops pass
build-i386-pvops pass
test-amd64-amd64-xl fail
test-amd64-i386-xl fail
test-i386-i386-xl fail
test-amd64-i386-rhel6hvm-amd fail
test-amd64-i386-qemuu-rhel6hvm-amd fail
test-amd64-amd64-xl-qemuu-win7-amd64 fail
test-amd64-amd64-xl-win7-amd64 fail
test-amd64-i386-xl-win7-amd64 fail
test-amd64-i386-xl-credit2 fail
test-amd64-amd64-xl-pcipt-intel fail
test-amd64-i386-rhel6hvm-intel fail
test-amd64-i386-qemuu-rhel6hvm-intel fail
test-amd64-i386-xl-multivcpu fail
test-amd64-amd64-pair pass
test-amd64-i386-pair pass
test-i386-i386-pair pass
test-amd64-amd64-xl-sedf-pin fail
test-amd64-amd64-pv pass
test-amd64-i386-pv pass
test-i386-i386-pv pass
test-amd64-amd64-xl-sedf fail
test-amd64-i386-win-vcpus1 fail
test-amd64-i386-xl-win-vcpus1 fail
test-amd64-i386-xl-winxpsp3-vcpus1 fail
test-amd64-amd64-win fail
test-amd64-i386-win fail
test-i386-i386-win fail
test-amd64-amd64-xl-win fail
test-i386-i386-xl-win fail
test-amd64-amd64-xl-qemuu-winxpsp3 fail
test-i386-i386-xl-qemuu-winxpsp3 fail
test-amd64-i386-xend-winxpsp3 fail
test-amd64-amd64-xl-winxpsp3 fail
test-i386-i386-xl-winxpsp3 fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
Not pushing.
(No revision log; it would be 515 lines long.)
On Fri, 2012-03-02 at 00:54 +0000, xen.org wrote:> flight 12132 xen-unstable real [real] > http://www.chiark.greenend.org.uk/~xensrcts/logs/12132/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-i386-i386-xl 9 guest-start fail REGR. vs. 12130 > test-amd64-amd64-xl 9 guest-start fail REGR. vs. 12130 > test-amd64-amd64-xl-sedf 9 guest-start fail REGR. vs. 12130 > test-amd64-i386-xl-credit2 9 guest-start fail REGR. vs. 12130 > test-amd64-i386-xl-multivcpu 9 guest-start fail REGR. vs. 12130 > test-amd64-i386-xl 9 guest-start fail REGR. vs. 12130I forgot to retest PV guests when adding "libxl: Select BIOS using libxl_domain_build_info_setdefaults" to my series. Setting info->u.hvm.bios when type == PV was clobbering info->u.pv.something. I''m starting to think we should make the union a struct and be damned the (tiny) waste of space. Either that or somehow hide/discourage direct use of b_info->u.* and instead provide an accessor of some sort. Anyway, the following fixes the immediate issue. I intend to commit shortly per the permission given by IanJ in <20302.18856.140051.792707@mariner.uk.xensource.com>. Ian. 8<-------------------------------------------- # HG changeset patch # User Ian Campbell <ian.campbell@citrix.com> # Date 1330678988 0 # Node ID 892bc1242d45b0a532b78833b633c68fc64a2906 # Parent 94eddab0b7cc2a0a4da71275efeea3a0962c125b libxl: only set b_info->u.hvm.bios if type if HVM This fixes a PV guest breakage causes by 24932:6eac4a1ee646 "libxl: Select BIOS using libxl_domain_build_info_setdefaults". I have also included a sanity check on b_info->type. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> diff -r 94eddab0b7cc -r 892bc1242d45 tools/libxl/libxl_create.c --- a/tools/libxl/libxl_create.c Thu Mar 01 14:49:58 2012 +0000 +++ b/tools/libxl/libxl_create.c Fri Mar 02 09:03:08 2012 +0000 @@ -74,28 +74,33 @@ int libxl__domain_create_info_setdefault int libxl__domain_build_info_setdefault(libxl__gc *gc, libxl_domain_build_info *b_info) { + if (!b_info->type || b_info->type == -1) + return ERROR_INVAL; + if (!b_info->device_model_version) b_info->device_model_version LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL; - if (!b_info->u.hvm.bios) + if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) { + if (!b_info->u.hvm.bios) + switch (b_info->device_model_version) { + case 1: b_info->u.hvm.bios = LIBXL_BIOS_TYPE_ROMBIOS; break; + case 2: b_info->u.hvm.bios = LIBXL_BIOS_TYPE_SEABIOS; break; + default:return ERROR_INVAL; + } + + /* Enforce BIOS<->Device Model version relationship */ switch (b_info->device_model_version) { - case 1: b_info->u.hvm.bios = LIBXL_BIOS_TYPE_ROMBIOS; break; - case 2: b_info->u.hvm.bios = LIBXL_BIOS_TYPE_SEABIOS; break; - default:return ERROR_INVAL; - } - - /* Enforce BIOS<->Device Model version relationship */ - switch (b_info->device_model_version) { - case 1: - if (b_info->u.hvm.bios != LIBXL_BIOS_TYPE_ROMBIOS) - return ERROR_INVAL; - break; - case 2: - if (b_info->u.hvm.bios == LIBXL_BIOS_TYPE_ROMBIOS) - return ERROR_INVAL; - break; - default:abort(); + case 1: + if (b_info->u.hvm.bios != LIBXL_BIOS_TYPE_ROMBIOS) + return ERROR_INVAL; + break; + case 2: + if (b_info->u.hvm.bios == LIBXL_BIOS_TYPE_ROMBIOS) + return ERROR_INVAL; + break; + default:abort(); + } } libxl_defbool_setdefault(&b_info->device_model_stubdomain, false);
Stefano Stabellini
2012-Mar-02 12:15 UTC
Re: [xen-unstable test] 12132: regressions - FAIL
On Fri, 2 Mar 2012, Ian Campbell wrote:> # HG changeset patch > # User Ian Campbell <ian.campbell@citrix.com> > # Date 1330678988 0 > # Node ID 892bc1242d45b0a532b78833b633c68fc64a2906 > # Parent 94eddab0b7cc2a0a4da71275efeea3a0962c125b > libxl: only set b_info->u.hvm.bios if type if HVM > > This fixes a PV guest breakage causes by 24932:6eac4a1ee646 "libxl: Select BIOS > using libxl_domain_build_info_setdefaults". > > I have also included a sanity check on b_info->type. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > diff -r 94eddab0b7cc -r 892bc1242d45 tools/libxl/libxl_create.c > --- a/tools/libxl/libxl_create.c Thu Mar 01 14:49:58 2012 +0000 > +++ b/tools/libxl/libxl_create.c Fri Mar 02 09:03:08 2012 +0000 > @@ -74,28 +74,33 @@ int libxl__domain_create_info_setdefault > int libxl__domain_build_info_setdefault(libxl__gc *gc, > libxl_domain_build_info *b_info) > { > + if (!b_info->type || b_info->type == -1) > + return ERROR_INVAL;Maybe the check should be: if (b_info->type != LIBXL_DOMAIN_TYPE_HVM && b_info->type != LIBXL_DOMAIN_TYPE_PV) return ERROR_INVAL; to make it more obvious that is a sanity check on an enum, rather than an int. The rest is fine.
On Fri, 2012-03-02 at 12:15 +0000, Stefano Stabellini wrote:> On Fri, 2 Mar 2012, Ian Campbell wrote: > > # HG changeset patch > > # User Ian Campbell <ian.campbell@citrix.com> > > # Date 1330678988 0 > > # Node ID 892bc1242d45b0a532b78833b633c68fc64a2906 > > # Parent 94eddab0b7cc2a0a4da71275efeea3a0962c125b > > libxl: only set b_info->u.hvm.bios if type if HVM > > > > This fixes a PV guest breakage causes by 24932:6eac4a1ee646 "libxl: Select BIOS > > using libxl_domain_build_info_setdefaults". > > > > I have also included a sanity check on b_info->type. > > > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > > > diff -r 94eddab0b7cc -r 892bc1242d45 tools/libxl/libxl_create.c > > --- a/tools/libxl/libxl_create.c Thu Mar 01 14:49:58 2012 +0000 > > +++ b/tools/libxl/libxl_create.c Fri Mar 02 09:03:08 2012 +0000 > > @@ -74,28 +74,33 @@ int libxl__domain_create_info_setdefault > > int libxl__domain_build_info_setdefault(libxl__gc *gc, > > libxl_domain_build_info *b_info) > > { > > + if (!b_info->type || b_info->type == -1) > > + return ERROR_INVAL; > > Maybe the check should be: > > if (b_info->type != LIBXL_DOMAIN_TYPE_HVM && > b_info->type != LIBXL_DOMAIN_TYPE_PV) > return ERROR_INVAL; > > to make it more obvious that is a sanity check on an enum, rather than > an int.Yes, that sounds like a good idea.> The rest is fine.Thanks, I''ll make the above change and commit with your ack. Ian.