Xen devel - Feb 2012 - [PATCH] tools/xenstore: workaround make 3.82 dependency flaw

# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1329927731 -3600
# Node ID 2d1ac43212fa31cedda2b8e4ed90bea1d63d229b
# Parent  0900b1c905f1d038aad58a2732fe2bad682149a3
tools/xenstore: workaround make 3.82 dependency flaw

After changeset 24767:28300f4562de build sometimes fails when make v3.82
as shipped with openSuSE 11.4/12.1 is used.

Add a workaround until the reason for the changed dependency handling in
make v3.82 is known.

The failure is a link error because the required libxenstore.so is not
created before init-xenstore-domain is about to be linked. All required
dependencies are listed, but they are ignored. So far the only way to
hide the error is to list init-xenstore-domain first in ALL_TARGETS.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

diff -r 0900b1c905f1 -r 2d1ac43212fa tools/xenstore/Makefile
--- a/tools/xenstore/Makefile
+++ b/tools/xenstore/Makefile
@@ -27,7 +27,7 @@ LIBXENSTORE := libxenstore.a
 xenstore xenstore-control: CFLAGS += -static
 endif
 
-ALL_TARGETS = libxenstore.so libxenstore.a clients xs_tdb_dump xenstored
init-xenstore-domain
+ALL_TARGETS = init-xenstore-domain libxenstore.a libxenstore.so clients
xs_tdb_dump xenstored
 
 ifdef CONFIG_STUBDOM
 CFLAGS += -DNO_SOCKETS=1

On Wed, 2012-02-22 at 16:24 +0000, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1329927731 -3600
> # Node ID 2d1ac43212fa31cedda2b8e4ed90bea1d63d229b
> # Parent  0900b1c905f1d038aad58a2732fe2bad682149a3
> tools/xenstore: workaround make 3.82 dependency flaw
> 
> After changeset 24767:28300f4562de build sometimes fails when make v3.82
> as shipped with openSuSE 11.4/12.1 is used.
Is there a corresponding bug report against make, either upstream or
SuSE?

I''d be much happier making an apparently random change as a workaround
if someone had suggest some reason why it should be the case.
> 
> Add a workaround until the reason for the changed dependency handling in
> make v3.82 is known.
> 
> The failure is a link error because the required libxenstore.so is not
> created before init-xenstore-domain is about to be linked. All required
> dependencies are listed, but they are ignored. So far the only way to
> hide the error is to list init-xenstore-domain first in ALL_TARGETS.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> diff -r 0900b1c905f1 -r 2d1ac43212fa tools/xenstore/Makefile
> --- a/tools/xenstore/Makefile
> +++ b/tools/xenstore/Makefile
> @@ -27,7 +27,7 @@ LIBXENSTORE := libxenstore.a
>  xenstore xenstore-control: CFLAGS += -static
>  endif
>  
> -ALL_TARGETS = libxenstore.so libxenstore.a clients xs_tdb_dump xenstored
init-xenstore-domain
> +ALL_TARGETS = init-xenstore-domain libxenstore.a libxenstore.so clients
xs_tdb_dump xenstored
>  
>  ifdef CONFIG_STUBDOM
>  CFLAGS += -DNO_SOCKETS=1
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

On Thu, Feb 23, Ian Campbell wrote:
> On Wed, 2012-02-22 at 16:24 +0000, Olaf Hering wrote:
> > After changeset 24767:28300f4562de build sometimes fails when make
v3.82
> > as shipped with openSuSE 11.4/12.1 is used.
> 
> Is there a corresponding bug report against make, either upstream or
> SuSE?
> 
> I''d be much happier making an apparently random change as a
workaround
> if someone had suggest some reason why it should be the case.
I asked upstream yesterday, but got no response so far.

The weird thing is that even libxenstore.so.$(MAJOR).$(MINOR) as a
prereq is ignored.

Olaf

Olaf Hering writes ("Re: [Xen-devel] [PATCH] tools/xenstore: workaround
make 3.82 dependency flaw"):
> On Thu, Feb 23, Ian Campbell wrote:
> > Is there a corresponding bug report against make, either upstream or
> > SuSE?
> > 
> > I''d be much happier making an apparently random change as a
workaround
> > if someone had suggest some reason why it should be the case.
Quite.
> I asked upstream yesterday, but got no response so far.
Have you filed a formal bug report anywhere ?  Can you repro the
problem with a smaller makefile ?

Ian.

On Thu, Mar 01, Ian Jackson wrote:
> > I asked upstream yesterday, but got no response so far.
> 
> Have you filed a formal bug report anywhere ?  Can you repro the
> problem with a smaller makefile ?
I will work on that.

Olaf