Wei Liu
2012-Feb-22 15:00 UTC
[PATCH] Add gtags target for xen/Makefile. Also update .hgignore.
# HG changeset patch # User Wei Liu <wei.liu2@citrix.com> # Date 1329922671 0 # Node ID bb2986677df84b9709a60aea7e70ffd9f9e23f76 # Parent d433a9cb0089683b8f75458807c5437341f2cdcc Add gtags target for xen/Makefile. Also update .hgignore. Signed-off-by: Wei Liu <wei.liu2@citrix.com> diff --git a/.hgignore b/.hgignore --- a/.hgignore +++ b/.hgignore @@ -23,6 +23,7 @@ ^\.config$ ^\.pc (^|/)(tags|TAGS)$ +(^|/)(GTAGS|GPATH|GSYMS|GRTAGS|gtags.*)$ ^build-.*$ ^dist/.*$ ^docs/.*\.aux$ diff --git a/xen/Makefile b/xen/Makefile --- a/xen/Makefile +++ b/xen/Makefile @@ -20,8 +20,8 @@ default: build .PHONY: dist dist: install -.PHONY: build install clean distclean cscope TAGS tags MAP -build install debug clean distclean cscope TAGS tags MAP:: +.PHONY: build install clean distclean cscope TAGS tags MAP gtags +build install debug clean distclean cscope TAGS tags MAP gtags:: $(MAKE) -f Rules.mk _$@ .PHONY: _build @@ -67,7 +67,7 @@ _clean: delete-unfresh-files .PHONY: _distclean _distclean: clean - rm -f tags TAGS cscope.files cscope.in.out cscope.out cscope.po.out + rm -f tags TAGS cscope.files cscope.in.out cscope.out cscope.po.out gtags.files GTAGS GPATH GRTAGS GSYMS $(TARGET).gz: $(TARGET) gzip -f -9 < $< > $@.new @@ -159,6 +159,12 @@ _tags: $(call set_exuberant_flags,ctags); \ $(all_sources) | xargs ctags $$exuberant_flags -a +.PHONY: _gtags +_gtags: + set -e; rm -f GTAGS GSYMS GPATH GRTAGS + $(all_sources) > gtags.files + gtags -f gtags.files + .PHONY: _cscope _cscope: $(all_sources) > cscope.files
Tim Deegan
2012-Feb-23 10:45 UTC
Re: [PATCH] Add gtags target for xen/Makefile. Also update .hgignore.
At 15:00 +0000 on 22 Feb (1329922812), Wei Liu wrote:> +.PHONY: _gtags > +_gtags: > + set -e; rm -f GTAGS GSYMS GPATH GRTAGS > + $(all_sources) > gtags.files > + gtags -f gtags.files > +Minor nit: the gtags manpage suggests that ''$(all_sources) | gtags -f -'' would work, and save us from tracking another file. Tim.
Wei Liu
2012-Feb-23 12:27 UTC
Re: [PATCH] Add gtags target for xen/Makefile. Also update .hgignore.
On Thu, 2012-02-23 at 10:45 +0000, Tim Deegan wrote:> At 15:00 +0000 on 22 Feb (1329922812), Wei Liu wrote: > > +.PHONY: _gtags > > +_gtags: > > + set -e; rm -f GTAGS GSYMS GPATH GRTAGS > > + $(all_sources) > gtags.files > > + gtags -f gtags.files > > + > > Minor nit: the gtags manpage suggests that ''$(all_sources) | gtags -f -'' > would work, and save us from tracking another file. > > Tim.----8<-------- # HG changeset patch # User Wei Liu <wei.liu2@citrix.com> # Date 1330000012 0 # Node ID 0f817275c625527d560ebf9ec82c5037a502d3d5 # Parent d433a9cb0089683b8f75458807c5437341f2cdcc Add gtags target for xen/Makefile. Also update .hgignore. Signed-off-by: Wei Liu <wei.liu2@citrix.com> diff --git a/.hgignore b/.hgignore --- a/.hgignore +++ b/.hgignore @@ -23,6 +23,7 @@ ^\.config$ ^\.pc (^|/)(tags|TAGS)$ +(^|/)(GTAGS|GPATH|GSYMS|GRTAGS)$ ^build-.*$ ^dist/.*$ ^docs/.*\.aux$ diff --git a/xen/Makefile b/xen/Makefile --- a/xen/Makefile +++ b/xen/Makefile @@ -20,8 +20,8 @@ default: build .PHONY: dist dist: install -.PHONY: build install clean distclean cscope TAGS tags MAP -build install debug clean distclean cscope TAGS tags MAP:: +.PHONY: build install clean distclean cscope TAGS tags MAP gtags +build install debug clean distclean cscope TAGS tags MAP gtags:: $(MAKE) -f Rules.mk _$@ .PHONY: _build @@ -67,7 +67,7 @@ _clean: delete-unfresh-files .PHONY: _distclean _distclean: clean - rm -f tags TAGS cscope.files cscope.in.out cscope.out cscope.po.out + rm -f tags TAGS cscope.files cscope.in.out cscope.out cscope.po.out GTAGS GPATH GRTAGS GSYMS $(TARGET).gz: $(TARGET) gzip -f -9 < $< > $@.new @@ -159,6 +159,11 @@ _tags: $(call set_exuberant_flags,ctags); \ $(all_sources) | xargs ctags $$exuberant_flags -a +.PHONY: _gtags +_gtags: + set -e; rm -f GTAGS GSYMS GPATH GRTAGS + $(all_sources) | gtags -f - + .PHONY: _cscope _cscope: $(all_sources) > cscope.files
Ian Jackson
2012-Mar-01 18:00 UTC
Re: [PATCH] Add gtags target for xen/Makefile. Also update .hgignore.
Wei Liu writes ("Re: [Xen-devel] [PATCH] Add gtags target for xen/Makefile.
Also update .hgignore."):> Add gtags target for xen/Makefile. Also update .hgignore.
This patch has been wordwrapped I''m afraid.
Ian.
Wei Liu
2012-Mar-01 18:43 UTC
Re: [PATCH] Add gtags target for xen/Makefile. Also update .hgignore.
On Thu, 2012-03-01 at 18:00 +0000, Ian Jackson wrote:> Wei Liu writes ("Re: [Xen-devel] [PATCH] Add gtags target for xen/Makefile. Also update .hgignore."): > > Add gtags target for xen/Makefile. Also update .hgignore. > > This patch has been wordwrapped I''m afraid. > > Ian.My fault. Here is the correct one. -----8<------ exporting patch: # HG changeset patch # User Wei Liu <wei.liu2@citrix.com> # Date 1330627381 0 # Node ID 6d2b5bac876f10ab59d8b98b557bb3a6173399a9 # Parent be6bd7febd33d5dd21cbbeb180e6907cd6038a77 Add gtags target for xen/Makefile. Also update .hgignore. Signed-off-by: Wei Liu <wei.liu2@citrix.com> diff --git a/.hgignore b/.hgignore --- a/.hgignore +++ b/.hgignore @@ -23,6 +23,7 @@ ^\.config$ ^\.pc (^|/)(tags|TAGS)$ +(^|/)(GTAGS|GPATH|GSYMS|GRTAGS)$ ^build-.*$ ^dist/.*$ ^docs/.*\.aux$ diff --git a/xen/Makefile b/xen/Makefile --- a/xen/Makefile +++ b/xen/Makefile @@ -20,8 +20,8 @@ default: build .PHONY: dist dist: install -.PHONY: build install clean distclean cscope TAGS tags MAP -build install debug clean distclean cscope TAGS tags MAP:: +.PHONY: build install clean distclean cscope TAGS tags MAP gtags +build install debug clean distclean cscope TAGS tags MAP gtags:: $(MAKE) -f Rules.mk _$@ .PHONY: _build @@ -67,7 +67,7 @@ _clean: delete-unfresh-files .PHONY: _distclean _distclean: clean - rm -f tags TAGS cscope.files cscope.in.out cscope.out cscope.po.out + rm -f tags TAGS cscope.files cscope.in.out cscope.out cscope.po.out GTAGS GPATH GRTAGS GSYMS $(TARGET).gz: $(TARGET) gzip -f -9 < $< > $@.new @@ -159,6 +159,11 @@ _tags: $(call set_exuberant_flags,ctags); \ $(all_sources) | xargs ctags $$exuberant_flags -a +.PHONY: _gtags +_gtags: + set -e; rm -f GTAGS GSYMS GPATH GRTAGS + $(all_sources) | gtags -f - + .PHONY: _cscope _cscope: $(all_sources) > cscope.files
Ian Jackson
2012-Mar-01 19:01 UTC
Re: [PATCH] Add gtags target for xen/Makefile. Also update .hgignore.
Wei Liu writes ("Re: [Xen-devel] [PATCH] Add gtags target for xen/Makefile.
Also update .hgignore."):> Add gtags target for xen/Makefile. Also update .hgignore.
Looks plausible to me.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>