Ian Jackson
2012-Feb-15 16:10 UTC
[PATCH] oxenstored: Fix spelling of "persistent" config variable
commit 4e1aba5e529e1d01b02d04546496001e0da452cd
Author: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Wed Feb 15 16:09:18 2012 +0000
oxenstored: Fix spelling of "persistent" config variable
Change "persistant" to "persistent", in the code and the
example/default config.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
diff --git a/tools/ocaml/xenstored/oxenstored.conf
b/tools/ocaml/xenstored/oxenstored.conf
index 9616d32..13ee770 100644
--- a/tools/ocaml/xenstored/oxenstored.conf
+++ b/tools/ocaml/xenstored/oxenstored.conf
@@ -20,7 +20,7 @@ quota-maxwatch = 100
quota-transaction = 10
# Activate filed base backend
-persistant = false
+persistent = false
# Xenstored logs
# xenstored-log-file = /var/log/xenstored.log
diff --git a/tools/ocaml/xenstored/xenstored.ml
b/tools/ocaml/xenstored/xenstored.ml
index fdea41a..64cc106 100644
--- a/tools/ocaml/xenstored/xenstored.ml
+++ b/tools/ocaml/xenstored/xenstored.ml
@@ -86,7 +86,7 @@ let parse_config filename ("quota-maxentity",
Config.Set_int Quota.maxent);
("quota-maxsize", Config.Set_int Quota.maxsize);
("test-eagain", Config.Set_bool Transaction.test_eagain);
- ("persistant", Config.Set_bool Disk.enable);
+ ("persistent", Config.Set_bool Disk.enable);
("xenstored-log-file", Config.Set_string
Logging.xenstored_log_file);
("xenstored-log-level", Config.String
(fun s -> Logging.xenstored_log_level := Logging.level_of_string s));
Ian Campbell
2012-Feb-15 16:25 UTC
Re: [PATCH] oxenstored: Fix spelling of "persistent" config variable
On Wed, 2012-02-15 at 16:10 +0000, Ian Jackson wrote:> commit 4e1aba5e529e1d01b02d04546496001e0da452cd > Author: Ian Jackson <ian.jackson@eu.citrix.com> > Date: Wed Feb 15 16:09:18 2012 +0000 > > oxenstored: Fix spelling of "persistent" config variable > > Change "persistant" to "persistent", in the code and the > example/default config. > > Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>Acked-by: Ian Campbell <ian.campbell@citrix.com>> > diff --git a/tools/ocaml/xenstored/oxenstored.conf b/tools/ocaml/xenstored/oxenstored.conf > index 9616d32..13ee770 100644 > --- a/tools/ocaml/xenstored/oxenstored.conf > +++ b/tools/ocaml/xenstored/oxenstored.conf > @@ -20,7 +20,7 @@ quota-maxwatch = 100 > quota-transaction = 10 > > # Activate filed base backend > -persistant = false > +persistent = false > > # Xenstored logs > # xenstored-log-file = /var/log/xenstored.log > diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml > index fdea41a..64cc106 100644 > --- a/tools/ocaml/xenstored/xenstored.ml > +++ b/tools/ocaml/xenstored/xenstored.ml > @@ -86,7 +86,7 @@ let parse_config filename > ("quota-maxentity", Config.Set_int Quota.maxent); > ("quota-maxsize", Config.Set_int Quota.maxsize); > ("test-eagain", Config.Set_bool Transaction.test_eagain); > - ("persistant", Config.Set_bool Disk.enable); > + ("persistent", Config.Set_bool Disk.enable); > ("xenstored-log-file", Config.Set_string Logging.xenstored_log_file); > ("xenstored-log-level", Config.String > (fun s -> Logging.xenstored_log_level := Logging.level_of_string s)); > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel
Ian Jackson
2012-Feb-20 18:29 UTC
Re: [PATCH] oxenstored: Fix spelling of "persistent" config variable
Ian Campbell writes ("Re: [Xen-devel] [PATCH] oxenstored: Fix spelling of
"persistent" config variable"):> On Wed, 2012-02-15 at 16:10 +0000, Ian Jackson wrote:
> > commit 4e1aba5e529e1d01b02d04546496001e0da452cd
> > Author: Ian Jackson <ian.jackson@eu.citrix.com>
> > Date: Wed Feb 15 16:09:18 2012 +0000
> >
> > oxenstored: Fix spelling of "persistent" config variable
> >
> > Change "persistant" to "persistent", in the
code and the
> > example/default config.
> >
> > Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
Anil Madhavapeddy
2012-Feb-20 18:36 UTC
Re: [PATCH] oxenstored: Fix spelling of "persistent" config variable
Shouldn''t you also accept "persistant", so that older configs don''t just break on upgrade? -anil On 15 Feb 2012, at 16:10, Ian Jackson wrote:> commit 4e1aba5e529e1d01b02d04546496001e0da452cd > Author: Ian Jackson <ian.jackson@eu.citrix.com> > Date: Wed Feb 15 16:09:18 2012 +0000 > > oxenstored: Fix spelling of "persistent" config variable > > Change "persistant" to "persistent", in the code and the > example/default config. > > Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> > > diff --git a/tools/ocaml/xenstored/oxenstored.conf b/tools/ocaml/xenstored/oxenstored.conf > index 9616d32..13ee770 100644 > --- a/tools/ocaml/xenstored/oxenstored.conf > +++ b/tools/ocaml/xenstored/oxenstored.conf > @@ -20,7 +20,7 @@ quota-maxwatch = 100 > quota-transaction = 10 > > # Activate filed base backend > -persistant = false > +persistent = false > > # Xenstored logs > # xenstored-log-file = /var/log/xenstored.log > diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml > index fdea41a..64cc106 100644 > --- a/tools/ocaml/xenstored/xenstored.ml > +++ b/tools/ocaml/xenstored/xenstored.ml > @@ -86,7 +86,7 @@ let parse_config filename > ("quota-maxentity", Config.Set_int Quota.maxent); > ("quota-maxsize", Config.Set_int Quota.maxsize); > ("test-eagain", Config.Set_bool Transaction.test_eagain); > - ("persistant", Config.Set_bool Disk.enable); > + ("persistent", Config.Set_bool Disk.enable); > ("xenstored-log-file", Config.Set_string Logging.xenstored_log_file); > ("xenstored-log-level", Config.String > (fun s -> Logging.xenstored_log_level := Logging.level_of_string s)); > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >
Ian Jackson
2012-Feb-20 18:40 UTC
Re: [PATCH] oxenstored: Fix spelling of "persistent" config variable
Anil Madhavapeddy writes ("Re: [Xen-devel] [PATCH] oxenstored: Fix spelling
of "persistent" config variable"):> Shouldn''t you also accept "persistant", so that older
configs don''t just break on upgrade?
I don''t think there can be many older configs TBH. oxenstored
hasn''t
been available in xen upstream very long.
But if you would like to send a patch to do that I''d take it.
Ian.