hongkaixing@huawei.com
2012-Feb-09 08:59 UTC
[PATCH] xenpaging:add the dealing of MEM_EVENT_FLAG_EVICT_FAIL request in
# HG changeset patch # User h00166998@h00166998.china.huawei.com # Date 1328777881 -28800 # Node ID 68eae0b487aef8349f168518f56264ce61afb0a1 # Parent 9f4640e40d4f31563885427a5a8d9eae2e110514 xenpaging:add the dealing of MEM_EVENT_FLAG_EVICT_FAIL request in tools/xenpaging If a page is nominated but not evicted,then dom0 accesses the page,it will change the page''s p2mt to be p2m_ram_paging_in,and the req.flags is MEM_EVENT_FLAG_EVICT_FAIL;so it will fail in p2m_mem_paging_evict() because of the p2mt;and paging->num_paged_out will not increase in this case;After the paging process is terminated, the p2mt p2m_ram_paging_in still remains in p2m table.Once domU accesses the nominated page,it will result in BSOD or vm''stuck. The patch adds the dealing of this request to resume the page before xenpaging is ended. Signed-off-byhongkaixing<hongkaixing@huawei.com>,shizhen<bicky.shi@huawei.com> diff -r 9f4640e40d4f -r 68eae0b487ae tools/xenpaging/xenpaging.c --- a/tools/xenpaging/xenpaging.c Thu Feb 09 16:50:52 2012 +0800 +++ b/tools/xenpaging/xenpaging.c Thu Feb 09 16:58:01 2012 +0800 @@ -911,7 +911,7 @@ !!(req.flags & MEM_EVENT_FLAG_EVICT_FAIL) ); /* Tell Xen to resume the vcpu */ - if ( req.flags & MEM_EVENT_FLAG_VCPU_PAUSED ) + if (( req.flags & MEM_EVENT_FLAG_VCPU_PAUSED ) || ( req.flags & MEM_EVENT_FLAG_EVICT_FAIL )) { /* Prepare the response */ rsp.gfn = req.gfn; --===============1224695418168661668=Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1224695418168661668==--
Olaf Hering
2012-Feb-09 09:54 UTC
Re: [PATCH] xenpaging:add the dealing of MEM_EVENT_FLAG_EVICT_FAIL request in
On Thu, Feb 09, hongkaixing@huawei.com wrote:> xenpaging:add the dealing of MEM_EVENT_FLAG_EVICT_FAIL request in > tools/xenpaging > > If a page is nominated but not evicted,then dom0 accesses the page,it > will change the page''s p2mt to be p2m_ram_paging_in,and the req.flags is > MEM_EVENT_FLAG_EVICT_FAIL;so it will fail in p2m_mem_paging_evict() because > of the p2mt;and paging->num_paged_out will not increase in this case;After > the paging process is terminated, the p2mt p2m_ram_paging_in still remains > in p2m table.Once domU accesses the nominated page,it will result in BSOD > or vm''stuck. > The patch adds the dealing of this request to resume the page before xenpaging > is ended.This can happen if p2m_mem_paging_populate() was called by a foreign domain. In this case MEM_EVENT_FLAG_VCPU_PAUSED is not set and xenpaging will not sent a response. And in this case the ring is in an inconsistent state anyway, new requests cant be added, I think. Acked-by: Olaf Hering <olaf@aepfle.de>> Signed-off-by??hongkaixing<hongkaixing@huawei.com>,shizhen<bicky.shi@huawei.com> > > diff -r 9f4640e40d4f -r 68eae0b487ae tools/xenpaging/xenpaging.c > --- a/tools/xenpaging/xenpaging.c Thu Feb 09 16:50:52 2012 +0800 > +++ b/tools/xenpaging/xenpaging.c Thu Feb 09 16:58:01 2012 +0800 > @@ -911,7 +911,7 @@ > !!(req.flags & MEM_EVENT_FLAG_EVICT_FAIL) ); > > /* Tell Xen to resume the vcpu */ > - if ( req.flags & MEM_EVENT_FLAG_VCPU_PAUSED ) > + if (( req.flags & MEM_EVENT_FLAG_VCPU_PAUSED ) || ( req.flags & MEM_EVENT_FLAG_EVICT_FAIL )) > { > /* Prepare the response */ > rsp.gfn = req.gfn;
Ian Jackson
2012-Feb-09 18:48 UTC
Re: [PATCH] xenpaging:add the dealing of MEM_EVENT_FLAG_EVICT_FAIL request in [and 1 more messages]
hongkaixing@huawei.com writes ("[Xen-devel] [PATCH] xenpaging:add the dealing of MEM_EVENT_FLAG_EVICT_FAIL request in"):> xenpaging:add the dealing of MEM_EVENT_FLAG_EVICT_FAIL request in > tools/xenpagingThanks, and to Olaf for the ack. Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
Apparently Analagous Threads
- [PATCH 0 of 2] xenpaging:speed up page-in
- [PATCH] x86/mm: Make sure the event channel is released accurately
- Some problems about xenpaging
- [PATCH] xenpaging:add a new array to speed up page-in in xenpaging
- [PATCH 0 of 2] v2: memshare/xenpaging/xen-access fixes for xen-unstable