thr3ads.net - Xen devel - [PATCH] Tools: build tests [Jan 2012]

If this information is useful, please help other people find it:
Share via:

Andres Lagar-Cavilla

2012-Jan-27 21:21 UTC

[PATCH] Tools: build tests

Config.mk            |   1 +
 tools/Makefile       |   1 +
 tools/tests/Makefile |  20 ++++++++++++++++++++
 3 files changed, 22 insertions(+), 0 deletions(-)


Build tests as part of the tools build.

It is enabled with CONFIG_TESTS in Config.mk

Currently disabled build of tests/regressions and tests/xen-access (in 32 bit
mode) as they fail.

Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>

diff -r 2c6ff08e8b5b -r 7d62108a8936 Config.mk
--- a/Config.mk
+++ b/Config.mk
@@ -240,6 +240,7 @@ OCAML_TOOLS        ?= y
 CONFIG_MINITERM    ?= n
 CONFIG_LOMOUNT     ?= n
 CONFIG_SYSTEM_LIBAIO ?= y
+CONFIG_TESTS       ?= y
 
 ifeq ($(OCAML_TOOLS),y)
 OCAML_TOOLS := $(shell ocamlopt -v > /dev/null 2>&1 && echo
"y" || echo "n")
diff -r 2c6ff08e8b5b -r 7d62108a8936 tools/Makefile
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -45,6 +45,7 @@ SUBDIRS-y += remus
 SUBDIRS-$(CONFIG_X86) += xenpaging
 SUBDIRS-$(CONFIG_X86) += debugger/gdbsx
 SUBDIRS-$(CONFIG_X86) += debugger/kdd
+SUBDIRS-$(CONFIG_TESTS) += tests
 
 # These don''t cross-compile
 ifeq ($(XEN_COMPILE_ARCH),$(XEN_TARGET_ARCH))
diff -r 2c6ff08e8b5b -r 7d62108a8936 tools/tests/Makefile
--- /dev/null
+++ b/tools/tests/Makefile
@@ -0,0 +1,20 @@
+XEN_ROOT = $(CURDIR)/../..
+include $(XEN_ROOT)/tools/Rules.mk
+
+CFLAGS  += $(CFLAGS_libxenctrl)
+LDLIBS += $(LDLIBS_libxenctrl)
+
+SUBDIRS-y :+SUBDIRS-y += mce-test
+SUBDIRS-y += mem-sharing
+ifeq ($(XEN_TARGET_ARCH),__fixme__)
+SUBDIRS-y += regression
+endif
+SUBDIRS-y += x86_emulator
+ifneq ($(XEN_TARGET_ARCH),x86_32)
+SUBDIRS-y += xen-access
+endif
+
+.PHONY: all clean install
+all clean install: %: subdirs-%
+

Ian Campbell

2012-Feb-01 09:48 UTC

head link

Re: [PATCH] Tools: build tests

On Fri, 2012-01-27 at 21:21 +0000, Andres Lagar-Cavilla
wrote:> Config.mk            |   1 +
>  tools/Makefile       |   1 +
>  tools/tests/Makefile |  20 ++++++++++++++++++++
>  3 files changed, 22 insertions(+), 0 deletions(-)
> 
> 
> Build tests as part of the tools build.
> 
> It is enabled with CONFIG_TESTS in Config.mk
> 
> Currently disabled build of tests/regressions and tests/xen-access (in 32
bit
> mode) as they fail.
> 
> Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Ack on the idea but the actual implementation fails for me:

make[1]: Entering directory
`/local/scratch/ianc/devel/xen-unstable.hg/tools''
make -C tests install
make[2]: Entering directory
`/local/scratch/ianc/devel/xen-unstable.hg/tools/tests''
make[3]: Entering directory
`/local/scratch/ianc/devel/xen-unstable.hg/tools/tests''
make -C mce-test install
make[4]: Entering directory
`/local/scratch/ianc/devel/xen-unstable.hg/tools/tests/mce-test''
make[4]: *** No rule to make target `install''.  Stop.

Grep seems to suggest that most of the tools/tests dirs are missing an
install target, mce-test just happens to be first.

I''m not sure if it makes sense to install any of these test things?
Depending on the answer we could either hobble the install target in
tools/tests/Makefile or add an install target to tools/tests/*/Makefile
which is a nop or an actual install target as appropriate.

Ian.

Andres Lagar-Cavilla

2012-Feb-01 15:58 UTC

head link

Re: [PATCH] Tools: build tests

> On Fri, 2012-01-27 at 21:21 +0000, Andres Lagar-Cavilla wrote:
>> Config.mk            |   1 +
>>  tools/Makefile       |   1 +
>>  tools/tests/Makefile |  20 ++++++++++++++++++++
>>  3 files changed, 22 insertions(+), 0 deletions(-)
>>
>>
>> Build tests as part of the tools build.
>>
>> It is enabled with CONFIG_TESTS in Config.mk
>>
>> Currently disabled build of tests/regressions and tests/xen-access (in
>> 32 bit
>> mode) as they fail.
>>
>> Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
>
> Ack on the idea but the actual implementation fails for me:
>
> make[1]: Entering directory
> `/local/scratch/ianc/devel/xen-unstable.hg/tools''
> make -C tests install
> make[2]: Entering directory
> `/local/scratch/ianc/devel/xen-unstable.hg/tools/tests''
> make[3]: Entering directory
> `/local/scratch/ianc/devel/xen-unstable.hg/tools/tests''
> make -C mce-test install
> make[4]: Entering directory
> `/local/scratch/ianc/devel/xen-unstable.hg/tools/tests/mce-test''
> make[4]: *** No rule to make target `install''.  Stop.
>
> Grep seems to suggest that most of the tools/tests dirs are missing an
> install target, mce-test just happens to be first.
>
> I''m not sure if it makes sense to install any of these test
things?
> Depending on the answer we could either hobble the install target in
> tools/tests/Makefile or add an install target to tools/tests/*/Makefile
> which is a nop or an actual install target as appropriate.
Vote is to hobble install target. Refresh of patch pasted below (also
added distclean).
Thanks!
Andres

# HG changeset patch
# Parent efc0802acb87aec9a4d578e741e209bef8c6fe52
Tools: build tests

Build tests as part of the tools build.

It is enabled with CONFIG_TESTS in Config.mk

Currently disabled build of tests/regressions and tests/xen-access (in 32
bit mode) as they fail.

Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>

diff -r efc0802acb87 Config.mk
--- a/Config.mk
+++ b/Config.mk
@@ -238,6 +238,7 @@ OCAML_TOOLS        ?= y
 CONFIG_MINITERM    ?= n
 CONFIG_LOMOUNT     ?= n
 CONFIG_SYSTEM_LIBAIO ?= y
+CONFIG_TESTS       ?= y

 ifeq ($(OCAML_TOOLS),y)
 OCAML_TOOLS := $(shell ocamlopt -v > /dev/null 2>&1 && echo
"y" || echo "n")
diff -r efc0802acb87 tools/Makefile
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -45,6 +45,7 @@ SUBDIRS-y += remus
 SUBDIRS-$(CONFIG_X86) += xenpaging
 SUBDIRS-$(CONFIG_X86) += debugger/gdbsx
 SUBDIRS-$(CONFIG_X86) += debugger/kdd
+SUBDIRS-$(CONFIG_TESTS) += tests

 # These don''t cross-compile
 ifeq ($(XEN_COMPILE_ARCH),$(XEN_TARGET_ARCH))
diff -r efc0802acb87 tools/tests/Makefile
--- /dev/null
+++ b/tools/tests/Makefile
@@ -0,0 +1,21 @@
+XEN_ROOT = $(CURDIR)/../..
+include $(XEN_ROOT)/tools/Rules.mk
+
+CFLAGS  += $(CFLAGS_libxenctrl)
+LDLIBS += $(LDLIBS_libxenctrl)
+
+SUBDIRS-y :+SUBDIRS-y += mce-test
+SUBDIRS-y += mem-sharing
+ifeq ($(XEN_TARGET_ARCH),__fixme__)
+SUBDIRS-y += regression
+endif
+SUBDIRS-y += x86_emulator
+ifneq ($(XEN_TARGET_ARCH),x86_32)
+SUBDIRS-y += xen-access
+endif
+
+.PHONY: all clean install distclean
+all clean distclean: %: subdirs-%
+
+install:


>
> Ian.
>
>
>

Ian Campbell

2012-Feb-01 16:14 UTC

head link

Re: [PATCH] Tools: build tests

On Wed, 2012-02-01 at 15:58 +0000, Andres Lagar-Cavilla
wrote:> > On Fri, 2012-01-27 at 21:21 +0000, Andres Lagar-Cavilla wrote:
> >> Config.mk            |   1 +
> >>  tools/Makefile       |   1 +
> >>  tools/tests/Makefile |  20 ++++++++++++++++++++
> >>  3 files changed, 22 insertions(+), 0 deletions(-)
> >>
> >>
> >> Build tests as part of the tools build.
> >>
> >> It is enabled with CONFIG_TESTS in Config.mk
> >>
> >> Currently disabled build of tests/regressions and tests/xen-access
(in
> >> 32 bit
> >> mode) as they fail.
> >>
> >> Signed-off-by: Andres Lagar-Cavilla
<andres@lagarcavilla.org>
> >
> > Ack on the idea but the actual implementation fails for me:
> >
> > make[1]: Entering directory
> > `/local/scratch/ianc/devel/xen-unstable.hg/tools''
> > make -C tests install
> > make[2]: Entering directory
> > `/local/scratch/ianc/devel/xen-unstable.hg/tools/tests''
> > make[3]: Entering directory
> > `/local/scratch/ianc/devel/xen-unstable.hg/tools/tests''
> > make -C mce-test install
> > make[4]: Entering directory
> >
`/local/scratch/ianc/devel/xen-unstable.hg/tools/tests/mce-test''
> > make[4]: *** No rule to make target `install''.  Stop.
> >
> > Grep seems to suggest that most of the tools/tests dirs are missing an
> > install target, mce-test just happens to be first.
> >
> > I''m not sure if it makes sense to install any of these test
things?
> > Depending on the answer we could either hobble the install target in
> > tools/tests/Makefile or add an install target to
tools/tests/*/Makefile
> > which is a nop or an actual install target as appropriate.
> 
> Vote is to hobble install target. Refresh of patch pasted below (also
> added distclean).
> Thanks!
> Andres
> 
> # HG changeset patch
> # Parent efc0802acb87aec9a4d578e741e209bef8c6fe52
> Tools: build tests
> 
> Build tests as part of the tools build.
> 
> It is enabled with CONFIG_TESTS in Config.mk
> 
> Currently disabled build of tests/regressions and tests/xen-access (in 32
> bit mode) as they fail.
> 
> Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> diff -r efc0802acb87 Config.mk
> --- a/Config.mk
> +++ b/Config.mk
> @@ -238,6 +238,7 @@ OCAML_TOOLS        ?= y
>  CONFIG_MINITERM    ?= n
>  CONFIG_LOMOUNT     ?= n
>  CONFIG_SYSTEM_LIBAIO ?= y
> +CONFIG_TESTS       ?= y
> 
>  ifeq ($(OCAML_TOOLS),y)
>  OCAML_TOOLS := $(shell ocamlopt -v > /dev/null 2>&1 &&
echo "y" || echo "n")
> diff -r efc0802acb87 tools/Makefile
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -45,6 +45,7 @@ SUBDIRS-y += remus
>  SUBDIRS-$(CONFIG_X86) += xenpaging
>  SUBDIRS-$(CONFIG_X86) += debugger/gdbsx
>  SUBDIRS-$(CONFIG_X86) += debugger/kdd
> +SUBDIRS-$(CONFIG_TESTS) += tests
> 
>  # These don''t cross-compile
>  ifeq ($(XEN_COMPILE_ARCH),$(XEN_TARGET_ARCH))
> diff -r efc0802acb87 tools/tests/Makefile
> --- /dev/null
> +++ b/tools/tests/Makefile
> @@ -0,0 +1,21 @@
> +XEN_ROOT = $(CURDIR)/../..
> +include $(XEN_ROOT)/tools/Rules.mk
> +
> +CFLAGS  += $(CFLAGS_libxenctrl)
> +LDLIBS += $(LDLIBS_libxenctrl)
> +
> +SUBDIRS-y :> +SUBDIRS-y += mce-test
> +SUBDIRS-y += mem-sharing
> +ifeq ($(XEN_TARGET_ARCH),__fixme__)
> +SUBDIRS-y += regression
> +endif
> +SUBDIRS-y += x86_emulator
> +ifneq ($(XEN_TARGET_ARCH),x86_32)
> +SUBDIRS-y += xen-access
> +endif
> +
> +.PHONY: all clean install distclean
> +all clean distclean: %: subdirs-%
> +
> +install:
> 
> 
> 
> >
> > Ian.
> >
> >
> >
> 
>

Andres Lagar-Cavilla

2012-Feb-06 15:55 UTC

head link

Re: [PATCH] Tools: build tests

> On Wed, 2012-02-01 at 15:58 +0000, Andres Lagar-Cavilla wrote:
>> > On Fri, 2012-01-27 at 21:21 +0000, Andres Lagar-Cavilla wrote:
>> >> Config.mk            |   1 +
>> >>  tools/Makefile       |   1 +
>> >>  tools/tests/Makefile |  20 ++++++++++++++++++++
>> >>  3 files changed, 22 insertions(+), 0 deletions(-)
>> >>
>> >>
>> >> Build tests as part of the tools build.
>> >>
>> >> It is enabled with CONFIG_TESTS in Config.mk
>> >>
>> >> Currently disabled build of tests/regressions and
tests/xen-access
>> (in
>> >> 32 bit
>> >> mode) as they fail.
>> >>
>> >> Signed-off-by: Andres Lagar-Cavilla
<andres@lagarcavilla.org>
>> >
>> > Ack on the idea but the actual implementation fails for me:
>> >
>> > make[1]: Entering directory
>> > `/local/scratch/ianc/devel/xen-unstable.hg/tools''
>> > make -C tests install
>> > make[2]: Entering directory
>> > `/local/scratch/ianc/devel/xen-unstable.hg/tools/tests''
>> > make[3]: Entering directory
>> > `/local/scratch/ianc/devel/xen-unstable.hg/tools/tests''
>> > make -C mce-test install
>> > make[4]: Entering directory
>> >
`/local/scratch/ianc/devel/xen-unstable.hg/tools/tests/mce-test''
>> > make[4]: *** No rule to make target `install''.  Stop.
>> >
>> > Grep seems to suggest that most of the tools/tests dirs are
missing an
>> > install target, mce-test just happens to be first.
>> >
>> > I''m not sure if it makes sense to install any of these
test things?
>> > Depending on the answer we could either hobble the install target
in
>> > tools/tests/Makefile or add an install target to
>> tools/tests/*/Makefile
>> > which is a nop or an actual install target as appropriate.
>>
>> Vote is to hobble install target. Refresh of patch pasted below (also
>> added distclean).
>> Thanks!
>> Andres
>>
>> # HG changeset patch
>> # Parent efc0802acb87aec9a4d578e741e209bef8c6fe52
>> Tools: build tests
>>
>> Build tests as part of the tools build.
>>
>> It is enabled with CONFIG_TESTS in Config.mk
>>
>> Currently disabled build of tests/regressions and tests/xen-access (in
>> 32
>> bit mode) as they fail.
>>
>> Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Bump? Ping?
Thanks,
Andres
>
>>
>> diff -r efc0802acb87 Config.mk
>> --- a/Config.mk
>> +++ b/Config.mk
>> @@ -238,6 +238,7 @@ OCAML_TOOLS        ?= y
>>  CONFIG_MINITERM    ?= n
>>  CONFIG_LOMOUNT     ?= n
>>  CONFIG_SYSTEM_LIBAIO ?= y
>> +CONFIG_TESTS       ?= y
>>
>>  ifeq ($(OCAML_TOOLS),y)
>>  OCAML_TOOLS := $(shell ocamlopt -v > /dev/null 2>&1
&& echo "y" || echo
>> "n")
>> diff -r efc0802acb87 tools/Makefile
>> --- a/tools/Makefile
>> +++ b/tools/Makefile
>> @@ -45,6 +45,7 @@ SUBDIRS-y += remus
>>  SUBDIRS-$(CONFIG_X86) += xenpaging
>>  SUBDIRS-$(CONFIG_X86) += debugger/gdbsx
>>  SUBDIRS-$(CONFIG_X86) += debugger/kdd
>> +SUBDIRS-$(CONFIG_TESTS) += tests
>>
>>  # These don''t cross-compile
>>  ifeq ($(XEN_COMPILE_ARCH),$(XEN_TARGET_ARCH))
>> diff -r efc0802acb87 tools/tests/Makefile
>> --- /dev/null
>> +++ b/tools/tests/Makefile
>> @@ -0,0 +1,21 @@
>> +XEN_ROOT = $(CURDIR)/../..
>> +include $(XEN_ROOT)/tools/Rules.mk
>> +
>> +CFLAGS  += $(CFLAGS_libxenctrl)
>> +LDLIBS += $(LDLIBS_libxenctrl)
>> +
>> +SUBDIRS-y :>> +SUBDIRS-y += mce-test
>> +SUBDIRS-y += mem-sharing
>> +ifeq ($(XEN_TARGET_ARCH),__fixme__)
>> +SUBDIRS-y += regression
>> +endif
>> +SUBDIRS-y += x86_emulator
>> +ifneq ($(XEN_TARGET_ARCH),x86_32)
>> +SUBDIRS-y += xen-access
>> +endif
>> +
>> +.PHONY: all clean install distclean
>> +all clean distclean: %: subdirs-%
>> +
>> +install:
>>
>>
>>
>> >
>> > Ian.
>> >
>> >
>> >
>>
>>
>
>
>

Possibly Parallel Threads

Search for more possibly parallel threads

Xen devel - Jan 2012 - [PATCH] Tools: build tests

[PATCH] Tools: build tests

Re: [PATCH] Tools: build tests

Re: [PATCH] Tools: build tests

Re: [PATCH] Tools: build tests

Re: [PATCH] Tools: build tests

Possibly Parallel Threads