Tim Deegan
2012-Jan-26 15:47 UTC
[PATCH] Get rid of non-static ''inline'' modifiers (gcc 4.2.1 complains)
# HG changeset patch
# User Tim Deegan <tim@xen.org>
# Date 1327592560 0
# Node ID dba361080715baf5ec2c493190bb69ba04cc633c
# Parent a08043a997ea550e351ee87cd205f87562c67fcb
Get rid of non-static ''inline'' modifiers (gcc 4.2.1 complains)
They seem to have been introduced by accident in 23311:f4585056b9ae
when some ''static inline'' functions were moved out of a header
Signed-off-by: Tim Deegan <tim@xen.org>
diff -r a08043a997ea -r dba361080715 xen/arch/x86/xstate.c
--- a/xen/arch/x86/xstate.c Thu Jan 26 15:35:36 2012 +0000
+++ b/xen/arch/x86/xstate.c Thu Jan 26 15:42:40 2012 +0000
@@ -40,13 +40,13 @@ static inline void xsetbv(u32 index, u64
"a" (lo), "d" (hi));
}
-inline void set_xcr0(u64 xfeatures)
+void set_xcr0(u64 xfeatures)
{
this_cpu(xcr0) = xfeatures;
xsetbv(XCR_XFEATURE_ENABLED_MASK, xfeatures);
}
-inline uint64_t get_xcr0(void)
+uint64_t get_xcr0(void)
{
return this_cpu(xcr0);
}
Keir Fraser
2012-Jan-26 15:59 UTC
Re: [PATCH] Get rid of non-static ''inline'' modifiers (gcc 4.2.1 complains)
On 26/01/2012 15:47, "Tim Deegan" <tim@xen.org> wrote:> # HG changeset patch > # User Tim Deegan <tim@xen.org> > # Date 1327592560 0 > # Node ID dba361080715baf5ec2c493190bb69ba04cc633c > # Parent a08043a997ea550e351ee87cd205f87562c67fcb > Get rid of non-static ''inline'' modifiers (gcc 4.2.1 complains) > > They seem to have been introduced by accident in 23311:f4585056b9ae > when some ''static inline'' functions were moved out of a header > > Signed-off-by: Tim Deegan <tim@xen.org>Acked-by: Keir Fraser <keir@xen.org>> diff -r a08043a997ea -r dba361080715 xen/arch/x86/xstate.c > --- a/xen/arch/x86/xstate.c Thu Jan 26 15:35:36 2012 +0000 > +++ b/xen/arch/x86/xstate.c Thu Jan 26 15:42:40 2012 +0000 > @@ -40,13 +40,13 @@ static inline void xsetbv(u32 index, u64 > "a" (lo), "d" (hi)); > } > > -inline void set_xcr0(u64 xfeatures) > +void set_xcr0(u64 xfeatures) > { > this_cpu(xcr0) = xfeatures; > xsetbv(XCR_XFEATURE_ENABLED_MASK, xfeatures); > } > > -inline uint64_t get_xcr0(void) > +uint64_t get_xcr0(void) > { > return this_cpu(xcr0); > } > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel