flight 10882 xen-unstable real [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/10882/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-i386-i386-xl-win 7 windows-install fail REGR. vs. 10649
test-i386-i386-win 7 windows-install fail REGR. vs. 10649
test-i386-i386-xl-winxpsp3 7 windows-install fail REGR. vs. 10649
test-amd64-i386-rhel6hvm-intel 7 redhat-install fail in 10875 REGR. vs. 10649
test-amd64-i386-xend-winxpsp3 7 windows-install fail in 10875 REGR. vs. 10649
test-amd64-amd64-win 7 windows-install fail in 10875 REGR. vs. 10649
test-amd64-amd64-xl-win 7 windows-install fail in 10875 REGR. vs. 10649
test-amd64-i386-xl-win-vcpus1 7 windows-install fail in 10875 REGR. vs. 10649
test-amd64-i386-win-vcpus1 7 windows-install fail in 10875 REGR. vs. 10649
test-amd64-i386-win 7 windows-install fail in 10875 REGR. vs. 10649
test-amd64-i386-xl-winxpsp3-vcpus1 7 windows-install fail in 10875 REGR. vs.
10649
test-amd64-amd64-xl-winxpsp3 7 windows-install fail in 10875 REGR. vs. 10649
Tests which are failing intermittently (not blocking):
build-amd64 4 xen-build fail pass in 10875
build-amd64-oldkern 4 xen-build fail pass in 10875
build-amd64-pvops 4 kernel-build fail pass in 10875
test-amd64-amd64-xl-sedf-pin 14 guest-localmigrate/x10 fail in 10875 pass in
10867
test-amd64-i386-xl-win7-amd64 7 windows-install fail in 10875 pass in 10867
test-amd64-amd64-xl-win7-amd64 7 windows-install fail in 10875 pass in 10867
test-amd64-i386-rhel6hvm-amd 7 redhat-install fail in 10867 pass in 10875
Tests which did not succeed, but are not blocking:
test-amd64-amd64-xl-pcipt-intel 1 xen-build-check(1) blocked n/a
test-amd64-i386-pair 1 xen-build-check(1) blocked n/a
test-amd64-i386-rhel6hvm-intel 1 xen-build-check(1) blocked n/a
test-amd64-i386-pv 1 xen-build-check(1) blocked n/a
test-amd64-i386-xl-multivcpu 1 xen-build-check(1) blocked n/a
test-amd64-amd64-pv 1 xen-build-check(1) blocked n/a
test-amd64-i386-xl-credit2 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl 1 xen-build-check(1) blocked n/a
test-amd64-i386-xl 1 xen-build-check(1) blocked n/a
test-amd64-i386-rhel6hvm-amd 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-sedf 1 xen-build-check(1) blocked n/a
test-amd64-amd64-pair 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-sedf-pin 1 xen-build-check(1) blocked n/a
test-amd64-i386-xl-win7-amd64 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-win7-amd64 1 xen-build-check(1) blocked n/a
test-amd64-i386-xend-winxpsp3 1 xen-build-check(1) blocked n/a
test-amd64-amd64-win 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-win 1 xen-build-check(1) blocked n/a
test-amd64-i386-xl-win-vcpus1 1 xen-build-check(1) blocked n/a
test-amd64-i386-win-vcpus1 1 xen-build-check(1) blocked n/a
test-amd64-i386-win 1 xen-build-check(1) blocked n/a
test-amd64-i386-xl-winxpsp3-vcpus1 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-winxpsp3 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-pcipt-intel 9 guest-start fail in 10875 never pass
test-amd64-i386-rhel6hvm-amd 9 guest-start.2 fail in 10875 never pass
test-amd64-i386-xl-win7-amd64 13 guest-stop fail in 10867 never pass
test-amd64-amd64-xl-win7-amd64 13 guest-stop fail in 10867 never pass
version targeted for testing:
xen 15ab61865ecb
baseline version:
xen 5b2676ac1321
------------------------------------------------------------
People who touched revisions under test:
Adin Scannell <adin@scannell.ca>
Andres Lagar-Cavilla <andres@lagarcavilla.org>
Christoph Egger <Christoph.Egger@amd.com>
Daniel De Graaf <dgdegra@tycho.nsa.gov>
Dario Faggioli <dario.faggioli@citrix.com>
Gang Wei <gang.wei@intel.com>
George Dunlap <george.dunlap@eu.citrix.com>
Hui Lv <hui.lv@intel.com>
Ian Campbell <ian.campbell@citrix.com>
Ian Jackson <ian.jackson.citrix.com>
Ian Jackson <ian.jackson@eu.citrix.com>
Jan Beulich <jbeulich@suse.com>
Joseph Cihula <joseph.cihula@intel.com>
Keir Fraser <keir@xen.org>
Olaf Hering <olaf@aepfle.de>
Paul Durrant <paul.durrant@citrix.com>
Roger Pau Monne <roger.pau@entel.upc.edu>
Shane Wang <shane.wang@intel.com>
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Tim Deegan <tim@xen.org>
Wei Wang <wei.wang2@amd.com>
Wei, Gang <gang.wei@intel.com>
------------------------------------------------------------
jobs:
build-amd64 fail
build-i386 pass
build-amd64-oldkern fail
build-i386-oldkern pass
build-amd64-pvops fail
build-i386-pvops pass
test-amd64-amd64-xl blocked
test-amd64-i386-xl blocked
test-i386-i386-xl pass
test-amd64-i386-rhel6hvm-amd blocked
test-amd64-amd64-xl-win7-amd64 blocked
test-amd64-i386-xl-win7-amd64 blocked
test-amd64-i386-xl-credit2 blocked
test-amd64-amd64-xl-pcipt-intel blocked
test-amd64-i386-rhel6hvm-intel blocked
test-amd64-i386-xl-multivcpu blocked
test-amd64-amd64-pair blocked
test-amd64-i386-pair blocked
test-i386-i386-pair pass
test-amd64-amd64-xl-sedf-pin blocked
test-amd64-amd64-pv blocked
test-amd64-i386-pv blocked
test-i386-i386-pv pass
test-amd64-amd64-xl-sedf blocked
test-amd64-i386-win-vcpus1 blocked
test-amd64-i386-xl-win-vcpus1 blocked
test-amd64-i386-xl-winxpsp3-vcpus1 blocked
test-amd64-amd64-win blocked
test-amd64-i386-win blocked
test-i386-i386-win fail
test-amd64-amd64-xl-win blocked
test-i386-i386-xl-win fail
test-amd64-i386-xend-winxpsp3 blocked
test-amd64-amd64-xl-winxpsp3 blocked
test-i386-i386-xl-winxpsp3 fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
Not pushing.
(No revision log; it would be 870 lines long.)
>>> On 18.01.12 at 19:19, xen.org <ian.jackson@eu.citrix.com> wrote: > flight 10882 xen-unstable real [real] > http://www.chiark.greenend.org.uk/~xensrcts/logs/10882/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-i386-i386-xl-win 7 windows-install fail REGR. vs. 10649 > test-i386-i386-win 7 windows-install fail REGR. vs. 10649Finally spotted an actual crash in the logs here, pointing at a relatively obvious problem: guest_iommu_mmio_range() is apparently lacking a NULL check. Was this code ever tested on an Intel system? I''ll add this, but will first check whether I can spot other functions missing such. Jan> test-i386-i386-xl-winxpsp3 7 windows-install fail REGR. vs. 10649 > test-amd64-i386-rhel6hvm-intel 7 redhat-install fail in 10875 REGR. vs. 10649 > test-amd64-i386-xend-winxpsp3 7 windows-install fail in 10875 REGR. vs. 10649 > test-amd64-amd64-win 7 windows-install fail in 10875 REGR. vs. 10649 > test-amd64-amd64-xl-win 7 windows-install fail in 10875 REGR. vs. 10649 > test-amd64-i386-xl-win-vcpus1 7 windows-install fail in 10875 REGR. vs. 10649 > test-amd64-i386-win-vcpus1 7 windows-install fail in 10875 REGR. vs. 10649 > test-amd64-i386-win 7 windows-install fail in 10875 REGR. vs. 10649 > test-amd64-i386-xl-winxpsp3-vcpus1 7 windows-install fail in 10875 REGR. vs. 10649 > test-amd64-amd64-xl-winxpsp3 7 windows-install fail in 10875 REGR. vs. 10649
>>> On 19.01.12 at 09:30, "Jan Beulich" <JBeulich@suse.com> wrote: >>>> On 18.01.12 at 19:19, xen.org <ian.jackson@eu.citrix.com> wrote: >> flight 10882 xen-unstable real [real] >> http://www.chiark.greenend.org.uk/~xensrcts/logs/10882/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> including tests which could not be run: >> test-i386-i386-xl-win 7 windows-install fail REGR. vs. 10649 >> test-i386-i386-win 7 windows-install fail REGR. vs. 10649 > > Finally spotted an actual crash in the logs here, pointing at a relatively > obvious problem: guest_iommu_mmio_range() is apparently lacking a > NULL check. Was this code ever tested on an Intel system? > > I''ll add this, but will first check whether I can spot other functions > missing such.Below the patch I''m going to commit. Jan add NULL checks in code added by 24492:6c104b46ef89 Also a couple of missing is_hvm_domain() checks. Further properly pass the PCI segment in a call to pci_get_pdev(). Signed-off-by: Jan Beulich <jbeulich@suse.com> --- a/xen/drivers/passthrough/amd/iommu_guest.c +++ b/xen/drivers/passthrough/amd/iommu_guest.c @@ -182,7 +182,13 @@ void guest_iommu_add_ppr_log(struct doma ppr_entry_t *log, *log_base; struct guest_iommu *iommu; + if ( !is_hvm_domain(d) ) + return; + iommu = domain_iommu(d); + if ( !iommu ) + return; + tail = iommu_get_rb_pointer(iommu->ppr_log.reg_tail.lo); head = iommu_get_rb_pointer(iommu->ppr_log.reg_head.lo); @@ -225,7 +231,13 @@ void guest_iommu_add_event_log(struct do event_entry_t *log, *log_base; struct guest_iommu *iommu; + if ( !is_hvm_domain(d) ) + return; + iommu = domain_iommu(d); + if ( !iommu ) + return; + tail = iommu_get_rb_pointer(iommu->event_log.reg_tail.lo); head = iommu_get_rb_pointer(iommu->event_log.reg_head.lo); @@ -793,6 +805,9 @@ int guest_iommu_set_base(struct domain * p2m_type_t t; struct guest_iommu *iommu = domain_iommu(d); + if ( !iommu ) + return -EACCES; + iommu->mmio_base = base; base >>= PAGE_SHIFT; @@ -882,6 +897,8 @@ void guest_iommu_destroy(struct domain * return; iommu = domain_iommu(d); + if ( !iommu ) + return; tasklet_kill(&iommu->cmd_buffer_tasklet); xfree(iommu); @@ -893,7 +910,7 @@ static int guest_iommu_mmio_range(struct { struct guest_iommu *iommu = vcpu_iommu(v); - return addr >= iommu->mmio_base && + return iommu && addr >= iommu->mmio_base && addr < iommu->mmio_base + IOMMU_MMIO_SIZE; } --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen/drivers/passthrough/amd/iommu_init.c @@ -651,7 +651,7 @@ void parse_ppr_log_entry(struct amd_iomm local_irq_enable(); spin_lock(&pcidevs_lock); - pdev = pci_get_pdev(0, bus, devfn); + pdev = pci_get_pdev(iommu->seg, bus, devfn); spin_unlock(&pcidevs_lock); local_irq_disable();