branch xen-unstable
xen branch xen-unstable
job build-amd64
test xen-build
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
Bug introduced: 86b8a1e3a419
Bug not present: c5eadfd5c639
changeset: 24503:86b8a1e3a419
user: Jan Beulich <jbeulich@suse.com>
date: Fri Jan 13 08:33:31 2012 +0100
force inclusion of xen/config.h through compiler option
As we expect all source files to include the header as the first thing
anyway, stop doing this by repeating the inclusion in each and every
source file (and in many headers), but rather enforce this uniformly
through the compiler command line.
As a first cleanup step, remove the explicit inclusion from all common
headers. Further cleanup can be done incrementally.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
For bisection revision-tuple graph see:
http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.build-amd64.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.
----------------------------------------
Searching for failure / basis pass:
10681 fail [host=leaf-beetle] / 10649 [host=itch-mite] 10646 [host=itch-mite]
10645 [host=itch-mite] 10644 [host=itch-mite] 10643 [host=lace-bug] 10642
[host=lace-bug] 10641 [host=itch-mite] 10640 [host=itch-mite] 10639
[host=itch-mite] 10636 [host=potato-beetle] 10635 [host=itch-mite] 10632
[host=itch-mite] 10631 [host=itch-mite] 10630 [host=potato-beetle] 10629
[host=itch-mite] 10628 [host=itch-mite] 10623 [host=moss-bug] 10622
[host=itch-mite] 10621 ok.
Failure / basis pass flights: 10681 / 10621
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
Latest bb36d632e4cabf47882adff07a45c6702c4a5b30 6d8888519e3a
Basis pass 56d7747a3cf811910c4cf865e1ebcb8b82502005 a7b2610b8e5c
Generating revisions with ./adhoc-revtuple-generator
git://xenbits.xen.org/staging/qemu-xen-unstable.git#56d7747a3cf811910c4cf865e1ebcb8b82502005-bb36d632e4cabf47882adff07a45c6702c4a5b30
http://xenbits.xen.org/staging/xen-unstable.hg#a7b2610b8e5c-6d8888519e3a
using cache /export/home/osstest/repos/git-cache...
using cache /export/home/osstest/repos/git-cache...
locked cache /export/home/osstest/repos/git-cache...
processing ./cacheing-git clone --bare
git://xenbits.xen.org/staging/qemu-xen-unstable.git
/export/home/osstest/repos/qemu-xen-unstable...
Initialized empty Git repository in
/export/home/osstest/repos/qemu-xen-unstable/
updating cache /export/home/osstest/repos/git-cache qemu-xen-unstable...
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
using cache /export/home/osstest/repos/git-cache...
using cache /export/home/osstest/repos/git-cache...
locked cache /export/home/osstest/repos/git-cache...
processing ./cacheing-git clone --bare
git://xenbits.xen.org/staging/qemu-xen-unstable.git
/export/home/osstest/repos/qemu-xen-unstable...
Initialized empty Git repository in
/export/home/osstest/repos/qemu-xen-unstable/
updating cache /export/home/osstest/repos/git-cache qemu-xen-unstable...
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
Loaded 1023 nodes in revision graph
Searching for test results:
10613 [host=moss-bug]
10620 [host=moss-bug]
10618 [host=moss-bug]
10614 pass 56d7747a3cf811910c4cf865e1ebcb8b82502005 a7b2610b8e5c
10617 pass 56d7747a3cf811910c4cf865e1ebcb8b82502005 a7b2610b8e5c
10619 [host=moss-bug]
10621 pass 56d7747a3cf811910c4cf865e1ebcb8b82502005 a7b2610b8e5c
10622 [host=itch-mite]
10625 [host=woodlouse]
10623 [host=moss-bug]
10628 [host=itch-mite]
10629 [host=itch-mite]
10630 [host=potato-beetle]
10631 [host=itch-mite]
10632 [host=itch-mite]
10634 [host=earwig]
10682 pass 56d7747a3cf811910c4cf865e1ebcb8b82502005 a7b2610b8e5c
10635 [host=itch-mite]
10636 [host=potato-beetle]
10684 fail bb36d632e4cabf47882adff07a45c6702c4a5b30 6f5fff70668b
10685 pass bb36d632e4cabf47882adff07a45c6702c4a5b30 7bc8cf556c0c
10639 [host=itch-mite]
10640 [host=itch-mite]
10686 pass bb36d632e4cabf47882adff07a45c6702c4a5b30 8d2fa20dd3f3
10641 [host=itch-mite]
10642 [host=lace-bug]
10687 pass bb36d632e4cabf47882adff07a45c6702c4a5b30 9db6fe19dd04
10643 [host=lace-bug]
10644 [host=itch-mite]
10688 pass bb36d632e4cabf47882adff07a45c6702c4a5b30 80765dec9616
10681 fail bb36d632e4cabf47882adff07a45c6702c4a5b30 6d8888519e3a
10645 [host=itch-mite]
10648 [host=potato-beetle]
10646 [host=itch-mite]
10690 fail bb36d632e4cabf47882adff07a45c6702c4a5b30 6d8888519e3a
10649 [host=itch-mite]
10691 pass bb36d632e4cabf47882adff07a45c6702c4a5b30 c5eadfd5c639
10680 fail bb36d632e4cabf47882adff07a45c6702c4a5b30 6f5fff70668b
10692 fail bb36d632e4cabf47882adff07a45c6702c4a5b30 86b8a1e3a419
10693 pass bb36d632e4cabf47882adff07a45c6702c4a5b30 c5eadfd5c639
10694 fail bb36d632e4cabf47882adff07a45c6702c4a5b30 86b8a1e3a419
10695 pass bb36d632e4cabf47882adff07a45c6702c4a5b30 c5eadfd5c639
10696 fail bb36d632e4cabf47882adff07a45c6702c4a5b30 86b8a1e3a419
Searching for interesting versions
Result found: flight 10614 (pass), for basis pass
Result found: flight 10681 (fail), for basis failure
Repro found: flight 10682 (pass), for basis pass
Repro found: flight 10690 (fail), for basis failure
0 revisions at bb36d632e4cabf47882adff07a45c6702c4a5b30 c5eadfd5c639
No revisions left to test, checking graph state.
Result found: flight 10691 (pass), for last pass
Result found: flight 10692 (fail), for first failure
Repro found: flight 10693 (pass), for last pass
Repro found: flight 10694 (fail), for first failure
Repro found: flight 10695 (pass), for last pass
Repro found: flight 10696 (fail), for first failure
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
Bug introduced: 86b8a1e3a419
Bug not present: c5eadfd5c639
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
changeset: 24503:86b8a1e3a419
user: Jan Beulich <jbeulich@suse.com>
date: Fri Jan 13 08:33:31 2012 +0100
force inclusion of xen/config.h through compiler option
As we expect all source files to include the header as the first thing
anyway, stop doing this by repeating the inclusion in each and every
source file (and in many headers), but rather enforce this uniformly
through the compiler command line.
As a first cleanup step, remove the explicit inclusion from all common
headers. Further cleanup can be done incrementally.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
Revision graph left in
/home/xc_osstest/results/bisect.xen-unstable.build-amd64.xen-build.{dot,ps,png,html}.
----------------------------------------
10696: ALL FAIL
flight 10696 xen-unstable real-bisect [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/10696/
jobs:
build-amd64 fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
branch xen-unstable
xen branch xen-unstable
job build-amd64
test xen-build
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
Bug introduced: d5b706214616
Bug not present: 1e27e827e6a8
changeset: 24566:d5b706214616
user: Olaf Hering <olaf@aepfle.de>
date: Thu Jan 26 11:04:59 2012 +0000
tools/libxc: fix error handling in xc_mem_paging_load
xc_mem_paging_load() does not pass errors in errno and the actual
errno from xc_mem_event_control() is overwritten by munlock().
xenpaging_populate_page() needs to check errno, but with the switch to
xc_mem_paging_load() it could not receive ENOMEM anymore.
Update xc_mem_paging_load() to return -1 and preserve errno during
munlock().
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Committed-by: Keir Fraser <keir@xen.org>
For bisection revision-tuple graph see:
http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.build-amd64.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.
----------------------------------------
Searching for failure / basis pass:
11609 fail [host=moss-bug] / 11601 ok.
Failure / basis pass flights: 11609 / 11601
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
Latest bb36d632e4cabf47882adff07a45c6702c4a5b30 570d0ea0ad2f
Basis pass bb36d632e4cabf47882adff07a45c6702c4a5b30 4271634e4c86
Generating revisions with ./adhoc-revtuple-generator
git://xenbits.xen.org/staging/qemu-xen-unstable.git#bb36d632e4cabf47882adff07a45c6702c4a5b30-bb36d632e4cabf47882adff07a45c6702c4a5b30
http://xenbits.xen.org/staging/xen-unstable.hg#4271634e4c86-570d0ea0ad2f
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
Loaded 127 nodes in revision graph
Searching for test results:
11600 pass bb36d632e4cabf47882adff07a45c6702c4a5b30 4271634e4c86
11601 pass bb36d632e4cabf47882adff07a45c6702c4a5b30 4271634e4c86
11603 fail bb36d632e4cabf47882adff07a45c6702c4a5b30 d8f280c78544
11604 pass bb36d632e4cabf47882adff07a45c6702c4a5b30 4271634e4c86
11606 fail bb36d632e4cabf47882adff07a45c6702c4a5b30 d8f280c78544
11607 pass bb36d632e4cabf47882adff07a45c6702c4a5b30 1e27e827e6a8
11611 fail bb36d632e4cabf47882adff07a45c6702c4a5b30 d5b706214616
11612 pass bb36d632e4cabf47882adff07a45c6702c4a5b30 1e27e827e6a8
11609 fail bb36d632e4cabf47882adff07a45c6702c4a5b30 570d0ea0ad2f
11613 fail bb36d632e4cabf47882adff07a45c6702c4a5b30 d5b706214616
11614 pass bb36d632e4cabf47882adff07a45c6702c4a5b30 4271634e4c86
11615 fail bb36d632e4cabf47882adff07a45c6702c4a5b30 570d0ea0ad2f
11616 pass bb36d632e4cabf47882adff07a45c6702c4a5b30 1e27e827e6a8
11617 fail bb36d632e4cabf47882adff07a45c6702c4a5b30 d5b706214616
Searching for interesting versions
Result found: flight 11600 (pass), for basis pass
Result found: flight 11609 (fail), for basis failure
Repro found: flight 11614 (pass), for basis pass
Repro found: flight 11615 (fail), for basis failure
0 revisions at bb36d632e4cabf47882adff07a45c6702c4a5b30 1e27e827e6a8
No revisions left to test, checking graph state.
Result found: flight 11607 (pass), for last pass
Result found: flight 11611 (fail), for first failure
Repro found: flight 11612 (pass), for last pass
Repro found: flight 11613 (fail), for first failure
Repro found: flight 11616 (pass), for last pass
Repro found: flight 11617 (fail), for first failure
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
Bug introduced: d5b706214616
Bug not present: 1e27e827e6a8
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
changeset: 24566:d5b706214616
user: Olaf Hering <olaf@aepfle.de>
date: Thu Jan 26 11:04:59 2012 +0000
tools/libxc: fix error handling in xc_mem_paging_load
xc_mem_paging_load() does not pass errors in errno and the actual
errno from xc_mem_event_control() is overwritten by munlock().
xenpaging_populate_page() needs to check errno, but with the switch to
xc_mem_paging_load() it could not receive ENOMEM anymore.
Update xc_mem_paging_load() to return -1 and preserve errno during
munlock().
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Committed-by: Keir Fraser <keir@xen.org>
Revision graph left in
/home/xc_osstest/results/bisect.xen-unstable.build-amd64.xen-build.{dot,ps,png,html}.
----------------------------------------
11617: ALL FAIL
flight 11617 xen-unstable real-bisect [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/11617/
jobs:
build-amd64 fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
xen.org writes ("[xen-unstable bisection] complete
build-amd64"):> branch xen-unstable
> xen branch xen-unstable
> job build-amd64
> test xen-build
>
> Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
> Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
>
> *** Found and reproduced problem changeset ***
>
> Bug is in tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
> Bug introduced: d5b706214616
> Bug not present: 1e27e827e6a8
>
>
> changeset: 24566:d5b706214616
> user: Olaf Hering <olaf@aepfle.de>
> date: Thu Jan 26 11:04:59 2012 +0000
>
> tools/libxc: fix error handling in xc_mem_paging_load
>
> xc_mem_paging_load() does not pass errors in errno and the actual
> errno from xc_mem_event_control() is overwritten by munlock().
> xenpaging_populate_page() needs to check errno, but with the switch
to
> xc_mem_paging_load() it could not receive ENOMEM anymore.
>
> Update xc_mem_paging_load() to return -1 and preserve errno during
> munlock().
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Acked-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
> Committed-by: Keir Fraser <keir@xen.org>
cc1: warnings being treated as errors
xc_mem_paging.c: In function ''xc_mem_paging_load'':
xc_mem_paging.c:90: error: statement with no effect
make[3]: *** [xc_mem_paging.o] Error 1
make[3]: Leaving directory
`/home/osstest/build.11617.build-amd64/xen-unstable/stubdom/libxc-x86_64''
make[2]: *** [build] Error 2
make[2]: Leaving directory
`/home/osstest/build.11617.build-amd64/xen-unstable/stubdom/libxc-x86_64''
make[1]: *** [libxc-x86_64/libxenctrl.a] Error 2
make[1]: *** Waiting for unfinished jobs....
On 26/01/2012 17:27, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:> xen.org writes ("[xen-unstable bisection] complete build-amd64"): >> branch xen-unstable >> xen branch xen-unstable >> job build-amd64 >> test xen-build >> >> Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git >> Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg >> >> *** Found and reproduced problem changeset *** >> >> Bug is in tree: xen http://xenbits.xen.org/staging/xen-unstable.hg >> Bug introduced: d5b706214616 >> Bug not present: 1e27e827e6a8 >> >> >> changeset: 24566:d5b706214616 >> user: Olaf Hering <olaf@aepfle.de> >> date: Thu Jan 26 11:04:59 2012 +0000 >> >> tools/libxc: fix error handling in xc_mem_paging_load >> >> xc_mem_paging_load() does not pass errors in errno and the actual >> errno from xc_mem_event_control() is overwritten by munlock(). >> xenpaging_populate_page() needs to check errno, but with the switch to >> xc_mem_paging_load() it could not receive ENOMEM anymore. >> >> Update xc_mem_paging_load() to return -1 and preserve errno during >> munlock(). >> >> Signed-off-by: Olaf Hering <olaf@aepfle.de> >> Acked-by: Andres Lagar-Cavilla <andres@lagarcavilla.org> >> Committed-by: Keir Fraser <keir@xen.org> > > cc1: warnings being treated as errors > xc_mem_paging.c: In function ''xc_mem_paging_load'': > xc_mem_paging.c:90: error: statement with no effect > make[3]: *** [xc_mem_paging.o] Error 1 > make[3]: Leaving directory > `/home/osstest/build.11617.build-amd64/xen-unstable/stubdom/libxc-x86_64'' > make[2]: *** [build] Error 2 > make[2]: Leaving directory > `/home/osstest/build.11617.build-amd64/xen-unstable/stubdom/libxc-x86_64'' > make[1]: *** [libxc-x86_64/libxenctrl.a] Error 2 > make[1]: *** Waiting for unfinished jobs....Tim already fixed it. -- Keir
Keir Fraser writes ("Re: [xen-unstable bisection] complete
build-amd64"):> Tim already fixed it.
Yes, so Ian points out to me...
Thanks,
Ian.
On Thu, Jan 26, Ian Jackson wrote:> cc1: warnings being treated as errors > xc_mem_paging.c: In function ''xc_mem_paging_load'': > xc_mem_paging.c:90: error: statement with no effect > make[3]: *** [xc_mem_paging.o] Error 1 > make[3]: Leaving directory `/home/osstest/build.11617.build-amd64/xen-unstable/stubdom/libxc-x86_64'' > make[2]: *** [build] Error 2 > make[2]: Leaving directory `/home/osstest/build.11617.build-amd64/xen-unstable/stubdom/libxc-x86_64'' > make[1]: *** [libxc-x86_64/libxenctrl.a] Error 2 > make[1]: *** Waiting for unfinished jobs....As Andrew Morton put it once: "We code in C, not in cpp". extras/mini-os/include/posix/sys/mman.h:19:#define munlock(addr, len) ((void)(addr), (void)(len), 0) As such, that define should be "static inline munlock(const void *addr, size_t len) { return 0; }". And now that I actually look at that header, mlock should be changed as well. All this "(void)fn()" mess is really confusing. Olaf