Jan Beulich
2012-Jan-09 13:10 UTC
Ping: [PATCH] PCI: shrink pci_dev_info''s is_extfn/is_virtfn members
They are used as boolean flags only, so convert them accordingly
(shrinking the structure size by 8 bytes).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/ia64/xen/hypercall.c
+++ b/xen/arch/ia64/xen/hypercall.c
@@ -695,8 +695,8 @@ long do_physdev_op(int cmd, XEN_GUEST_HA
if ( copy_from_guest(&manage_pci_ext, arg, 1) != 0 )
break;
- pdev_info.is_extfn = manage_pci_ext.is_extfn;
- pdev_info.is_virtfn = manage_pci_ext.is_virtfn;
+ pdev_info.is_extfn = !!manage_pci_ext.is_extfn;
+ pdev_info.is_virtfn = !!manage_pci_ext.is_virtfn;
pdev_info.physfn.bus = manage_pci_ext.physfn.bus;
pdev_info.physfn.devfn = manage_pci_ext.physfn.devfn;
ret = pci_add_device(0, manage_pci_ext.bus,
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -33,8 +33,8 @@
#define MAX_MSIX_TABLE_ENTRIES 2048
#define MAX_MSIX_TABLE_PAGES 8
struct pci_dev_info {
- unsigned is_extfn;
- unsigned is_virtfn;
+ bool_t is_extfn;
+ bool_t is_virtfn;
struct {
u8 bus;
u8 devfn;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Keir Fraser
2012-Jan-09 13:24 UTC
Re: Ping: [PATCH] PCI: shrink pci_dev_info''s is_extfn/is_virtfn members
On 09/01/2012 13:10, "Jan Beulich" <JBeulich@suse.com> wrote:> They are used as boolean flags only, so convert them accordingly > (shrinking the structure size by 8 bytes). > > Signed-off-by: Jan Beulich <jbeulich@suse.com>Acked-by: Keir Fraser <keir@xen.org>> --- a/xen/arch/ia64/xen/hypercall.c > +++ b/xen/arch/ia64/xen/hypercall.c > @@ -695,8 +695,8 @@ long do_physdev_op(int cmd, XEN_GUEST_HA > if ( copy_from_guest(&manage_pci_ext, arg, 1) != 0 ) > break; > > - pdev_info.is_extfn = manage_pci_ext.is_extfn; > - pdev_info.is_virtfn = manage_pci_ext.is_virtfn; > + pdev_info.is_extfn = !!manage_pci_ext.is_extfn; > + pdev_info.is_virtfn = !!manage_pci_ext.is_virtfn; > pdev_info.physfn.bus = manage_pci_ext.physfn.bus; > pdev_info.physfn.devfn = manage_pci_ext.physfn.devfn; > ret = pci_add_device(0, manage_pci_ext.bus, > --- a/xen/include/xen/pci.h > +++ b/xen/include/xen/pci.h > @@ -33,8 +33,8 @@ > #define MAX_MSIX_TABLE_ENTRIES 2048 > #define MAX_MSIX_TABLE_PAGES 8 > struct pci_dev_info { > - unsigned is_extfn; > - unsigned is_virtfn; > + bool_t is_extfn; > + bool_t is_virtfn; > struct { > u8 bus; > u8 devfn; > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel