Olaf Hering
2012-Jan-05 18:41 UTC
[PATCH] add feature flag to xenstore for XS_RESET_WATCHES
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1325788840 -3600
# Node ID 2f5a98692acde9e74d4009f50f83a8aa08296310
# Parent 3a22ed3ec534799b3cab55b0dc0a7380e701ecbe
add feature flag to xenstore for XS_RESET_WATCHES
Tell guest about availibilty of xenstoreds XS_RESET_WATCHES function.
Guests can not issue this command unconditionally because some buggy
toolstacks (such as EC2) do not ignore unknown commands properly.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff -r 3a22ed3ec534 -r 2f5a98692acd tools/libxl/libxl_create.c
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -434,6 +434,7 @@ retry_transaction:
libxl__xs_writev(gc, t, libxl__sprintf(gc, "%s/platform",
dom_path), info->platformdata);
xs_write(ctx->xsh, t, libxl__sprintf(gc,
"%s/control/platform-feature-multiprocessor-suspend", dom_path),
"1", 1);
+ xs_write(ctx->xsh, t, libxl__sprintf(gc,
"%s/control/platform-feature-xs_reset_watches", dom_path),
"1", 1);
if (!xs_transaction_end(ctx->xsh, t, 0)) {
if (errno == EAGAIN) {
t = 0;
diff -r 3a22ed3ec534 -r 2f5a98692acd tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py
+++ b/tools/python/xen/xend/XendDomainInfo.py
@@ -1770,6 +1770,7 @@ class XendDomainInfo:
f(''store/port'', self.store_port)
f(''store/ring-ref'', self.store_mfn)
+ f(''control/platform-feature-xs_reset_watches'', True)
if arch.type == "x86":
f(''control/platform-feature-multiprocessor-suspend'', True)
Ian Jackson
2012-Jan-10 16:12 UTC
Re: [PATCH] add feature flag to xenstore for XS_RESET_WATCHES
Olaf Hering writes ("[Xen-devel] [PATCH] add feature flag to xenstore for
XS_RESET_WATCHES"):> add feature flag to xenstore for XS_RESET_WATCHES
>
> Tell guest about availibilty of xenstoreds XS_RESET_WATCHES function.
> Guests can not issue this command unconditionally because some buggy
> toolstacks (such as EC2) do not ignore unknown commands properly.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
Apparently Analagous Threads
- [PATCH] xen/pv-on-hvm kexec: shutdown watches from old kernel
- [PATCH 0/2] reset xenstore watches to fix kexec in Xen PVonHVM guests
- [PATCH, v2]: xl: Implement per-API-call garbage-collection lifetime
- [PATCH] xen/xenbus: silence GCC warning
- [PATCH] xen/xenbus: silence GCC warning