Switch to a consistent set of XC_PAGE_* constants. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger writes ("[Xen-devel] [PATCH] libxc: switch to
XC_PAGE_*"):> Switch to a consistent set of XC_PAGE_* constants.
This looks reasonable to me but: can you confirm what tests you''ve
done to check that this doesn''t have any actual change to the code ?
Eg it would be good to run it through the preprocessor and see if the
output is identical to before.
Ian.
On 12/12/11 15:52, Ian Jackson wrote:> Christoph Egger writes ("[Xen-devel] [PATCH] libxc: switch to XC_PAGE_*"): >> Switch to a consistent set of XC_PAGE_* constants. > > This looks reasonable to me but: can you confirm what tests you''ve > done to check that this doesn''t have any actual change to the code ?Is it enough to say a guest boots and runs as before?> Eg it would be good to run it through the preprocessor and see if the > output is identical to before. > > Ian. >-- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
Christoph Egger writes ("Re: [Xen-devel] [PATCH] libxc: switch to
XC_PAGE_*"):> On 12/12/11 15:52, Ian Jackson wrote:
> > Christoph Egger writes ("[Xen-devel] [PATCH] libxc: switch to
XC_PAGE_*"):
> >> Switch to a consistent set of XC_PAGE_* constants.
> >
> > This looks reasonable to me but: can you confirm what tests
you''ve
> > done to check that this doesn''t have any actual change to the
code ?
>
> Is it enough to say a guest boots and runs as before?
No, because you cannot possibly have tested every combination of
platforms.
Since the change you are making is supposed to make no difference to
the actual compiled code, you should check that directly.
Ian.