Xen devel - Nov 2011 - __vmptrst() broken...

Hi Keir,

__vmptrst() seems broken. It is:

static inline void __vmptrst(u64 addr)
{
    asm volatile ( VMPTRST_OPCODE
                   MODRM_EAX_07
                   :
                   : "a" (&addr)
                   : "memory");
}


should be:

static inline void __vmptrst(u64 *addr) 
{           
    asm volatile ( VMPTRST_OPCODE
                   MODRM_EAX_07 
                   :
                   : "a" (addr)
                   : "memory");
}   



Do you think you can just fix it in one of your changes without 
official patch?

thanks much,
Mukesh

On 22/11/2011 02:47, "Mukesh Rathor" <mukesh.rathor@oracle.com>
wrote:
> Hi Keir,
> 
> __vmptrst() seems broken. It is:
> 
> static inline void __vmptrst(u64 addr)
> {
>     asm volatile ( VMPTRST_OPCODE
>                    MODRM_EAX_07
>                    :
>                    : "a" (&addr)
>                    : "memory");
> }
> 
> 
> should be:
> 
> static inline void __vmptrst(u64 *addr)
> {           
>     asm volatile ( VMPTRST_OPCODE
>                    MODRM_EAX_07
>                    :
>                    : "a" (addr)
>                    : "memory");
> }   
> 
> 
> 
> Do you think you can just fix it in one of your changes without
> official patch?
It''s obviously not used. It''s probably not even useful (we
know what VMCS we
last loaded). I''ll just remove it.

 -- Keir
> thanks much,
> Mukesh