xen.org
2011-Nov-21 03:40 UTC
[xen-unstable bisection] complete test-amd64-i386-rhel6hvm-intel
branch xen-unstable
xen branch xen-unstable
job test-amd64-i386-rhel6hvm-intel
test redhat-install
Tree: linux git://github.com/jsgf/linux-xen.git
Tree: qemu git://hg.uk.xensource.com/HG/qemu-xen-unstable.git
Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
Bug introduced: 7a9a1261a6b0
Bug not present: 9a1a71f7bef2
changeset: 24163:7a9a1261a6b0
user: Jean Guyader <jean.guyader@eu.citrix.com>
date: Fri Nov 18 13:41:33 2011 +0000
add_to_physmap: Move the code for XENMEM_add_to_physmap
Move the code for the XENMEM_add_to_physmap case into it''s own
function (xenmem_add_to_physmap).
Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>
Committed-by: Keir Fraser <keir@xen.org>
For bisection revision-tuple graph see:
http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.test-amd64-i386-rhel6hvm-intel.redhat-install.html
Revision IDs in each graph node refer, respectively, to the Trees above.
----------------------------------------
Searching for failure / basis pass:
9915 fail [host=field-cricket] / 9855 [host=itch-mite] 9832 [host=gall-mite]
9817 ok.
Failure / basis pass flights: 9915 / 9817
Tree: linux git://github.com/jsgf/linux-xen.git
Tree: qemu git://hg.uk.xensource.com/HG/qemu-xen-unstable.git
Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
Latest 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 335e8273a3f3
Basis pass 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 dbdc840f8f62
Generating revisions with ./adhoc-revtuple-generator
git://github.com/jsgf/linux-xen.git#6bec8b4a4c14095d0b7ce424db9d583c3decae6c-6bec8b4a4c14095d0b7ce424db9d583c3decae6c
git://hg.uk.xensource.com/HG/qemu-xen-unstable.git#52834188eedfbbca5636fd869d4c86b3b3044439-52834188eedfbbca5636fd869d4c86b3b3044439
http://xenbits.xen.org/staging/xen-unstable.hg#dbdc840f8f62-335e8273a3f3
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
Loaded 107 nodes in revision graph
Searching for test results:
9817 pass 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 dbdc840f8f62
9866 [host=gall-mite]
9878 [host=bush-cricket]
9864 []
9867 [host=gall-mite]
9832 [host=gall-mite]
9883 fail 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 7a9a1261a6b0
9919 [host=gall-mite]
9868 [host=itch-mite]
9895 fail 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 335e8273a3f3
9855 [host=itch-mite]
9885 [host=bush-cricket]
9873 [host=itch-mite]
9857 [host=bush-cricket]
9874 [host=itch-mite]
9859 [host=bush-cricket]
9911 [host=itch-mite]
9887 [host=bush-cricket]
9861 [host=bush-cricket]
9860 [host=gall-mite]
9897 pass 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 aeb628c5af3f
9888 [host=bush-cricket]
9862 [host=bush-cricket]
9875 [host=itch-mite]
9865 [host=gall-mite]
9901 [host=itch-mite]
9872 fail 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 fe3e9d0c123c
9889 [host=bush-cricket]
9877 [host=itch-mite]
9898 pass 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 9a1a71f7bef2
9879 pass 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 dbdc840f8f62
9890 [host=bush-cricket]
9881 fail 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 fe3e9d0c123c
9899 fail 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 7a9a1261a6b0
9882 pass 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 d7e6bfa114d0
9891 [host=bush-cricket]
9904 [host=bush-cricket]
9884 fail 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 335e8273a3f3
9893 [host=bush-cricket]
9892 [host=bush-cricket]
9912 [host=itch-mite]
9894 pass 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 dbdc840f8f62
9907 [host=itch-mite]
9900 pass 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 9a1a71f7bef2
9902 [host=bush-cricket]
9927 fail 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 7a9a1261a6b0
9903 [host=bush-cricket]
9913 [host=itch-mite]
9922 [host=gall-mite]
9908 [host=itch-mite]
9916 [host=gall-mite]
9910 [host=itch-mite]
9906 [host=gall-mite]
9920 [host=gall-mite]
9914 [host=itch-mite]
9918 [host=gall-mite]
9923 [host=gall-mite]
9925 fail 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 7a9a1261a6b0
9921 [host=gall-mite]
9915 fail 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 335e8273a3f3
9926 pass 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 9a1a71f7bef2
Searching for interesting versions
Result found: flight 9817 (pass), for basis pass
Result found: flight 9884 (fail), for basis failure
Repro found: flight 9894 (pass), for basis pass
Repro found: flight 9895 (fail), for basis failure
0 revisions at 6bec8b4a4c14095d0b7ce424db9d583c3decae6c
52834188eedfbbca5636fd869d4c86b3b3044439 9a1a71f7bef2
No revisions left to test, checking graph state.
Result found: flight 9898 (pass), for last pass
Result found: flight 9899 (fail), for first failure
Repro found: flight 9900 (pass), for last pass
Repro found: flight 9925 (fail), for first failure
Repro found: flight 9926 (pass), for last pass
Repro found: flight 9927 (fail), for first failure
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
Bug introduced: 7a9a1261a6b0
Bug not present: 9a1a71f7bef2
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
changeset: 24163:7a9a1261a6b0
user: Jean Guyader <jean.guyader@eu.citrix.com>
date: Fri Nov 18 13:41:33 2011 +0000
add_to_physmap: Move the code for XENMEM_add_to_physmap
Move the code for the XENMEM_add_to_physmap case into it''s own
function (xenmem_add_to_physmap).
Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>
Committed-by: Keir Fraser <keir@xen.org>
Revision graph left in
/home/xc_osstest/results/bisect.xen-unstable.test-amd64-i386-rhel6hvm-intel.redhat-install.{dot,ps,png,html}.
----------------------------------------
9927: ALL FAIL
flight 9927 xen-unstable real-bisect [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/9927/
jobs:
test-amd64-i386-rhel6hvm-intel fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
Ian Jackson
2011-Nov-21 11:37 UTC
Re: [xen-unstable bisection] complete test-amd64-i386-rhel6hvm-intel
xen.org writes ("[xen-unstable bisection] complete
test-amd64-i386-rhel6hvm-intel"):> branch xen-unstable
> xen branch xen-unstable
> job test-amd64-i386-rhel6hvm-intel
> test redhat-install
>
> Tree: linux git://github.com/jsgf/linux-xen.git
> Tree: qemu git://hg.uk.xensource.com/HG/qemu-xen-unstable.git
> Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
>
> *** Found and reproduced problem changeset ***
>
> Bug is in tree: xen http://xenbits.xen.org/staging/xen-unstable.hg
> Bug introduced: 7a9a1261a6b0
> Bug not present: 9a1a71f7bef2
This seems to have completely broken HVM ...
> changeset: 24163:7a9a1261a6b0
> user: Jean Guyader <jean.guyader@eu.citrix.com>
> date: Fri Nov 18 13:41:33 2011 +0000
>
> add_to_physmap: Move the code for XENMEM_add_to_physmap
>
> Move the code for the XENMEM_add_to_physmap case into it''s
own
> function (xenmem_add_to_physmap).
>
> Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>
> Committed-by: Keir Fraser <keir@xen.org>
Ian.
Keir Fraser
2011-Nov-21 11:55 UTC
Re: [xen-unstable bisection] complete test-amd64-i386-rhel6hvm-intel
On 21/11/2011 11:37, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:> xen.org writes ("[xen-unstable bisection] complete > test-amd64-i386-rhel6hvm-intel"): >> branch xen-unstable >> xen branch xen-unstable >> job test-amd64-i386-rhel6hvm-intel >> test redhat-install >> >> Tree: linux git://github.com/jsgf/linux-xen.git >> Tree: qemu git://hg.uk.xensource.com/HG/qemu-xen-unstable.git >> Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg >> >> *** Found and reproduced problem changeset *** >> >> Bug is in tree: xen http://xenbits.xen.org/staging/xen-unstable.hg >> Bug introduced: 7a9a1261a6b0 >> Bug not present: 9a1a71f7bef2 > > This seems to have completely broken HVM ...I''ll revert if there''s no fix forthcoming. -- Keir>> changeset: 24163:7a9a1261a6b0 >> user: Jean Guyader <jean.guyader@eu.citrix.com> >> date: Fri Nov 18 13:41:33 2011 +0000 >> >> add_to_physmap: Move the code for XENMEM_add_to_physmap >> >> Move the code for the XENMEM_add_to_physmap case into it''s own >> function (xenmem_add_to_physmap). >> >> Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com> >> Committed-by: Keir Fraser <keir@xen.org> > > Ian.
Keir Fraser
2011-Nov-21 18:47 UTC
Re: [xen-unstable bisection] complete test-amd64-i386-rhel6hvm-intel
On 21/11/2011 11:55, "Keir Fraser" <keir.xen@gmail.com> wrote:> On 21/11/2011 11:37, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote: > >> xen.org writes ("[xen-unstable bisection] complete >> test-amd64-i386-rhel6hvm-intel"): >>> branch xen-unstable >>> xen branch xen-unstable >>> job test-amd64-i386-rhel6hvm-intel >>> test redhat-install >>> >>> Tree: linux git://github.com/jsgf/linux-xen.git >>> Tree: qemu git://hg.uk.xensource.com/HG/qemu-xen-unstable.git >>> Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg >>> >>> *** Found and reproduced problem changeset *** >>> >>> Bug is in tree: xen http://xenbits.xen.org/staging/xen-unstable.hg >>> Bug introduced: 7a9a1261a6b0 >>> Bug not present: 9a1a71f7bef2 >> >> This seems to have completely broken HVM ... > > I''ll revert if there''s no fix forthcoming.I hear silence so I will revert the series tomorrow morning.> -- Keir > >>> changeset: 24163:7a9a1261a6b0 >>> user: Jean Guyader <jean.guyader@eu.citrix.com> >>> date: Fri Nov 18 13:41:33 2011 +0000 >>> >>> add_to_physmap: Move the code for XENMEM_add_to_physmap >>> >>> Move the code for the XENMEM_add_to_physmap case into it''s own >>> function (xenmem_add_to_physmap). >>> >>> Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com> >>> Committed-by: Keir Fraser <keir@xen.org> >> >> Ian. > >
Jean Guyader
2011-Nov-21 19:43 UTC
Re: [xen-unstable bisection] complete test-amd64-i386-rhel6hvm-intel
On 21 November 2011 18:47, Keir Fraser <keir.xen@gmail.com> wrote:> On 21/11/2011 11:55, "Keir Fraser" <keir.xen@gmail.com> wrote: > >> On 21/11/2011 11:37, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote: >> >>> xen.org writes ("[xen-unstable bisection] complete >>> test-amd64-i386-rhel6hvm-intel"): >>>> branch xen-unstable >>>> xen branch xen-unstable >>>> job test-amd64-i386-rhel6hvm-intel >>>> test redhat-install >>>> >>>> Tree: linux git://github.com/jsgf/linux-xen.git >>>> Tree: qemu git://hg.uk.xensource.com/HG/qemu-xen-unstable.git >>>> Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg >>>> >>>> *** Found and reproduced problem changeset *** >>>> >>>> Bug is in tree: xen http://xenbits.xen.org/staging/xen-unstable.hg >>>> Bug introduced: 7a9a1261a6b0 >>>> Bug not present: 9a1a71f7bef2 >>> >>> This seems to have completely broken HVM ... >> >> I''ll revert if there''s no fix forthcoming. > > I hear silence so I will revert the series tomorrow morning. >Ok. I didn''t managed to replicate the issue yet. Jean>> -- Keir >> >>>> changeset: 24163:7a9a1261a6b0 >>>> user: Jean Guyader <jean.guyader@eu.citrix.com> >>>> date: Fri Nov 18 13:41:33 2011 +0000 >>>> >>>> add_to_physmap: Move the code for XENMEM_add_to_physmap >>>> >>>> Move the code for the XENMEM_add_to_physmap case into it''s own >>>> function (xenmem_add_to_physmap). >>>> >>>> Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com> >>>> Committed-by: Keir Fraser <keir@xen.org> >>> >>> Ian. >> >> > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >
Keir Fraser
2011-Nov-21 21:32 UTC
Re: [xen-unstable bisection] complete test-amd64-i386-rhel6hvm-intel
On 21/11/2011 19:43, "Jean Guyader" <jean.guyader@gmail.com> wrote:> On 21 November 2011 18:47, Keir Fraser <keir.xen@gmail.com> wrote: >> On 21/11/2011 11:55, "Keir Fraser" <keir.xen@gmail.com> wrote: >> >>> On 21/11/2011 11:37, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote: >>> >>>> xen.org writes ("[xen-unstable bisection] complete >>>> test-amd64-i386-rhel6hvm-intel"): >>>>> branch xen-unstable >>>>> xen branch xen-unstable >>>>> job test-amd64-i386-rhel6hvm-intel >>>>> test redhat-install >>>>> >>>>> Tree: linux git://github.com/jsgf/linux-xen.git >>>>> Tree: qemu git://hg.uk.xensource.com/HG/qemu-xen-unstable.git >>>>> Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg >>>>> >>>>> *** Found and reproduced problem changeset *** >>>>> >>>>> Bug is in tree: xen http://xenbits.xen.org/staging/xen-unstable.hg >>>>> Bug introduced: 7a9a1261a6b0 >>>>> Bug not present: 9a1a71f7bef2 >>>> >>>> This seems to have completely broken HVM ... >>> >>> I''ll revert if there''s no fix forthcoming. >> >> I hear silence so I will revert the series tomorrow morning. >> > > Ok. I didn''t managed to replicate the issue yet.Actually, it wasn''t too hard to work out. This bisection is misleading though, as it''s zeroed in on the RCU locking bug, which is already fixed. The bug is actually in a later changeset which modifies hvmloader. Looking at the hvmloader/pci.c changes, the unconditional assignment to low_mem_pgend after the loop is obviously wrong. As is removing the handling for high_mem_pgend==0. I checked in a reworked version that is closer to the original code. Hopefully our tests will work again now. -- Keir> Jean > >>> -- Keir >>> >>>>> changeset: 24163:7a9a1261a6b0 >>>>> user: Jean Guyader <jean.guyader@eu.citrix.com> >>>>> date: Fri Nov 18 13:41:33 2011 +0000 >>>>> >>>>> add_to_physmap: Move the code for XENMEM_add_to_physmap >>>>> >>>>> Move the code for the XENMEM_add_to_physmap case into it''s own >>>>> function (xenmem_add_to_physmap). >>>>> >>>>> Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com> >>>>> Committed-by: Keir Fraser <keir@xen.org> >>>> >>>> Ian. >>> >>> >> >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >>
Jean Guyader
2011-Nov-21 21:51 UTC
Re: [xen-unstable bisection] complete test-amd64-i386-rhel6hvm-intel
On 21/11 09:32, Keir Fraser wrote:> On 21/11/2011 19:43, "Jean Guyader" <jean.guyader@gmail.com> wrote: > > > On 21 November 2011 18:47, Keir Fraser <keir.xen@gmail.com> wrote: > >> On 21/11/2011 11:55, "Keir Fraser" <keir.xen@gmail.com> wrote: > >> > >>> On 21/11/2011 11:37, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote: > >>> > >>>> xen.org writes ("[xen-unstable bisection] complete > >>>> test-amd64-i386-rhel6hvm-intel"): > >>>>> branch xen-unstable > >>>>> xen branch xen-unstable > >>>>> job test-amd64-i386-rhel6hvm-intel > >>>>> test redhat-install > >>>>> > >>>>> Tree: linux git://github.com/jsgf/linux-xen.git > >>>>> Tree: qemu git://hg.uk.xensource.com/HG/qemu-xen-unstable.git > >>>>> Tree: xen http://xenbits.xen.org/staging/xen-unstable.hg > >>>>> > >>>>> *** Found and reproduced problem changeset *** > >>>>> > >>>>> ? Bug is in tree: ?xen http://xenbits.xen.org/staging/xen-unstable.hg > >>>>> ? Bug introduced: ?7a9a1261a6b0 > >>>>> ? Bug not present: 9a1a71f7bef2 > >>>> > >>>> This seems to have completely broken HVM ... > >>> > >>> I''ll revert if there''s no fix forthcoming. > >> > >> I hear silence so I will revert the series tomorrow morning. > >> > > > > Ok. I didn''t managed to replicate the issue yet. > > Actually, it wasn''t too hard to work out. This bisection is misleading > though, as it''s zeroed in on the RCU locking bug, which is already fixed. > The bug is actually in a later changeset which modifies hvmloader. > > Looking at the hvmloader/pci.c changes, the unconditional assignment to > low_mem_pgend after the loop is obviously wrong. As is removing the handling > for high_mem_pgend==0. I checked in a reworked version that is closer to the > original code. > > Hopefully our tests will work again now. >Thanks for looking into it. I would like this serie to get applied in 4.1 but I think that the code have changed a bit. I''ll send a version for 4.1 similar to the one we have in xen-unstable. Jean